From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH v10 5/5] iommu: add rmrr Xen command line option for extra rmrrs Date: Wed, 15 Jul 2015 17:08:51 +0100 Message-ID: <55A6A1B3020000780009180F@mail.emea.novell.com> References: <1436811482-16113-1-git-send-email-elena.ufimtseva@oracle.com> <1436811482-16113-6-git-send-email-elena.ufimtseva@oracle.com> <55A504050200007800090947@mail.emea.novell.com> <55A626F202000078000910E4@mail.emea.novell.com> <20150715152757.GA1966@elena.ufimtseva> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150715152757.GA1966@elena.ufimtseva> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Elena Ufimtseva Cc: yang.z.zhang@intel.com, kevin.tian@intel.com, tim@xen.org, boris.ostrovsky@oracle.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org >>> On 15.07.15 at 17:27, wrote: > On Wed, Jul 15, 2015 at 08:25:06AM +0100, Jan Beulich wrote: >> >>> On 14.07.15 at 12:43, wrote: >> >>>> On 13.07.15 at 20:18, wrote: >> >> +/* Macro for RMRR inclusive range formatting. */ >> >> +#define PRI_RMRR(s,e) "[%lx-%lx]" >> > >> > Just PRI_RMRR (i.e. no parens or parameters) please. And I'm still >> > missing a macro to pair the respective arguments - as said before, >> > as single format specifier should be accompanied by a single >> > argument (as visible to the reader at the use sites). >> >> Answering your IRC question here: >> >> #define ERU_FMT "[%lx-%lx]" >> #define ERU_ARG(eru) eru.base_pfn, eru.end_pfn >> >> (with the acronym "eru" open for improvement). > > Great! Thanks Jan. > Can ERU be RMRRU? ERMRRU maybe - I'd like the "extra" to somehow be expressed in the name. Jan