From: "Jan Beulich" <JBeulich@suse.com>
To: Elena Ufimtseva <elena.ufimtseva@oracle.com>
Cc: yang.z.zhang@intel.com, kevin.tian@intel.com, tim@xen.org,
boris.ostrovsky@oracle.com, xen-devel@lists.xen.org
Subject: Re: [PATCH v10 5/5] iommu: add rmrr Xen command line option for extra rmrrs
Date: Thu, 16 Jul 2015 09:02:22 +0100 [thread overview]
Message-ID: <55A7812E0200007800091B16@mail.emea.novell.com> (raw)
In-Reply-To: <f08a2759-212d-4395-b880-8593d3b8959f@default>
>>> On 15.07.15 at 18:15, <elena.ufimtseva@oracle.com> wrote:
> ----- JBeulich@suse.com wrote:
>
>> >>> On 15.07.15 at 17:27, <elena.ufimtseva@oracle.com> wrote:
>> > On Wed, Jul 15, 2015 at 08:25:06AM +0100, Jan Beulich wrote:
>> >> >>> On 14.07.15 at 12:43, <JBeulich@suse.com> wrote:
>> >> >>>> On 13.07.15 at 20:18, <elena.ufimtseva@oracle.com> wrote:
>> >> >> +/* Macro for RMRR inclusive range formatting. */
>> >> >> +#define PRI_RMRR(s,e) "[%lx-%lx]"
>> >> >
>> >> > Just PRI_RMRR (i.e. no parens or parameters) please. And I'm
>> still
>> >> > missing a macro to pair the respective arguments - as said
>> before,
>> >> > as single format specifier should be accompanied by a single
>> >> > argument (as visible to the reader at the use sites).
>> >>
>> >> Answering your IRC question here:
>> >>
>> >> #define ERU_FMT "[%lx-%lx]"
>> >> #define ERU_ARG(eru) eru.base_pfn, eru.end_pfn
>> >>
>> >> (with the acronym "eru" open for improvement).
>> >
>> > Great! Thanks Jan.
>> > Can ERU be RMRRU?
>>
>> ERMRRU maybe - I'd like the "extra" to somehow be expressed in
>> the name.
>
> Does this imply that it can be used for formatting ACPI RMRRs?
> Or with some modification perharps?
If you wanted that (which would be fine with me if it works as
outlined), then dropping the E or any other remnants of "extra"
would of course be fine. But I doubt that'll be immediately possible
considering that RMRRs have their addresses tracked, while for
extra RMRRs you track MFNs (i.e. you'd first need to convert
one of them).
Jan
next prev parent reply other threads:[~2015-07-16 8:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 16:15 [PATCH v10 5/5] iommu: add rmrr Xen command line option for extra rmrrs Elena Ufimtseva
2015-07-16 8:02 ` Jan Beulich [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-07-16 16:00 Elena Ufimtseva
2015-07-13 18:17 [PATCH v10 0/5] iommu: add rmrr Xen command line option elena.ufimtseva
2015-07-13 18:18 ` [PATCH v10 5/5] iommu: add rmrr Xen command line option for extra rmrrs elena.ufimtseva
2015-07-14 10:43 ` Jan Beulich
2015-07-15 7:25 ` Jan Beulich
2015-07-15 15:27 ` Elena Ufimtseva
2015-07-15 16:08 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A7812E0200007800091B16@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=elena.ufimtseva@oracle.com \
--cc=kevin.tian@intel.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.