From: Shuah Khan <shuahkh@osg.samsung.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: mchehab@osg.samsung.com, hans.verkuil@cisco.com,
laurent.pinchart@ideasonboard.com, tiwai@suse.de, perex@perex.cz,
crope@iki.fi, sakari.ailus@linux.intel.com, arnd@arndb.de,
stefanr@s5r6.in-berlin.de, ruchandani.tina@gmail.com,
chehabrafael@gmail.com, prabhakar.csengg@gmail.com,
chris.j.arges@canonical.com, agoode@google.com,
pierre-louis.bossart@linux.intel.com, gtmkramer@xs4all.nl,
clemens@ladisch.de, daniel@zonque.org, vladcatoi@gmail.com,
misterpib@gmail.com, damien@zamaudio.com,
pmatilai@laiskiainen.org, takamichiho@gmail.com,
normalperson@yhbt.net, bugzilla.frnkcg@spamgourmet.com,
joe@oampo.co.uk, calcprogrammer1@gmail.com, jussi@sonarnerd.net,
linux-media@vger.kernel.org, alsa-devel@alsa-project.org,
Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [PATCH 6/7] media: au0828 change to use Managed Media Controller API
Date: Mon, 20 Jul 2015 13:10:46 -0600 [thread overview]
Message-ID: <55AD47B6.8030507@osg.samsung.com> (raw)
In-Reply-To: <20150720190128.GM5422@mwanda>
On 07/20/2015 01:01 PM, Dan Carpenter wrote:
> On Mon, Jul 20, 2015 at 09:55:50AM -0600, Shuah Khan wrote:
>>>> #ifdef CONFIG_MEDIA_CONTROLLER
>>>> - if (dev->media_dev) {
>>>> - media_device_unregister(dev->media_dev);
>>>> - kfree(dev->media_dev);
>>>> - dev->media_dev = NULL;
>>>> + if (dev->media_dev &&
>>>> + media_devnode_is_registered(&dev->media_dev->devnode)) {
>>>> + media_device_unregister_entity_notify(dev->media_dev,
>>>> + &dev->entity_notify);
>>>> + media_device_unregister(dev->media_dev);
>>>> + dev->media_dev = NULL;
>>>
>>>
>>> The indenting is slightly off here. It should be:
>>>
>>> if (dev->media_dev &&
>>> media_devnode_is_registered(&dev->media_dev->devnode)) {
>>> media_device_unregister_entity_notify(dev->media_dev,
>>> &dev->entity_notify);
>>> media_device_unregister(dev->media_dev);
>>> dev->media_dev = NULL;
>>> }
>>>
>>> Aligning if statements using spaces like that is nicer and checkpatch.pl
>>> won't complain.
>>>
>>
>> Yeah. I try to do that whenever. In this case, if I align, the line
>> becomes longer than 80 chars adding more things to worry about. In
>> such cases, I tend to not worry about aligning.
>
> The main thing is that the body of the if statement is intended 16
> spaces instead of 8. Otherwise I wouldn't have commented.
>
Yes. I see what you are saying. I will fix it in v2 series.
thanks,
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978
next prev parent reply other threads:[~2015-07-20 19:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 0:33 [PATCH 0/7] Update ALSA, and au0828 drivers to use Managed Media Controller API Shuah Khan
2015-07-15 0:33 ` [PATCH] media-ctl: Update to add support for ALSA devices Shuah Khan
2015-07-15 0:34 ` [PATCH 1/7] Revert "[media] media: media controller entity framework enhancements for ALSA" Shuah Khan
2015-07-15 0:34 ` [PATCH 2/7] media: Media Controller register/unregister entity_notify API Shuah Khan
2015-07-15 0:34 ` [PATCH 3/7] media: Add ALSA Media Controller devnodes Shuah Khan
2015-07-15 0:34 ` [PATCH 4/7] media: change dvb-frontend to honor MC tuner enable error Shuah Khan
2015-07-15 0:34 ` [PATCH 5/7] media: au8522 change to create MC pad for ALSA Audio Out Shuah Khan
2015-07-15 0:34 ` [PATCH 6/7] media: au0828 change to use Managed Media Controller API Shuah Khan
2015-07-20 8:42 ` Dan Carpenter
2015-07-20 15:55 ` Shuah Khan
2015-07-20 19:01 ` Dan Carpenter
2015-07-20 19:10 ` Shuah Khan [this message]
2015-07-15 0:34 ` [PATCH 7/7] sound/usb: Update ALSA driver " Shuah Khan
2015-07-20 8:47 ` Dan Carpenter
2015-07-20 9:00 ` Takashi Iwai
2015-07-20 14:22 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AD47B6.8030507@osg.samsung.com \
--to=shuahkh@osg.samsung.com \
--cc=agoode@google.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=bugzilla.frnkcg@spamgourmet.com \
--cc=calcprogrammer1@gmail.com \
--cc=chehabrafael@gmail.com \
--cc=chris.j.arges@canonical.com \
--cc=clemens@ladisch.de \
--cc=crope@iki.fi \
--cc=damien@zamaudio.com \
--cc=dan.carpenter@oracle.com \
--cc=daniel@zonque.org \
--cc=gtmkramer@xs4all.nl \
--cc=hans.verkuil@cisco.com \
--cc=joe@oampo.co.uk \
--cc=jussi@sonarnerd.net \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=misterpib@gmail.com \
--cc=normalperson@yhbt.net \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=pmatilai@laiskiainen.org \
--cc=prabhakar.csengg@gmail.com \
--cc=ruchandani.tina@gmail.com \
--cc=sakari.ailus@linux.intel.com \
--cc=stefanr@s5r6.in-berlin.de \
--cc=takamichiho@gmail.com \
--cc=tiwai@suse.de \
--cc=vladcatoi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.