From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753504AbbGWNGp (ORCPT ); Thu, 23 Jul 2015 09:06:45 -0400 Received: from smtp.domeneshop.no ([194.63.252.55]:60946 "EHLO smtp.domeneshop.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753448AbbGWNGT (ORCPT ); Thu, 23 Jul 2015 09:06:19 -0400 Message-ID: <55B0E6C1.2040702@tronnes.org> Date: Thu, 23 Jul 2015 15:06:09 +0200 From: =?UTF-8?B?Tm9yYWxmIFRyw7hubmVz?= User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Henri Chain , thomas.petazzoni@free-electrons.com CC: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, sudipm.mukherjee@gmail.com Subject: Re: [PATCH v2] Staging: fbtft: Add support for the Ultrachip UC1611 LCD controller References: <1436878779-12400-1-git-send-email-henri.chain@eleves.ec-nantes.fr> In-Reply-To: <1436878779-12400-1-git-send-email-henri.chain@eleves.ec-nantes.fr> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Den 14.07.2015 14:59, skrev Henri Chain: > This is a driver chip for 240x160 4-bit greyscale LCDs. > It is capable of 4-wire (8 bit) or 3-wire (9 bit) SPI that have both been > tested. (It also has a 6800 or 8080-style parallel interface, but I have > not included support for it.) > > Signed-off-by: Henri Chain > --- > diff --git a/drivers/staging/fbtft/fb_uc1611.c b/drivers/staging/fbtft/fb_uc1611.c > +static int init_display(struct fbtft_par *par) > +{ > + int ret; > + > + fbtft_par_dbg(DEBUG_INIT_DISPLAY, par, "%s()\n", __func__); > + > + /* Set CS active high */ > + par->spi->mode |= SPI_CS_HIGH; Why is this set here and not in fbtft_device along side SPI_MODE_3? > +static int set_var(struct fbtft_par *par) > +{ > + fbtft_par_dbg(DEBUG_INIT_DISPLAY, par, "%s()\n", __func__); > + > + /* par->info->fix.visual = FB_VISUAL_PSEUDOCOLOR; */ This comment can be removed I guess.