From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751456AbbGXEE1 (ORCPT ); Fri, 24 Jul 2015 00:04:27 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:44718 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750778AbbGXEEZ (ORCPT ); Fri, 24 Jul 2015 00:04:25 -0400 Message-ID: <55B1B947.6080102@wwwdotorg.org> Date: Thu, 23 Jul 2015 22:04:23 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: =?UTF-8?B?Tm9yYWxmIFRyw7hubmVz?= CC: tglx@linutronix.de, jason@lakedaemon.net, linux-rpi-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] irqchip: bcm2835: Add FIQ support References: <1434130016-26574-1-git-send-email-noralf@tronnes.org> <55822C71.2040409@wwwdotorg.org> <55AFA3BD.80507@tronnes.org> In-Reply-To: <55AFA3BD.80507@tronnes.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/22/2015 08:07 AM, Noralf Trønnes wrote: > > Den 18.06.2015 04:26, skrev Stephen Warren: >> On 06/12/2015 11:26 AM, Noralf Trønnes wrote: >>> Add a duplicate irq range with an offset on the hwirq's so the >>> driver can detect that enable_fiq() is used. >>> Tested with downstream dwc_otg USB controller driver. >> This basically looks OK, but a few comments/thoughts: >> >> a) Should the Kconfig change be a separate patch since it's a separate >> subsystem? > > Is this a yes since you haven't acked it? I didn't ack it because I thought there were still outstanding review comments. Looking back at the thread, everything is resolved. Acked-by: Stephen Warren Whether the driver and Kconfig patch need to be in separate patches largely depends on who will merge it. If there's a desire to merge the two parts through separate subsystems, separate patches will be needed, else not. I'll leave that up to the IRQ subsystem maintainers and Lee (or Eric) since they're actually merging the bcm2835 patches. From mboxrd@z Thu Jan 1 00:00:00 1970 From: swarren@wwwdotorg.org (Stephen Warren) Date: Thu, 23 Jul 2015 22:04:23 -0600 Subject: [PATCH] irqchip: bcm2835: Add FIQ support In-Reply-To: <55AFA3BD.80507@tronnes.org> References: <1434130016-26574-1-git-send-email-noralf@tronnes.org> <55822C71.2040409@wwwdotorg.org> <55AFA3BD.80507@tronnes.org> Message-ID: <55B1B947.6080102@wwwdotorg.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 07/22/2015 08:07 AM, Noralf Tr?nnes wrote: > > Den 18.06.2015 04:26, skrev Stephen Warren: >> On 06/12/2015 11:26 AM, Noralf Tr?nnes wrote: >>> Add a duplicate irq range with an offset on the hwirq's so the >>> driver can detect that enable_fiq() is used. >>> Tested with downstream dwc_otg USB controller driver. >> This basically looks OK, but a few comments/thoughts: >> >> a) Should the Kconfig change be a separate patch since it's a separate >> subsystem? > > Is this a yes since you haven't acked it? I didn't ack it because I thought there were still outstanding review comments. Looking back at the thread, everything is resolved. Acked-by: Stephen Warren Whether the driver and Kconfig patch need to be in separate patches largely depends on who will merge it. If there's a desire to merge the two parts through separate subsystems, separate patches will be needed, else not. I'll leave that up to the IRQ subsystem maintainers and Lee (or Eric) since they're actually merging the bcm2835 patches.