From: Denys Vlasenko <dvlasenk@redhat.com>
To: Emmanuel Grumbach <egrumbach@gmail.com>,
Denys Vlasenko <vda.linux@googlemail.com>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Johannes Berg <johannes.berg@intel.com>,
"John W. Linville" <linville@tuxdriver.com>,
Intel Linux Wireless <ilw@linux.intel.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iwlwifi: Deinline iwl_{read,write}{8,32}
Date: Sun, 09 Aug 2015 21:38:05 +0200 [thread overview]
Message-ID: <55C7AC1D.7050602@redhat.com> (raw)
In-Reply-To: <CANUX_P2=J81pJpyeMLEf+un=Pe8MhoGz7QJrrRUe19oeux8BhQ@mail.gmail.com>
On 07/15/2015 07:49 PM, Emmanuel Grumbach wrote:
> On Tue, Jul 14, 2015 at 3:41 PM, Denys Vlasenko
> <vda.linux@googlemail.com> wrote:
>> On Tue, Jul 14, 2015 at 2:38 PM, Sergei Shtylyov
>> <sergei.shtylyov@cogentembedded.com> wrote:
>>>> +#define IWL_READ_WRITE(static_inline) \
>>>> +static_inline void iwl_write8(struct iwl_trans *trans, u32 ofs, u8 val) \
>>>> +{ \
>>>> + trace_iwlwifi_dev_iowrite8(trans->dev, ofs, val); \
>>>> + iwl_trans_write8(trans, ofs, val); \
>>>> +} \
>>> [...]
>>>>
>>>> +#if !defined(CONFIG_IWLWIFI_DEVICE_TRACING)
>>>> +IWL_READ_WRITE(static inline)
>>>
>>> Not static_inline?
>>
>> Yes. Here we are putting two words, "static inline", in front of every
>> function definition.
>> --
>
> I'll try to come up with a patch that is easier for me to read, but I
> am really busy right now. Ping me in a week if you have heard from me
> earlier.
So how it is going with this patch?
In hindsight, I would use a different name for the macro parameter here:
#define IWL_READ_WRITE(static_inline) \
+static_inline void iwl_write8(...)
"static_inline" proved to be confusing.
Maybe perform s/static_inline/func_qualifier/ on the patch...
next prev parent reply other threads:[~2015-08-09 19:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 12:22 [PATCH] iwlwifi: Deinline iwl_{read,write}{8,32} Denys Vlasenko
2015-07-14 12:38 ` Sergei Shtylyov
2015-07-14 12:41 ` Denys Vlasenko
2015-07-15 17:49 ` Emmanuel Grumbach
2015-08-09 19:38 ` Denys Vlasenko [this message]
2015-08-24 9:53 ` Emmanuel Grumbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C7AC1D.7050602@redhat.com \
--to=dvlasenk@redhat.com \
--cc=egrumbach@gmail.com \
--cc=emmanuel.grumbach@intel.com \
--cc=ilw@linux.intel.com \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=vda.linux@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.