All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
* [[meta-ruby][PATCH 1/2] ruby.bbclass: handle new installation directories
@ 2015-08-20 20:28 Mark Asselstine
  2015-08-20 20:28 ` [[meta-ruby][PATCH 2/2] bundler: remove broad FILES definition Mark Asselstine
  2015-08-20 21:51 ` [[meta-ruby][PATCH 1/2] ruby.bbclass: handle new installation directories akuster808
  0 siblings, 2 replies; 3+ messages in thread
From: Mark Asselstine @ 2015-08-20 20:28 UTC (permalink / raw
  To: akuster808, Martin.Jansa, openembedded-devel

It appears that newer versions of ruby produce additional directories
which were not previously handled by the ruby bbclass, specifically
'build_info' and 'extensions'. This is currently resulting in QA
errors/warnings such as:

ERROR: QA Issue: puppet: Files/directories were installed but not shipped in any package:
  /usr/lib64/ruby/gems/2.2.0/build_info
  /usr/lib64/ruby/gems/2.2.0/extensions
Please set FILES such that these items are packaged. Alternatively if they are unneeded,
avoid installing them or delete them within do_install. [installed-vs-shipped]

Add these to our FILES in the bbclass such that they will packaged.

NOTE: several files may exist in the extensions directory such as
gem.build_complete and mkmf.log that we can most likely remove during
do_install. Since ruby installs these by default they have been left
in case their existence is used as some type of stampfile or similar.

Signed-off-by: Mark Asselstine <mark.asselstine@windriver.com>
---
 meta-ruby/classes/ruby.bbclass | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/meta-ruby/classes/ruby.bbclass b/meta-ruby/classes/ruby.bbclass
index 9c4fcf9..ef844f2 100644
--- a/meta-ruby/classes/ruby.bbclass
+++ b/meta-ruby/classes/ruby.bbclass
@@ -111,6 +111,10 @@ FILES_${PN}-dbg += " \
         ${libdir}/ruby/gems/${RUBY_GEM_VERSION}/gems/*/*/*/.debug \
         ${libdir}/ruby/gems/${RUBY_GEM_VERSION}/gems/*/*/*/*/.debug \
         ${libdir}/ruby/gems/${RUBY_GEM_VERSION}/gems/*/*/*/*/*/.debug \
+        ${libdir}/ruby/gems/${RUBY_GEM_VERSION}/extensions/*/*/.debug \
+        ${libdir}/ruby/gems/${RUBY_GEM_VERSION}/extensions/*/*/*/.debug \
+        ${libdir}/ruby/gems/${RUBY_GEM_VERSION}/extensions/*/*/*/*/.debug \
+        ${libdir}/ruby/gems/${RUBY_GEM_VERSION}/extensions/*/*/*/*/*/.debug \
         "
 
 FILES_${PN} += " \
@@ -118,6 +122,8 @@ FILES_${PN} += " \
         ${libdir}/ruby/gems/${RUBY_GEM_VERSION}/cache \
         ${libdir}/ruby/gems/${RUBY_GEM_VERSION}/bin \
         ${libdir}/ruby/gems/${RUBY_GEM_VERSION}/specifications \
+        ${libdir}/ruby/gems/${RUBY_GEM_VERSION}/build_info \
+        ${libdir}/ruby/gems/${RUBY_GEM_VERSION}/extensions \
         "
 
 FILES_${PN}-doc += " \
-- 
2.1.4



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [[meta-ruby][PATCH 2/2] bundler: remove broad FILES definition
  2015-08-20 20:28 [[meta-ruby][PATCH 1/2] ruby.bbclass: handle new installation directories Mark Asselstine
@ 2015-08-20 20:28 ` Mark Asselstine
  2015-08-20 21:51 ` [[meta-ruby][PATCH 1/2] ruby.bbclass: handle new installation directories akuster808
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Asselstine @ 2015-08-20 20:28 UTC (permalink / raw
  To: akuster808, Martin.Jansa, openembedded-devel

This effectively reverts commit
4e8853ca05f797281469ae7c7ce0c0b3ccf0d7c1 [bundler: Fix QA new Error]

The original QA error is now handled by changes to the ruby.bbclass to
properly handle build_info and extensions directories that Ruby 2.0.0
now creates while installing gems.

This revert isn't specifically required but by removing this broad
definition of FILES the hope is that other ruby recipes won't copy
this behavior which can actually lead to other QA errors/warnings,
depending on what gets installed in the build_info and extensions
directories.

Signed-off-by: Mark Asselstine <mark.asselstine@windriver.com>
---
 meta-ruby/recipes-devtools/ruby/bundler_git.bb | 2 --
 1 file changed, 2 deletions(-)

diff --git a/meta-ruby/recipes-devtools/ruby/bundler_git.bb b/meta-ruby/recipes-devtools/ruby/bundler_git.bb
index 7d79544..31e72e5 100644
--- a/meta-ruby/recipes-devtools/ruby/bundler_git.bb
+++ b/meta-ruby/recipes-devtools/ruby/bundler_git.bb
@@ -26,8 +26,6 @@ SRC_URI = " \
 
 inherit ruby
 
-FILES_${PN} += "${libdir}/ruby/gems"
-
 RDEPENDS_${PN} = "git"
 
 BBCLASSEXTEND = "native"
-- 
2.1.4



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [[meta-ruby][PATCH 1/2] ruby.bbclass: handle new installation directories
  2015-08-20 20:28 [[meta-ruby][PATCH 1/2] ruby.bbclass: handle new installation directories Mark Asselstine
  2015-08-20 20:28 ` [[meta-ruby][PATCH 2/2] bundler: remove broad FILES definition Mark Asselstine
@ 2015-08-20 21:51 ` akuster808
  1 sibling, 0 replies; 3+ messages in thread
From: akuster808 @ 2015-08-20 21:51 UTC (permalink / raw
  To: Mark Asselstine, Martin.Jansa, openembedded-devel

Thanks

- Armin

On 08/20/2015 01:28 PM, Mark Asselstine wrote:
> It appears that newer versions of ruby produce additional directories
> which were not previously handled by the ruby bbclass, specifically
> 'build_info' and 'extensions'. This is currently resulting in QA
> errors/warnings such as:
>
> ERROR: QA Issue: puppet: Files/directories were installed but not shipped in any package:
>    /usr/lib64/ruby/gems/2.2.0/build_info
>    /usr/lib64/ruby/gems/2.2.0/extensions
> Please set FILES such that these items are packaged. Alternatively if they are unneeded,
> avoid installing them or delete them within do_install. [installed-vs-shipped]
>
> Add these to our FILES in the bbclass such that they will packaged.
>
> NOTE: several files may exist in the extensions directory such as
> gem.build_complete and mkmf.log that we can most likely remove during
> do_install. Since ruby installs these by default they have been left
> in case their existence is used as some type of stampfile or similar.
>
> Signed-off-by: Mark Asselstine <mark.asselstine@windriver.com>
> ---
>   meta-ruby/classes/ruby.bbclass | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/meta-ruby/classes/ruby.bbclass b/meta-ruby/classes/ruby.bbclass
> index 9c4fcf9..ef844f2 100644
> --- a/meta-ruby/classes/ruby.bbclass
> +++ b/meta-ruby/classes/ruby.bbclass
> @@ -111,6 +111,10 @@ FILES_${PN}-dbg += " \
>           ${libdir}/ruby/gems/${RUBY_GEM_VERSION}/gems/*/*/*/.debug \
>           ${libdir}/ruby/gems/${RUBY_GEM_VERSION}/gems/*/*/*/*/.debug \
>           ${libdir}/ruby/gems/${RUBY_GEM_VERSION}/gems/*/*/*/*/*/.debug \
> +        ${libdir}/ruby/gems/${RUBY_GEM_VERSION}/extensions/*/*/.debug \
> +        ${libdir}/ruby/gems/${RUBY_GEM_VERSION}/extensions/*/*/*/.debug \
> +        ${libdir}/ruby/gems/${RUBY_GEM_VERSION}/extensions/*/*/*/*/.debug \
> +        ${libdir}/ruby/gems/${RUBY_GEM_VERSION}/extensions/*/*/*/*/*/.debug \
>           "
>
>   FILES_${PN} += " \
> @@ -118,6 +122,8 @@ FILES_${PN} += " \
>           ${libdir}/ruby/gems/${RUBY_GEM_VERSION}/cache \
>           ${libdir}/ruby/gems/${RUBY_GEM_VERSION}/bin \
>           ${libdir}/ruby/gems/${RUBY_GEM_VERSION}/specifications \
> +        ${libdir}/ruby/gems/${RUBY_GEM_VERSION}/build_info \
> +        ${libdir}/ruby/gems/${RUBY_GEM_VERSION}/extensions \
>           "
>
>   FILES_${PN}-doc += " \
>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-08-20 21:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-20 20:28 [[meta-ruby][PATCH 1/2] ruby.bbclass: handle new installation directories Mark Asselstine
2015-08-20 20:28 ` [[meta-ruby][PATCH 2/2] bundler: remove broad FILES definition Mark Asselstine
2015-08-20 21:51 ` [[meta-ruby][PATCH 1/2] ruby.bbclass: handle new installation directories akuster808

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.