From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753854AbbHaQGv (ORCPT ); Mon, 31 Aug 2015 12:06:51 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:38180 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753106AbbHaQGu (ORCPT ); Mon, 31 Aug 2015 12:06:50 -0400 Subject: Re: [PATCH v4 2/2] iio: bmg160: Add SPI driver To: Markus Pargmann References: <1439986366-25291-1-git-send-email-mpa@pengutronix.de> <1439986366-25291-3-git-send-email-mpa@pengutronix.de> Cc: Srinivas Pandruvada , Irina Tirdea , Vlad Dogaru , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de From: Jonathan Cameron Message-ID: <55E47B98.2050901@kernel.org> Date: Mon, 31 Aug 2015 17:06:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1439986366-25291-3-git-send-email-mpa@pengutronix.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/08/15 13:12, Markus Pargmann wrote: > Signed-off-by: Markus Pargmann Applied to the togreg branch of iio.git - initially pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/iio/gyro/Kconfig | 7 +++++- > drivers/iio/gyro/Makefile | 1 + > drivers/iio/gyro/bmg160_spi.c | 57 +++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 64 insertions(+), 1 deletion(-) > create mode 100644 drivers/iio/gyro/bmg160_spi.c > > diff --git a/drivers/iio/gyro/Kconfig b/drivers/iio/gyro/Kconfig > index 94526b13d49f..e816d29d6a62 100644 > --- a/drivers/iio/gyro/Kconfig > +++ b/drivers/iio/gyro/Kconfig > @@ -56,18 +56,23 @@ config BMG160 > select IIO_BUFFER > select IIO_TRIGGERED_BUFFER > select BMG160_I2C if (I2C) > + select BMG160_SPI if (SPI) > help > Say yes here to build support for BOSCH BMG160 Tri-axis Gyro Sensor > driver connected via I2C or SPI. This driver also supports BMI055 > gyroscope. > > This driver can also be built as a module. If so, the module > - will be called bmg160_i2c. > + will be called bmg160_i2c or bmg160_spi. > > config BMG160_I2C > tristate > select REGMAP_I2C > > +config BMG160_SPI > + tristate > + select REGMAP_SPI > + > config HID_SENSOR_GYRO_3D > depends on HID_SENSOR_HUB > select IIO_BUFFER > diff --git a/drivers/iio/gyro/Makefile b/drivers/iio/gyro/Makefile > index 608401041550..f866a4be0667 100644 > --- a/drivers/iio/gyro/Makefile > +++ b/drivers/iio/gyro/Makefile > @@ -10,6 +10,7 @@ obj-$(CONFIG_ADIS16260) += adis16260.o > obj-$(CONFIG_ADXRS450) += adxrs450.o > obj-$(CONFIG_BMG160) += bmg160_core.o > obj-$(CONFIG_BMG160_I2C) += bmg160_i2c.o > +obj-$(CONFIG_BMG160_SPI) += bmg160_spi.o > > obj-$(CONFIG_HID_SENSOR_GYRO_3D) += hid-sensor-gyro-3d.o > > diff --git a/drivers/iio/gyro/bmg160_spi.c b/drivers/iio/gyro/bmg160_spi.c > new file mode 100644 > index 000000000000..021ea5fe6a37 > --- /dev/null > +++ b/drivers/iio/gyro/bmg160_spi.c > @@ -0,0 +1,57 @@ > +#include > +#include > +#include > +#include > + > +#include "bmg160.h" > + > +static const struct regmap_config bmg160_regmap_spi_conf = { > + .reg_bits = 8, > + .val_bits = 8, > + .max_register = 0x3f, > +}; > + > +static int bmg160_spi_probe(struct spi_device *spi) > +{ > + struct regmap *regmap; > + const struct spi_device_id *id = spi_get_device_id(spi); > + > + regmap = devm_regmap_init_spi(spi, &bmg160_regmap_spi_conf); > + if (IS_ERR(regmap)) { > + dev_err(&spi->dev, "Failed to register spi regmap %d\n", > + (int)PTR_ERR(regmap)); > + return PTR_ERR(regmap); > + } > + > + return bmg160_core_probe(&spi->dev, regmap, spi->irq, id->name); > +} > + > +static int bmg160_spi_remove(struct spi_device *spi) > +{ > + bmg160_core_remove(&spi->dev); > + > + return 0; > +} > + > +static const struct spi_device_id bmg160_spi_id[] = { > + {"bmg160", 0}, > + {"bmi055_gyro", 0}, > + {} > +}; > + > +MODULE_DEVICE_TABLE(spi, bmg160_spi_id); > + > +static struct spi_driver bmg160_spi_driver = { > + .driver = { > + .name = "bmg160_spi", > + .pm = &bmg160_pm_ops, > + }, > + .probe = bmg160_spi_probe, > + .remove = bmg160_spi_remove, > + .id_table = bmg160_spi_id, > +}; > +module_spi_driver(bmg160_spi_driver); > + > +MODULE_AUTHOR("Markus Pargmann "); > +MODULE_LICENSE("GPL v2"); > +MODULE_DESCRIPTION("BMG160 SPI Gyro driver"); >