From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53358) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWjek-0000tl-GS for qemu-devel@nongnu.org; Tue, 01 Sep 2015 07:23:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZWjeg-0006L4-JC for qemu-devel@nongnu.org; Tue, 01 Sep 2015 07:23:14 -0400 References: <1440703987-29012-1-git-send-email-lvivier@redhat.com> <1440703987-29012-7-git-send-email-lvivier@redhat.com> From: Laurent Vivier Message-ID: <55E58A9B.5060200@redhat.com> Date: Tue, 1 Sep 2015 13:23:07 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 6/9] arm: clarify the use of muldiv64() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Trivial , QEMU Developers On 01/09/2015 13:17, Peter Maydell wrote: > On 27 August 2015 at 20:33, Laurent Vivier wrote: >> muldiv64() is used to convert microseconds into CPU ticks. >> >> But it is not clear and not commented. This patch uses macro >> to clearly identify what is used: time, CPU frequency and ticks. >> For an elapsed time and a given frequency, we compute how many ticks >> we have. >> >> Signed-off-by: Laurent Vivier >> --- >> v2: replace "arm: remove muldiv64()" >> target-arm/helper.c | 14 ++++++++------ >> 1 file changed, 8 insertions(+), 6 deletions(-) >> >> diff --git a/target-arm/helper.c b/target-arm/helper.c >> index 7df1f06..4455761 100644 >> --- a/target-arm/helper.c >> +++ b/target-arm/helper.c >> @@ -12,6 +12,8 @@ >> #include /* For crc32 */ >> #include "exec/semihost.h" >> >> +#define ARM_CPU_FREQ 1000000000 /* FIXME: 1 GHz, should be configurable */ > > LL suffix for large constants, please. In fact, I didn't put the LL suffix to not force the use of a 64bit on a 32bit machines. Moreover in muldiv64() it is used as a 32bit value. But if you think it is better, I will. Have I to resend the whole series or only this patch ? Perhaps the commiter can edit it ? > > Otherwise > Acked-by: Peter Maydell > > (assuming you're planning to put this somewhere other than the > target-arm tree). > > thanks > -- PMM >