From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753054AbbIHGE5 (ORCPT ); Tue, 8 Sep 2015 02:04:57 -0400 Received: from mail-am1on0072.outbound.protection.outlook.com ([157.56.112.72]:11072 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752817AbbIHGEv (ORCPT ); Tue, 8 Sep 2015 02:04:51 -0400 Authentication-Results: spf=pass (sender IP is 193.47.165.134) smtp.mailfrom=mellanox.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=mellanox.com; Subject: Re: [PATCH 3/7] devcg: Added infrastructure for rdma device cgroup. To: Parav Pandit , , , , , , , , References: <1441658303-18081-1-git-send-email-pandit.parav@gmail.com> <1441658303-18081-4-git-send-email-pandit.parav@gmail.com> CC: , , , , , , , From: Haggai Eran Message-ID: <55EE72B7.1060304@mellanox.com> Date: Tue, 8 Sep 2015 08:31:35 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1441658303-18081-4-git-send-email-pandit.parav@gmail.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.0.52.254] X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;DB3FFO11FD024;1:sTEfZq0n1iuvC80b9sJzNtfxovMuLk/x3PYnKkpACJsC20bqsvPlO+dFyMDmShgiKe6nTjJDcnzJobVf3QXG94FPUoguuJeqLwkiDgd9SDLtg1evG2zGMRo1bG1REo9nlOedjxC2gGq7WirmSYznw/0kj9j/YoO9j7eZtbbDMI6+DxCOgNBdK5ZaDIZWKSKeciviTPV3HgVHxKeMz8YXmnUhlrcJcwrrYy27Q+8OhpzyU5VqgHITMWHgkDQsOdU6EAEEcMsYZpVFcOH131xVoYrXlLHi7+lNM21K6eEBT7Q1hG6sjHppwszqj1PlQeOcIzB2Cp0EbE7ksh0JNopabeULLizBeeJRaE/jQgWrY5/Pzl8UFNmRV6LN6CL7YJiye26MPgti54XK05H7IF9hz4JDOwU91s/N4loFg+kEKQI= X-Forefront-Antispam-Report: CIP:193.47.165.134;CTRY:IL;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(189002)(199003)(479174004)(24454002)(4001350100001)(50466002)(86362001)(5001860100001)(23746002)(87936001)(77096005)(2201001)(80316001)(5001830100001)(6806004)(68736005)(65956001)(83506001)(92566002)(77156002)(62966003)(59896002)(47776003)(46102003)(5007970100001)(5004730100002)(50986999)(4001540100001)(5001770100001)(189998001)(106466001)(97736004)(65806001)(2950100001)(87266999)(36756003)(64126003)(54356999)(76176999)(33656002)(64706001)(65816999)(3940600001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB3PR05MB345;H:mtlcas13.mtl.com;FPR:;SPF:Pass;PTR:ErrorRetry;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;DB3PR05MB345;2:+YG6t7dkpR+FKRCrsyNsRMWEvEO+MSZmXfW5o96XJcO3PCT6CxaiZgOwzpMNSI8SY6D6brZMeFA5pC0HoIXzqr92+5vFrclXWfGaKRHZwAvxcssWgBSboj2nYizqhNtmdmG9AMR2v1CYsfW67X1HIzXThI3RHDeTsVvl60VCrhE=;3:C+QyZCk8kHjNgSaPiY4qw/TYbjCmwdVh9ZIvlJFJZXNIb8eZBYSkY43VazBV9fml6INPQXgJh6K2oqLVaPK7LXJUUiTc7egScbUtZv8e+gNu7FhBGmUvalKKRTjHQXRyWvLCaodmM1pqYuTgWVx+a/v1/UbiBN2Ui0dGsGtsqcLvYs36tDhIPczoDqAtE2vRW4J8RngB4dNbXLOIxVXFNz09UO7cWOwjkf06Nu2d6DHvdhJGFldcNHhs0HjmClU8rDS06l5YFPspHfylZopnvQ==;25:vCe5JBkgoGmswNGZWNFHQ39IFvnWjUgD2OLeAWSZMhkS9OA6nRPxUg9zKuOiphowJPY0KF83oBKe9bGwV++P24OZbNA7pPVeQl8DYm5othvlL6GDdd8PPGsWIwXJWwTcufUfLfEOOc7j2SKrEXjP281PLqy4K/tw8aCu2kpRFLVcE91D7s4r/2Bd01vubM3JGDkxbx216yJumJOBl6z2+9FUVZ3Ic0/htdDJ1EQ6a7j3PoM/Fm8UEcteOW0YwayHHBB8pf4sQgsz2+t9hzanyQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:DB3PR05MB345; X-Microsoft-Exchange-Diagnostics: 1;DB3PR05MB345;20:lI8a17SAhXkgh5w4f8L1jkz1iTl9QEiyacRcQ95cC2ueMnx58m+N6OHfelH3OpVV2yOx4aC9XRl37XHo3caz6n0VVXT7Mu2bam9dNxGjakasQmWJcu1c4aDCrTuTWfJ9uN6yUYv2kzhmZvuLhok7PHdVEZ+3q9h2qTUBxjGI+iFjdrs629LtGCNlMdLCq4RHQcHAj8FA7KW3xj4B80RR7BS0/xvBCvIXFjH9dE8TDz2FjSwiQ3b4l07UotqUjuLJBhfw39/rUmDzwXP3Dz6WCMfFRb+qqM2KEpeHAQb6KOpFqpW8/DZGkVeYDfGAilo2ufuV6DJdUK88kknIxJ2baK5sGjZWlWIsq4tit4iE6kf7JGSYoibIjkD2qJ0cS6gfJTU24huEy8YwJOo/v4kZP//igaPzbiw0EUKD3efS4fAJ6XIUvJ6w2fEOrzlJA6+xre/AFRveCNi0S2dggoehjwIqt+rgTBfpkj93SLFRDnP+RemO6iQVW7Fzqu7w0RnY;4:nxuVk8hWyNQ7F700BTigTr6YERWY6q1CNzDv1U7S5yd7MFMcyjPIXqcM/MdVvL93MzblXPcIFqmL+REbO/FbesxzWyRAFiOC8X5uwiV1qrc56JEj0E8N+6S+Rrn2Xagp5akLIqtJAg093lMt6pXCsCHCIiH3egv7H+nwVhcF2GdH2kTKgdjVp5X3MzXHI0KvKp6tGzrjniI1bLaCtmmLu0D/ebZefg7bSPy6LqtMdDtl0qcec8ugOyHWjCrIn9Y25s8rrovThSlc6vXcvPeg2c0nHcbzFCTTJK01R0n8W3vXFnkYqdnkv7Ybga1eYjhHcAAE09a2fql82NiwrsQrBQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(8121501046)(3002001);SRVR:DB3PR05MB345;BCL:0;PCL:0;RULEID:;SRVR:DB3PR05MB345; X-Forefront-PRVS: 069373DFB6 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DB3PR05MB345;23:soojdYBy8A+SLuLXSFs+FsSFOxMVkypOEKwJlG?= =?Windows-1252?Q?FvLZZmi0KxqBPSa/ZDLGqN7V3j2sc61qtjvpN4ooR+RIaRvRqQpZvW2s?= =?Windows-1252?Q?1xHGdAAqI8RBi+B6AhUjaPY+DPdIZ3Hi753s+4tB3Xq9hLbIf2avdbxW?= =?Windows-1252?Q?qbQh8oCqjq/VqJjFARQbxWzdInHCkCqfgmuLZycy2LROcnu6K3zYNoq2?= =?Windows-1252?Q?AAGLiS8tgg4KFgvPTvzznXj9BmMiYfErtxVPAz2SMk0M6PbpViaefiN4?= =?Windows-1252?Q?v61TYgaH6U6zcVeUA33Sv+1YIt5ENdnAX69PPPcP98QPoxWUiwg1h+7w?= =?Windows-1252?Q?z//0J/aHFac3HmzRGE9QYNMtBgiW6k66fnDK0NhoUmPYalr3dQe8+Xpe?= =?Windows-1252?Q?HH4uR9eCRTSaYxcXV95QViPwzZBUCM7oRRc5NtJ2ogzOEfNXJQTRNLtD?= =?Windows-1252?Q?yTyMF4yp17zB49cgFXiT7ezbGt2CvPdffntwuvbhsheTKAflE5m6TgmX?= =?Windows-1252?Q?9xX2KWRBg4Dh2T1mZNJTA8S5eOfiw4jxGjvB7cntw57se5qphwKTlnUC?= =?Windows-1252?Q?0i5gkfEKoZZwb09U8/e/cqJMwAWbos4CowFRYYVq+74AN7LHi99DjG5c?= =?Windows-1252?Q?rj17QRLun0L9nzuZY9CL4FjNwfGz0rvcCfW2OEUoflzxocpytIeDXHkd?= =?Windows-1252?Q?sbdFG/a/JC7tVT+LRWvTsJJHF3b597xoVZDq2tlq0rveaosfxjrSIzR0?= =?Windows-1252?Q?tz64gHqSjEPCYHbSpCxpXmTYA1cqqyYHe2J5OhVf0HwgZzALUFVsP5rv?= =?Windows-1252?Q?48pzIHV66TxELcda3HDOIQIuAQtKoVod6Fe5p0Y8gH5iiLKA3jhAtgjm?= =?Windows-1252?Q?6DbCUNGa4+3fXX4BSErhlzk6268Nv2bTPOzqAF7ezc+5kHF4YZUK8JBx?= =?Windows-1252?Q?evMeCp6Yj53PSTER6NDVpguocRmDcqN4UjsZ/AOhz3GLuICILNQMHU2S?= =?Windows-1252?Q?Kyj9FYcgTINtnyW4FN2+5vGvrf5o1uySQCfwMYuNlyA3EpieF1ZwD+Gv?= =?Windows-1252?Q?yJ1IxdtJTGfUhWqIhmhLPr87BUx6l9f1jiNewG5YYNfRsrD14egJQ0Tu?= =?Windows-1252?Q?USWkxEvTnCEfDq6ZacrlfF5AeZRS/kRH5DeTDXsWkRWi+BfPdKWHNWSB?= =?Windows-1252?Q?21dCkrbDyKc0N00ldnC3pm+ivwxAwsf/j8w7KrZTxbrAHiNrFHSgAWO5?= =?Windows-1252?Q?aN61bjJ/s8eRWNDsoxppHpKDFvsK7WtZgwgJzeM1f9QfLQ/STwsq2rWF?= =?Windows-1252?Q?Ma8UwVXAsTs01or2yPPeuUcw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB3PR05MB345;5:+ebSCg9D4tnMWum4/ZNBbFl8Nu0fRMEoRgndYveVe7VrhgZFY2a3PEd2/bw/ehbwUSQrOsxNs6txcw3WVgW8j1ttk/lTS92VvmCHw6X9yVcT28bcH5RnLNvxP5pk110tnmMP9HB4FFsC2xC7uSP6yA==;24:qSR97jq2ka9mbZPAgrSKSLIcAlprK+iFTk5IEbLo8qo9llqJTVA7JLKoZ4JVMZ2Vmw+qDLf+Bu52E2ZJYMLgkoak8jbrwg1I2SdwqLzv6KE=;20:80394svMfu0xWceBmvcvpjdw1VZwpJMimPf6XtpCaoKpR+tLDSyWR+P5bimWVr88SPFLzUkY8hcOV2j8DPTvpA== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2015 05:31:54.9418 (UTC) X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a652971c-7d2e-4d9b-a6a4-d149256f461b;Ip=[193.47.165.134];Helo=[mtlcas13.mtl.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR05MB345 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/09/2015 23:38, Parav Pandit wrote: > diff --git a/include/linux/device_cgroup.h b/include/linux/device_cgroup.h > index 8b64221..cdbdd60 100644 > --- a/include/linux/device_cgroup.h > +++ b/include/linux/device_cgroup.h > @@ -1,6 +1,57 @@ > +#ifndef _DEVICE_CGROUP > +#define _DEVICE_CGROUP > + > #include > +#include > +#include You cannot add this include line before adding the device_rdma_cgroup.h (added in patch 5). You should reorder the patches so that after each patch the kernel builds correctly. I also noticed in patch 2 you add device_rdma_cgroup.o to the Makefile before it was added to the kernel. Regards, Haggai From mboxrd@z Thu Jan 1 00:00:00 1970 From: Haggai Eran Subject: Re: [PATCH 3/7] devcg: Added infrastructure for rdma device cgroup. Date: Tue, 8 Sep 2015 08:31:35 +0300 Message-ID: <55EE72B7.1060304@mellanox.com> References: <1441658303-18081-1-git-send-email-pandit.parav@gmail.com> <1441658303-18081-4-git-send-email-pandit.parav@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1441658303-18081-4-git-send-email-pandit.parav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Parav Pandit , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org, dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org Cc: corbet-T1hC0tSOHrs@public.gmane.org, james.l.morris-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, serge-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org, ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, raindel-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On 07/09/2015 23:38, Parav Pandit wrote: > diff --git a/include/linux/device_cgroup.h b/include/linux/device_cgroup.h > index 8b64221..cdbdd60 100644 > --- a/include/linux/device_cgroup.h > +++ b/include/linux/device_cgroup.h > @@ -1,6 +1,57 @@ > +#ifndef _DEVICE_CGROUP > +#define _DEVICE_CGROUP > + > #include > +#include > +#include You cannot add this include line before adding the device_rdma_cgroup.h (added in patch 5). You should reorder the patches so that after each patch the kernel builds correctly. I also noticed in patch 2 you add device_rdma_cgroup.o to the Makefile before it was added to the kernel. Regards, Haggai -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html