From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754054AbbIHIZe (ORCPT ); Tue, 8 Sep 2015 04:25:34 -0400 Received: from mail-am1on0083.outbound.protection.outlook.com ([157.56.112.83]:24683 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751658AbbIHIZ2 (ORCPT ); Tue, 8 Sep 2015 04:25:28 -0400 Authentication-Results: spf=pass (sender IP is 193.47.165.134) smtp.mailfrom=mellanox.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=mellanox.com; Subject: Re: [PATCH 4/7] devcg: Added rdma resource tracker object per task To: Parav Pandit References: <1441658303-18081-1-git-send-email-pandit.parav@gmail.com> <1441658303-18081-5-git-send-email-pandit.parav@gmail.com> <55EE76C7.1000804@mellanox.com> CC: , , , , , , Johannes Weiner , Doug Ledford , Jonathan Corbet , , , Or Gerlitz , Matan Barak , , , From: Haggai Eran Message-ID: <55EE9B58.70908@mellanox.com> Date: Tue, 8 Sep 2015 11:24:56 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.0.52.254] X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;DB3FFO11OLC003;1:CL41OAHbittwudG03fVWHWCudSB3YQIwNSM2GcF8sdeTNR1Ead+rzFuZAlzluuzIVltdxG0g4NUDRZILUjWe9IgnaJTnQjUnBWL1L+8EjPDraR+PlntzZIy5tq2nse38O0bHZZHvEzgkUMq7l9uOjltGOnyY0GqxLkpYoA5CE7e1o3HebPCaxkTnWCgBR+kJfky37mZ7u00+bzS9j+iPbCOr41jZ8yyYGyfsrjUHRL2uB9MVvm8zwJyyt+wMlxR6gVtlnQgL4qcgKDiHy59pVmm3HBO0dGaohT3PJliXUPDguKkblGuhSHOSxMYoLgLu8qOeN0VISTQRtqaoPHFvAfEakaN4OQWG6ObWIchA4WKq4BuUi0A64U+4bvhnF8v0aYtks3xVeGf4YIjQO5zqnc8rPwYz/xNLOYxWaA906Fk= X-Forefront-Antispam-Report: CIP:193.47.165.134;CTRY:IL;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(479174004)(24454002)(189002)(377454003)(199003)(36756003)(87936001)(4001350100001)(83506001)(189998001)(93886004)(76176999)(5007970100001)(77156002)(50466002)(50986999)(23676002)(62966003)(19580395003)(5004730100002)(97736004)(6806004)(92566002)(33656002)(68736005)(65816999)(110136002)(64706001)(5001860100001)(106466001)(46102003)(77096005)(54356999)(5001830100001)(86362001)(19580405001)(64126003)(4001540100001)(47776003)(2950100001)(65956001)(65806001)(3940600001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB5PR05MB1463;H:mtlcas13.mtl.com;FPR:;SPF:Pass;PTR:ErrorRetry;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;DB5PR05MB1463;2:7t9D/lRnmNiy8K51DRU63ZGQHkB5jGnOuc97YpP2+jfnNeQzp8OJg7zBEehzX+La6E/MXL2vnDwiZ7l50+ZHiWnuD627G5ICXnxah3dnolnOJaQ2UVkw9N3x4qIrsz+cFfWvVkM8JUQuNKnVepn81lVaFszIi8cwCdyca3PYqVE=;3:Gu/0/Co198vJHvvLcUP9cau/b0nNabvlmFiiyV6FoMKDSoQxJA20G+nDT8c/TitJ9wftu/6avb8TTALt0SRTbbFlJ+8i34asPG9hz9tJfPlxWU6+XbbG8GanlLDpQnV4dOoSCcfL6ouciwPqDDbMd23dIBsTcZ7Irz64Uy0fv8GjmwPBCzLomqdr25Hnq49h2KDsR2RxHbdVfirWBO82Rf/M3cAvo2g8Mh+U1OGh6+3hcqxQYh0nkkf0W+1iwTdOG+d0osHBd9GMX5sJhS/ZnBzj6o5EN47E2sVe9S9CCM0=;25:m4QbgoAp4tstdkn9QmFxZekritgUn3/+EXHzR8Ivf/uHkRzxJReALMeUjjKteU9+k+a5HEgYFsZWWgU4huzZZnbR8xUGEq2rl5eFew+6/myiScId/QDaZyGOWqKCRiVkhLBpj5OoVykIwhpt1DcCh2nRAXFkSgPDrs3LddlAgzsa2hXM2iTlmx3/av6xDbDXBrWaKHa3Et+AP98f1t791htP6szH7VOdQrIrO+8e1Kmg1+PKe80QmnAPz7x996B0 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(42140001)(8251501001);SRVR:DB5PR05MB1463; X-Microsoft-Exchange-Diagnostics: 1;DB5PR05MB1463;20:DBLinbcLNoWM8ljRxDBXEL4x89u1iV61N9emR9+yFewb/Q8IESXNibP8TW8tLmrVrGF629/JgkeHaYWhJoW2mwOXs5xHMSDR43ff+iOpEVnTMnoM25IVqwacByPKr2JnWa1VerXL9iBvTx7leGLOAcDDPHbaYGuadcHp999PcLgo9Jiup11xEiYkScIdut5L2Grg3wFj4OCUV5wvR9MB9PCEnSa2S7dlTciSHseIjhQm0MUROR/1zq2NWa2q+KIVYKuTg+LqeJlvpca+FNlb+cF5iqjkTa/ZYp5XBtnrJpMKfOIAGUNRf/7ei7Q9ic/7nLLTr/HK3jOw0LRlEOb08ScFL+W8rqWrqBfHHYt8LM1Tzal1wYW59SZvvyMmdK56rfh47aYRinSc2w7fEqDetdLuZOIcQL/q3N2I83UDDEh6OVxNgCZ330EMRB0mcT+v5RMO6kDyGWJ93hG0KuBBOuzW1BkWyJPKNfwZYnbD3eLkrlT0Rdyh/ED8XjtMZG0t;4:lhLh3kbCUhQhmswXSfrAcEX4m1ZHoRrp2sPaEjU2YAN1z/4aNW/ge2JWJy5rkm1SrAtaVoRZOAQkR3t9ES8VZd09HjwyA0K76PStLGHHALW6RQCQTdi4wBEZthuyjzbTX+sT0om/ULYn0/Q1TAWVb9zEd2EaAvILWlMgKenHUKbDxcHSVfHxfJ1hiUXHB2jjjuFvlQHnGe4jAv+TpE55MhiFRoM1RpDcv18SfJwr4uQHY+lsuSF7RIa+xp1cgwqSRk2bAivH3UlpC4S6EuZUbE6uSGyjIPhs01rSK9a4Y7mk3fEZPRFakZV3sjdorHcZ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(8121501046)(3002001);SRVR:DB5PR05MB1463;BCL:0;PCL:0;RULEID:;SRVR:DB5PR05MB1463; X-Forefront-PRVS: 069373DFB6 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjVQUjA1TUIxNDYzOzIzOjQvWVJubmhhWE1Kd0FWNVhlRXVTdVdXNHNv?= =?utf-8?B?eE5Yb0NsWlN0RW5uWm02Q3dldUtVWW1ncTZGV2MwL1NOL3VHSHZLSUJQL1JW?= =?utf-8?B?dGZVTlNBckZIVjc0OXRuTG54T040ZzYwSGhwMlpwci92ZG9RWW9XcFNzMHMx?= =?utf-8?B?SnZuZU9ueHk1cVUvcWNId0NQL2o4MGx1d3VqRnB1N2VnZUQrQmtDRDF1M2tZ?= =?utf-8?B?VGVtSkEwMjNDVXFIMmZxTkRRYk9icHY1ZmJMOFg2QzBtZGpWRkVydEVYV0Iv?= =?utf-8?B?ZXI2NEY3WkUvemZtRTdiZXBZejlxaGwrYlpGZkZWSUpRVFBDZ0d1WWJBNnhX?= =?utf-8?B?UGxQRnJrVFJBUXJWaC9pTFVURmNpZ1ptcEFvckl2Z3VpSGQ2MHM0bUNNd1Zp?= =?utf-8?B?ek9tRkxVUnl6ZTZCY253c0UvaVZ2akhaaFpOWUErYjJZU3hIZFNhNDYvcTU1?= =?utf-8?B?U21KWGN2VzZRRjBybUNabGtCNmlsanpneE54Y01WZHNrTkd6eGtLNGIzanBh?= =?utf-8?B?RkplREpHSkhLVUNUV0hXdGNhSUpSZ1NqdlFnTUxvTWsxZjVZNGh2TXg1Mi9l?= =?utf-8?B?dGNRay9LckdTZU90akR1bTZudDhUclZYQ3ZXdzk4ZEZWMVd2b3pac3dINFpF?= =?utf-8?B?K2tGVTV4WXBhRWFCejI2K0QwQVhkUisxamlvLzM3WTQzdjc4dE4wSmhmMmpa?= =?utf-8?B?N0psblNNdnVnYTIvSXZ1VnNCbTBqU3dJZ0FQc05xL1B6UEMrTStxRnY0eUJw?= =?utf-8?B?TnRrVjQxVWNPRGJBaHp2UjA2OGNONk1WdU1Felh4c21wTWRIRWNWWW5Mc3dP?= =?utf-8?B?bVNudzQ3T3dXZEsrcmdZSmVVS3pNWGM3MllaSVowaGw0TWczNG9QMGpwLy8w?= =?utf-8?B?RDBveFQvaGkvVU42aUorUWp4NGlyQW15em01TVhIS09EbUNGcGFVWkxYYzhI?= =?utf-8?B?WEw3UTlpbjRlR3dRZHpERC9FOHdObEdPNWFEWG5PQnp2alErbzdpUkZvUGhx?= =?utf-8?B?VlRqSDJXd3FEbXpHbE12cEtlZUNiOFNldHpzSWxNdVhLc09US2poWHBVNXp1?= =?utf-8?B?alBjWW56Qkc2b2w5SldiWGxCUjdnNUxobnUra2lkK0lmenB2aXNTM1NOS1hU?= =?utf-8?B?OXViVXowVFhqczVxV2lHR255SzdNL1FUMm9XUEsxVW56cng5cWZhNXFjK2hy?= =?utf-8?B?UkRBVlRJNWR3TkhVVUZiZ1B3RExYOTRFYWlFQUxtRWhJL3RMNW11UGZXRzBx?= =?utf-8?B?S0l3WWtnMEoxNCszS0UyRWV1eFNWcTRkTDZ1cVViMis5OVR0azcyaXdTVWE0?= =?utf-8?B?cVl1TEMzS1J4VitzZFp0dUVEMGlUWk1SUDdWeUkzZERyY3o1QmRrNGY4aEtV?= =?utf-8?B?bVUwemVvRUgxQ1FJQTM5NE1sSExEak0xRnpjbTNmOXlXL3dnYkZFQTVxbi9X?= =?utf-8?B?WTZ1cnhteGZROElKN3hRUFBDWlM0bThFcnFWdHlqNUlpS0ZrNWMvVWw5VjJk?= =?utf-8?B?WFVTTnJqZmxiSmtWSnpKbUZMalJNRHlLc2NmVWFISUJ3UmoxWmNaK2ZXUEwy?= =?utf-8?B?WlQ0bHp3TVUwVE5ET2xsUlA5RU0xNHUwYW9SQk1YRk8rVWlTQ0hNZklrRDhp?= =?utf-8?B?Sk5Sak9pUFFvNmFrSDN3QjIzNkZqRTJxQzE3Vk1lMW9rdkY0RG0rc1ZnPT0=?= X-Microsoft-Exchange-Diagnostics: 1;DB5PR05MB1463;5:sW/6JCZf6NRazH9/F/ZUk/HY45F42yF99Vgp33W5ZqBj3KYX8WEQcW64MPy7zT5cDcFoF4zjhOxzTdidKVr9IBnGwLC9nLz1tM7WtxvApo1dCDv7iG9UyNFh4fdP+SpV4AUpMxw1UZ6zQB0KXaRZdA==;24:MZoy6CHKKaVKlQlOv3DKgd4m67s93KdW8s0KHbi0ZqHDqL5Rjs8xmhRDbRUnSBrB+2CAqNhAkjFjOdU2xAOgQxF3F06mYN5grM4OeeyWkvc=;20:9Ty7Uh0wXnzuhMw6z6KN4Yjdh+nzbP1t12BKtjUzBt3yWC0txXSahXvvhJcq7nDKyVZFGLsWoKhG4+M2G/iABQ== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2015 08:25:16.7010 (UTC) X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a652971c-7d2e-4d9b-a6a4-d149256f461b;Ip=[193.47.165.134];Helo=[mtlcas13.mtl.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR05MB1463 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/09/2015 10:04, Parav Pandit wrote: > On Tue, Sep 8, 2015 at 11:18 AM, Haggai Eran wrote: >> On 07/09/2015 23:38, Parav Pandit wrote: >>> @@ -2676,7 +2686,7 @@ static inline int thread_group_empty(struct task_struct *p) >>> * Protects ->fs, ->files, ->mm, ->group_info, ->comm, keyring >>> * subscriptions and synchronises with wait4(). Also used in procfs. Also >>> * pins the final release of task.io_context. Also protects ->cpuset and >>> - * ->cgroup.subsys[]. And ->vfork_done. >>> + * ->cgroup.subsys[]. Also projtects ->vfork_done and ->rdma_res_counter. >> s/projtects/protects/ >>> * >>> * Nests both inside and outside of read_lock(&tasklist_lock). >>> * It must not be nested with write_lock_irq(&tasklist_lock), >> > > Hi Haggai Eran, > Did you miss to put comments or I missed something? Yes, I wrote "s/projtects/protects/" to tell you that you have a typo in your comment. You should change the word "projtects" to "protects". Haggai From mboxrd@z Thu Jan 1 00:00:00 1970 From: Haggai Eran Subject: Re: [PATCH 4/7] devcg: Added rdma resource tracker object per task Date: Tue, 8 Sep 2015 11:24:56 +0300 Message-ID: <55EE9B58.70908@mellanox.com> References: <1441658303-18081-1-git-send-email-pandit.parav@gmail.com> <1441658303-18081-5-git-send-email-pandit.parav@gmail.com> <55EE76C7.1000804@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Parav Pandit Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, Johannes Weiner , Doug Ledford , Jonathan Corbet , james.l.morris-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, serge-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org, Or Gerlitz , Matan Barak , raindel-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On 08/09/2015 10:04, Parav Pandit wrote: > On Tue, Sep 8, 2015 at 11:18 AM, Haggai Eran wrote: >> On 07/09/2015 23:38, Parav Pandit wrote: >>> @@ -2676,7 +2686,7 @@ static inline int thread_group_empty(struct task_struct *p) >>> * Protects ->fs, ->files, ->mm, ->group_info, ->comm, keyring >>> * subscriptions and synchronises with wait4(). Also used in procfs. Also >>> * pins the final release of task.io_context. Also protects ->cpuset and >>> - * ->cgroup.subsys[]. And ->vfork_done. >>> + * ->cgroup.subsys[]. Also projtects ->vfork_done and ->rdma_res_counter. >> s/projtects/protects/ >>> * >>> * Nests both inside and outside of read_lock(&tasklist_lock). >>> * It must not be nested with write_lock_irq(&tasklist_lock), >> > > Hi Haggai Eran, > Did you miss to put comments or I missed something? Yes, I wrote "s/projtects/protects/" to tell you that you have a typo in your comment. You should change the word "projtects" to "protects". Haggai -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html