From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754872AbbIHNki (ORCPT ); Tue, 8 Sep 2015 09:40:38 -0400 Received: from mail-am1on0056.outbound.protection.outlook.com ([157.56.112.56]:7289 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754502AbbIHNkc (ORCPT ); Tue, 8 Sep 2015 09:40:32 -0400 Authentication-Results: spf=pass (sender IP is 193.47.165.134) smtp.mailfrom=mellanox.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=mellanox.com; Subject: Re: [PATCH 6/7] devcg: Added support to use RDMA device cgroup. To: Parav Pandit References: <1441658303-18081-1-git-send-email-pandit.parav@gmail.com> <1441658303-18081-7-git-send-email-pandit.parav@gmail.com> <55EE9EE2.3060804@mellanox.com> CC: , , , , , , Johannes Weiner , Doug Ledford , Jonathan Corbet , , , Or Gerlitz , Matan Barak , , , From: Haggai Eran Message-ID: <55EEE558.4060300@mellanox.com> Date: Tue, 8 Sep 2015 16:40:40 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.0.52.254] X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;AM1FFO11FD041;1:hjhul+aKTJR1ENRUWIj8D8Y1Awy9CujLhB8dHhbqohmiHDZTR5g81n6aWLDEDSlbTvjfAeY4JoKKgBGNTjB8BXmMRWVaRsKmF4xrw/Wz1fk5ZVwy4kuqd6Y2tgAbuVlT4IbBi6LuN04W4zeFP71ly6UlaIU3LVjZ8Q4DF+HxmZK5WHPOATIl6WR0hkLO2hLCUPu3ExQRC6HCLERGLNoyOrcKZgb1TSkbl/iILTf36eJbyOiRg02nOn+mnoEvVzAeos806kUJ98Eudm/RvmDCBM/7kBFseT5ULkkyPP6AjcBUd+Gl/AVi+fGsUHdOciciel1n0AImpj++mOcb51bMR68N3Um2ZYmN7MJPsInq21fwYHsWmFMuZYKbQy3vTAu5DimVZ7hhxzL3VpiAxREY0w== X-Forefront-Antispam-Report: CIP:193.47.165.134;CTRY:IL;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(479174004)(377454003)(199003)(24454002)(189002)(77096005)(5007970100001)(92566002)(76176999)(50986999)(65956001)(5001830100001)(189998001)(33656002)(19580395003)(11100500001)(54356999)(77156002)(62966003)(6806004)(4001540100001)(65806001)(5001860100001)(97736004)(4001350100001)(23676002)(110136002)(87266999)(83506001)(19580405001)(50466002)(46102003)(2950100001)(106466001)(64706001)(59896002)(86362001)(80316001)(5004730100002)(93886004)(65816999)(47776003)(64126003)(68736005)(36756003)(87936001)(3940600001);DIR:OUT;SFP:1101;SCL:1;SRVR:AMSPR05MB342;H:mtlcas13.mtl.com;FPR:;SPF:Pass;PTR:ErrorRetry;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;AMSPR05MB342;2:26Y7EYUiJV7RfVMgxbYiNEzXnAaBdZEhTHD7XVRNJ7kO/V1CWoFMqGwPQyfmahyBA7Br8fN34znP+B2G0vtBaoQRH6LMyHTl3ywjmerguFHJ9cVqz0ShHdguCEWEqb7263Rj+206lphZ4W7LdBMbRe4fmZLQO/E7HOrsVnUfi78=;3:l575MbrbDmI+1BRVvvEIJwievMdUuQ9g+/3Vy2tqJc2A3qVM2DBRQMMevRQ0nl6SMJaC1Zfs5Vjf7f5jUSsjm0Bsr0zblX6KD7fVIxtr0DmgxvpFHzh+3447w33Zfh9Tlze8JsrmQovI5nnQXM+AerLOluQi/4gJOVTHJ0364WfuiOZsYd41CbutXp0/C4xiOs9LYKKYyst7cCbSwM5OloW2XtJXA4Ev/FHzfNofR/Effl3ZOy1S0hsK8J+U3LJL/mnNpvujK3uIRofGtqeGsQ==;25:qJaFq3F0v0HQm5v3bfBIGdpOTr72SbLFvYYBT71X3oPqzKYytd/xQFJG8XEIzFpV6duNjgxsUoaEKZ8SpQfcIwtbw1H7GBL5pMZRyOMZMeWWSDsupfzpRblWJygoSDfx44bOLMT5KU5D3BmN0zf2NowzNhoB/vo//UZFwvZoNnKllmiBAWnElIIXTookszjYKWgKOUDMjauw2z9ONefg2cE1f6ZQ2SGneSl0wdlEFmdE/polDnkveAO1KHxRvlN7 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:AMSPR05MB342; X-Microsoft-Exchange-Diagnostics: 1;AMSPR05MB342;20:u5XdtjXklZcd7guO7yVCqX5GCRNhbbxD4dhYbJi35xXTlfPtvUALB/frZMh86PetKsgJY9LWaXh+DYxZoHCQCTRlW96zZ1P9RDEdJpSaGFrgXXjdp137sQ6BZwwRPOnNbkjJUPXFOXVXLUoC3DCATtPeCF4vOiZRaxtXvm6mk/LflZAeACoSLCjB4CK9Vbj9koZqAwuoneqKs3v4P9lpm4ovPug4ZKQFGHo845QLEXmR4hezhq/dq7aYHIPB7wmm+vIN5sPuErLInRhNzPc3jxXtoJSwiTTJ94wBzFe94nVWGz5Uat+Ac9b83gqX/jF7cjE/dHf7FUS2eeJGaGK/QHSzfPl6mzf3OYxQQtan6mwq7znnjqKEtshBL0m9Tk9tojd+bNk2v9+ptj8bSznwlqyVr7zvsPWCnakEDtOObveYGpiozblrrQdpPEVeQZodeNGjxakA0M5RYekTPai25fQy1dR3cYRjO5jB8UfuGv5vq5j5k6V+KJz28ZrF9/9z;4:KlX9HJaJP/pme37GIigIBhuh3yB2UKmXa4bZyagJbtg8xdCVd5KUiEvrD8XscDB4HLB5u7ad+NiD3OU4mfYzPM8a8BK7Wyw2pXocEOK75j6jRA/FxqjOHGN2Q2eg7XQEjnc5MyUth8mpYYsyeYjnxWd58JGgaWX88pK2BT8MUJ4+xRzfQ1PrHbSX28EXCcLmv+wdHV5tlP1Alx50V20igtKTA45DUSlsobKErzTXDdGXoyL94A6n9NP/8eNK1G75AAPuaZfT6go9zbm2EaN0d3nPDXEMZZJUNSj5OV1Hh/2y/kiY+oTJ/6feVww8SM5t X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(8121501046)(5005006)(3002001);SRVR:AMSPR05MB342;BCL:0;PCL:0;RULEID:;SRVR:AMSPR05MB342; X-Forefront-PRVS: 069373DFB6 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTVNQUjA1TUIzNDI7MjM6aThnMkFIenFhVXRJZGhkaHl0bDFLQ2l1V2Z6?= =?utf-8?B?QVZxQnZmWHZhTDNnUUFkTVFQSFI5eVFFWFlzNkdVaGg3MWhZN0t5dXViS3ZT?= =?utf-8?B?VXV1UnIzbEdTak5sZGlwUkt4OGZMbVpUb3J0cFVidGpseGYyT205NUFFVHJz?= =?utf-8?B?ZE9WUHNTOW9yeDR4bHlZWmxSdyt3UVdjY1hLUEtDWXlhZE5QT0xXVHU0V2tQ?= =?utf-8?B?VWl1VGVUV2hON3E1MHZ6V2E1aWJ2cE1RZTl1L2E2U3pWQWZySmdZcC9LWVho?= =?utf-8?B?eENJczJUQ3FyenowYzRUcFNLWnpHUGF4QmVSQVZiZFVmUlRadGNWU2EyWE11?= =?utf-8?B?ekFGelZxT21PRTQyaUNEaEN2QXRyV1lIR2pRTFdaQk1FQ3hXOG50MUh2THJK?= =?utf-8?B?dHNEZjM0ZURIM0ZMUWoySVNOaEFGa1B6MlhobDN0RmxObUJUemdEZURnZkJj?= =?utf-8?B?UGMzbEZUeVluTCtWUFYrSUhRR0RJVngxcUIvd1RxQUNESC9rajRYVHpsK2FP?= =?utf-8?B?T2o1U21GNGIwTUhTbTUyRTJwbGVhMGdVV1FUN3dwY0owdVF5WFBXSWdnU3hM?= =?utf-8?B?b0Q1RW5pdzJ3R1FkZTZBYmZEMDFpMDRhZERSdHR3SmlpLzVDUDUyazRsd2xQ?= =?utf-8?B?d0lydW1HVkV5bTZjRmlNcjZwdGdweXdPZTNyYStOZUR3RDM1QnJ1cXVpdTZ0?= =?utf-8?B?SHBHcDV3SnZ3Z1JqM3Q4WmpvZUliVno1dXV6TFk0WWdJcXlqK0FqYlVSZzZi?= =?utf-8?B?WVN4ZTJyc0RHRVN3RDQ1Sk5ScXUvc0lWeUNEY3grRmdwakV5V1IvZzV5SFhY?= =?utf-8?B?aU1Iayt2ZzVqdmZvUFBnOStkd3kwOEJjK2lpbVdFTnd6dXQreWRQRkNrUXEx?= =?utf-8?B?K3dFN2hzMUNnQXh5OG9hb0JvSTRiSlczOEMyUlJQVXIvcDZXdUQ0a1BLS3Zw?= =?utf-8?B?WjJLYmtXL0J4KzljT0ovczMzNVFxSHdkV0F4aU9DdjhRakdZSTRhSkJiejll?= =?utf-8?B?eUdsK0UvZHptQ21OOVljTnVMbytLbUk5VDd4cUIyMEVDVE1oY3VldVZwZ2dN?= =?utf-8?B?NWtmV3ZFUkI2MHYvZEkyVVlJYjE0U010eVBFUHAyM2NoaTlFUFlxRUJCMGtP?= =?utf-8?B?d2dJako1Y3N4SDA0Z2QvVXRkTVZBZFNVOUFJT0Zld3RKZkFVYzMxSXYxeGNW?= =?utf-8?B?R1hLaEhlTVltNDJxRWMyS0RyNHJITkZGSE9LcDZqUkh3V3JKaStocE0zbXdO?= =?utf-8?B?anZrMlJZb0lMaUhPNWQ4OW13L3B6cUFkY01hTG92ZEhQQW5CazY4dVZXbS8w?= =?utf-8?B?eTdOelNWOVA2UUFZbGluMHhrdG0wS2dMbm1ZNGQyQnNqQ3JSMG50Nnc4d2Q3?= =?utf-8?B?K3ZLenMweWlzTUN5UkY5aW1tODNCRDZLMnRObTY1aG4ydk51dGhnTm5taUZk?= =?utf-8?B?cUJHbFhYaDdzUWNubmUyRkVUZi9lcGVrWkVYNkMvWFZ0b1kxK2FlV2F3eURJ?= =?utf-8?B?ek11QzJyamNQMkRnVjEwdXBWSTUzeUZRNDI4U2pObjhxbldtaVM4MUNJZWh5?= =?utf-8?B?eitRVzcyVXBHOG84eW9CRC9tdEJUNFUxY2themlxT3hDc09FU0NmUERvT01o?= =?utf-8?B?NzZLcXliQ2RDamx4SUlNVjNQNk5aMjIvOUNqTXZpUVlUQ25SelpYS0psTWtR?= =?utf-8?B?K3ZZWnV5QmQwWG93UXZ5OFliZ095T2RwWG5IQjFEa0hlZXN0RUlWOE95VXFS?= =?utf-8?Q?A190tztTCLTj/Ykl/UXWbL8vL5OB2C0UTdtQ=3D?= X-Microsoft-Exchange-Diagnostics: 1;AMSPR05MB342;5:AhVGX1MwcCOykEWDgww1p3V/qyuF4V62OOjUIBhuF8wHe0D02DEQiFa6+bbkGOE7WuMjzhCNqrKvDu1GQH5qpX3tuZLjmajMBAVdvNcnYIdjK+l/D21sUsqIlbm43iSpRQdlgQTCeqlwIYm166Y7Qw==;24:EBYYCbMhzMkutjaVFmmIeexAXXR2fIcdUrIxPR1IDFItJyXHXa2LAcG1cYgpuThKTBX76RQ3CiIPa4yalBoPcRHNn+rPs+f5C2oIiD9kthY=;20:g8neEC78p31lYADREUpg1MI52/wK8JiiQL+/Jf/j4KVnI7ivPA3+s7yNb50qysDSuSqG4iLiWzxKg3EAvBnAvw== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2015 13:40:26.2240 (UTC) X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a652971c-7d2e-4d9b-a6a4-d149256f461b;Ip=[193.47.165.134];Helo=[mtlcas13.mtl.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR05MB342 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/09/2015 13:22, Parav Pandit wrote: > On Tue, Sep 8, 2015 at 2:10 PM, Haggai Eran wrote: >> On 07/09/2015 23:38, Parav Pandit wrote: >>> +static void init_ucontext_lists(struct ib_ucontext *ucontext) >>> +{ >>> + INIT_LIST_HEAD(&ucontext->pd_list); >>> + INIT_LIST_HEAD(&ucontext->mr_list); >>> + INIT_LIST_HEAD(&ucontext->mw_list); >>> + INIT_LIST_HEAD(&ucontext->cq_list); >>> + INIT_LIST_HEAD(&ucontext->qp_list); >>> + INIT_LIST_HEAD(&ucontext->srq_list); >>> + INIT_LIST_HEAD(&ucontext->ah_list); >>> + INIT_LIST_HEAD(&ucontext->xrcd_list); >>> + INIT_LIST_HEAD(&ucontext->rule_list); >>> +} >> >> I don't see how this change is related to the patch. > > Its not but code which I added makes this function to grow longer, so > to keep it to same readability level, I did the cleanup. > May be I can send separate patch for cleanup? Sounds good to me. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Haggai Eran Subject: Re: [PATCH 6/7] devcg: Added support to use RDMA device cgroup. Date: Tue, 8 Sep 2015 16:40:40 +0300 Message-ID: <55EEE558.4060300@mellanox.com> References: <1441658303-18081-1-git-send-email-pandit.parav@gmail.com> <1441658303-18081-7-git-send-email-pandit.parav@gmail.com> <55EE9EE2.3060804@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-doc-owner@vger.kernel.org To: Parav Pandit Cc: cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, tj@kernel.org, lizefan@huawei.com, Johannes Weiner , Doug Ledford , Jonathan Corbet , james.l.morris@oracle.com, serge@hallyn.com, Or Gerlitz , Matan Barak , raindel@mellanox.com, akpm@linux-foundation.org, linux-security-module@vger.kernel.org List-Id: linux-rdma@vger.kernel.org On 08/09/2015 13:22, Parav Pandit wrote: > On Tue, Sep 8, 2015 at 2:10 PM, Haggai Eran wrote: >> On 07/09/2015 23:38, Parav Pandit wrote: >>> +static void init_ucontext_lists(struct ib_ucontext *ucontext) >>> +{ >>> + INIT_LIST_HEAD(&ucontext->pd_list); >>> + INIT_LIST_HEAD(&ucontext->mr_list); >>> + INIT_LIST_HEAD(&ucontext->mw_list); >>> + INIT_LIST_HEAD(&ucontext->cq_list); >>> + INIT_LIST_HEAD(&ucontext->qp_list); >>> + INIT_LIST_HEAD(&ucontext->srq_list); >>> + INIT_LIST_HEAD(&ucontext->ah_list); >>> + INIT_LIST_HEAD(&ucontext->xrcd_list); >>> + INIT_LIST_HEAD(&ucontext->rule_list); >>> +} >> >> I don't see how this change is related to the patch. > > Its not but code which I added makes this function to grow longer, so > to keep it to same readability level, I did the cleanup. > May be I can send separate patch for cleanup? Sounds good to me.