From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36312)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1ZaSei-0004aa-3Q
	for qemu-devel@nongnu.org; Fri, 11 Sep 2015 14:02:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1ZaSeh-0006OH-2i
	for qemu-devel@nongnu.org; Fri, 11 Sep 2015 14:02:36 -0400
References: <cover.1441890725.git.berto@igalia.com>
	<791796d6176b5439491a46496de216ec453ecf93.1441890725.git.berto@igalia.com>
From: Eric Blake <eblake@redhat.com>
Message-ID: <55F31733.4020105@redhat.com>
Date: Fri, 11 Sep 2015 12:02:27 -0600
MIME-Version: 1.0
In-Reply-To: <791796d6176b5439491a46496de216ec453ecf93.1441890725.git.berto@igalia.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="xLfQ2vejQQsxo8VuGqUl4U6h12ORuip09"
Subject: Re: [Qemu-devel] [PATCH v3 4/4] block: add tests for the
 'blockdev-snapshot' command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--xLfQ2vejQQsxo8VuGqUl4U6h12ORuip09
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 09/10/2015 07:39 AM, Alberto Garcia wrote:
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
>  tests/qemu-iotests/085     | 97 ++++++++++++++++++++++++++++++++++++++=
+++++---
>  tests/qemu-iotests/085.out | 34 +++++++++++++++-
>  2 files changed, 123 insertions(+), 8 deletions(-)
>=20

> =20
> +# ${1}: unique identifier for the snapshot filename
> +# ${2}: true: ignore backing images (default); false: don't ignore the=
m
> +function add_snapshot_image()
> +{
> +    base_image=3D"${TEST_DIR}/$((${1}-1))-${snapshot_virt0}"
> +    snapshot_file=3D"${TEST_DIR}/${1}-${snapshot_virt0}"
> +    _make_test_img -b "${base_image}" "$size"
> +    mv "${TEST_IMG}" "${snapshot_file}"
> +    cmd=3D"{ 'execute': 'blockdev-add', 'arguments':
> +           { 'options':
> +             { 'driver': 'qcow2', 'node-name': 'snap_"${1}"',
> +               'ignore-backing': "${2:-true}", 'file':

Needs to be reworked to use 'backing':'' instead of 'ignore-backing'.

But overall looks like a sane set of tests to cover both positive and
negative expected behavior.

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--xLfQ2vejQQsxo8VuGqUl4U6h12ORuip09
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJV8xczAAoJEKeha0olJ0NqkuAH/RNt0ZVRKHxr4+1Hz3Z+VkZp
Jb9c7wJic4oWOqKJgLpFtH+P5ItwLR8fpH8YtP2SMfqKJTcs/4NX+/2cHdbyeG62
nKsOuUs/cW1F8cW68pCHnmMcyQXLjBsPAT9RSphx3kiBl3a50qt2JgzBxPJ8WADv
LZUXTrUAKQdArz6MWe4970esguy5TcWal/52VvJyDk5LkgoeARzUIgv7RsGjQaXU
dqGVZgSv+JCEjWf1jlgG8I/ykC+k9YAmLbK8yOK5t2j/QQch/dz7Th2hJvippzxO
ceLt1MeqdaoaFOWm1XKPPhpCSASTfTr5QBzeC6Hoq74HTazuOCETTj1W1AZPRmk=
=8GJn
-----END PGP SIGNATURE-----

--xLfQ2vejQQsxo8VuGqUl4U6h12ORuip09--