From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38144) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZaSnf-0007zt-TS for qemu-devel@nongnu.org; Fri, 11 Sep 2015 14:11:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZaSnf-00030M-11 for qemu-devel@nongnu.org; Fri, 11 Sep 2015 14:11:51 -0400 References: <40f3f51fb44da70929f7055e95582351d1aa3f34.1441890725.git.berto@igalia.com> From: Max Reitz Message-ID: <55F3195D.9070604@redhat.com> Date: Fri, 11 Sep 2015 20:11:41 +0200 MIME-Version: 1.0 In-Reply-To: <40f3f51fb44da70929f7055e95582351d1aa3f34.1441890725.git.berto@igalia.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QtvnEaotWG30EGOsWs9UCmLRNDR18FBWf" Subject: Re: [Qemu-devel] [PATCH v3 3/4] block: add a 'blockdev-snapshot' QMP command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi , qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QtvnEaotWG30EGOsWs9UCmLRNDR18FBWf Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 10.09.2015 15:39, Alberto Garcia wrote: > One of the limitations of the 'blockdev-snapshot-sync' command is that > it does not allow passing BlockdevOptions to the newly created > snapshots, so they are always opened using the default values. >=20 > Extending the command to allow passing options is not a practical > solution because there is overlap between those options and some of > the existing parameters of the command. >=20 > This patch introduces a new 'blockdev-snapshot' command with a simpler > interface: it just takes two references to existing block devices that > will be used as the source and target for the snapshot. >=20 > Since the main difference between the two commands is that one of them > creates and opens the target image, while the other uses an already > opened one, the bulk of the implementation is shared. >=20 > Signed-off-by: Alberto Garcia > --- > blockdev.c | 163 ++++++++++++++++++++++++++++++++-----------= -------- > qapi-schema.json | 2 + > qapi/block-core.json | 26 ++++++++ > qmp-commands.hx | 29 +++++++++ > 4 files changed, 160 insertions(+), 60 deletions(-) Reviewed-by: Max Reitz --QtvnEaotWG30EGOsWs9UCmLRNDR18FBWf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJV8xleAAoJEDuxQgLoOKytmFEH/RnIg0d1fczPmVuqN+3ywv5f X/SoQp9mO7t4KAhx4Equt9fg1b/R421/2hh0WigATyWMooi8DEeSBQRfPo/0dMLy q1MVU04DW7xRU3HrFAEGVTcxT0jJN2ENBVNfHX5bAfEYI7gyQU7Y4S+BoOemvUKC WoPl/8pMT3TXEA99wJ5uVCFfVpONaY53JFmRL3omfUi5RUB/xTmfvTL7jru+qblH 9MrWH33cl31qcaAc6VGIpPmQox6rvuIo/vLaee7ghVwN3cB2xt9bv/RrJlIZzcz3 FsXk+Q4pOZcKiTSX475u0bJmKG4nEhv3vUTq8UIW7qXO6OvroVw6nDQn22MXjsc= =N4ta -----END PGP SIGNATURE----- --QtvnEaotWG30EGOsWs9UCmLRNDR18FBWf--