On 09/13/2015 03:42 PM, Gerhard Bertelsmann wrote:
>> > Even if it does start, it is really confusing. Please move the
>> > clk_prepare_enable in the open function.
>> > 
> That was my first approach. IMHO it's useful to enable/disable
> according to the state of the CAN interface to save power.

The open() function is perfectly right, enabling the clock in the probe
function keeps the clock powered even if the CAN controller is not used.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |