From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754227AbbINIap (ORCPT ); Mon, 14 Sep 2015 04:30:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46192 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753409AbbINIal (ORCPT ); Mon, 14 Sep 2015 04:30:41 -0400 Subject: Re: [PATCH 31/39] KVM: MMU: drop null test before destroy functions To: Julia Lawall , Gleb Natapov References: <1442146532-9100-1-git-send-email-Julia.Lawall@lip6.fr> <1442146532-9100-32-git-send-email-Julia.Lawall@lip6.fr> Cc: sergey.senozhatsky@gmail.com, kernel-janitors@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org From: Paolo Bonzini Message-ID: <55F685A5.1050805@redhat.com> Date: Mon, 14 Sep 2015 10:30:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1442146532-9100-32-git-send-email-Julia.Lawall@lip6.fr> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/09/2015 14:15, Julia Lawall wrote: > Remove unneeded NULL test. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ expression x; @@ > -if (x != NULL) > \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x); > // > > Signed-off-by: Julia Lawall > > --- > arch/x86/kvm/mmu.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c > index 69088a1..fb0c1bd 100644 > --- a/arch/x86/kvm/mmu.c > +++ b/arch/x86/kvm/mmu.c > @@ -4883,10 +4883,8 @@ static struct shrinker mmu_shrinker = { > > static void mmu_destroy_caches(void) > { > - if (pte_list_desc_cache) > - kmem_cache_destroy(pte_list_desc_cache); > - if (mmu_page_header_cache) > - kmem_cache_destroy(mmu_page_header_cache); > + kmem_cache_destroy(pte_list_desc_cache); > + kmem_cache_destroy(mmu_page_header_cache); > } > > int kvm_mmu_module_init(void) > Acked-by: Paolo Bonzini From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Date: Mon, 14 Sep 2015 08:30:29 +0000 Subject: Re: [PATCH 31/39] KVM: MMU: drop null test before destroy functions Message-Id: <55F685A5.1050805@redhat.com> List-Id: References: <1442146532-9100-1-git-send-email-Julia.Lawall@lip6.fr> <1442146532-9100-32-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1442146532-9100-32-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall , Gleb Natapov Cc: sergey.senozhatsky@gmail.com, kernel-janitors@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org On 13/09/2015 14:15, Julia Lawall wrote: > Remove unneeded NULL test. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ expression x; @@ > -if (x != NULL) > \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x); > // > > Signed-off-by: Julia Lawall > > --- > arch/x86/kvm/mmu.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c > index 69088a1..fb0c1bd 100644 > --- a/arch/x86/kvm/mmu.c > +++ b/arch/x86/kvm/mmu.c > @@ -4883,10 +4883,8 @@ static struct shrinker mmu_shrinker = { > > static void mmu_destroy_caches(void) > { > - if (pte_list_desc_cache) > - kmem_cache_destroy(pte_list_desc_cache); > - if (mmu_page_header_cache) > - kmem_cache_destroy(mmu_page_header_cache); > + kmem_cache_destroy(pte_list_desc_cache); > + kmem_cache_destroy(mmu_page_header_cache); > } > > int kvm_mmu_module_init(void) > Acked-by: Paolo Bonzini