From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH 10/10] drm/i915: Only run commit when crtc is active. Date: Mon, 14 Sep 2015 12:02:18 +0200 Message-ID: <55F69B2A.3030004@linux.intel.com> References: <1441894085-25662-1-git-send-email-maarten.lankhorst@linux.intel.com> <1441894085-25662-11-git-send-email-maarten.lankhorst@linux.intel.com> <20150910155156.GK2767@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 997296E7CD for ; Mon, 14 Sep 2015 03:02:20 -0700 (PDT) In-Reply-To: <20150910155156.GK2767@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMTAtMDktMTUgb20gMTc6NTEgc2NocmVlZiBEYW5pZWwgVmV0dGVyOgo+IE9uIFRodSwgU2Vw IDEwLCAyMDE1IGF0IDA0OjA4OjA1UE0gKzAyMDAsIE1hYXJ0ZW4gTGFua2hvcnN0IHdyb3RlOgo+ PiBUaGUgY3J0Yy0+YWN0aXZlIGd1YXJkcyBhcmUgbm8gbG9uZ2VyIG5lZWRlZCBub3cgdGhhdCBh bGwgc3RhdGUKPj4gdXBkYXRlcyBhcmUgb3V0c2lkZSB0aGUgY29tbWl0Lgo+Pgo+PiBTaWduZWQt b2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwu Y29tPgo+IFRoaXMgbG9va3MgYWN0dWFsbHkgY29tcGxpY2F0ZWQsIHNvIEknbGwgcHVudC4gTWVy Z2VkIG1vc3Qgb2YgdGhlIG90aGVyCj4gcGF0Y2hlcyBmcm9tIHlvdXIgc2VyaWVzLCB0aGFua3Mu Ckl0J3MgdmVyeSBlYXN5LCBidXQgbmVlZHMgcHJldmlvdXMgcGF0Y2hlcyB0byBiZSBhcHBsaWVk LCB0aGUgZml4dXAgcGF0Y2ggZm9yIGludGVsX3VwZGF0ZV9wcmltYXJpZXMgYW5kIHRoZSB1cGRh dGUgcHJpbWFyeSBwbGFuZSBzdGF0ZSBvdXRzaWRlIGNvbW1pdF9wcmltYXJ5X3BsYW5lIHBhdGNo LgoKV2l0aCBhbGwgc3RhdGUgdXBkYXRlcyBpbiBjb21taXQgZ29uZSwgb25seSBodyBzdGF0ZSBp cyBzdGlsbCB1cGRhdGVkLgpFYWNoIGNvbW1pdF9wbGFuZSBoYXMgYSBsaW5lIHdpdGggaWYgKCFj cnRjLT5zdGF0ZS0+YWN0aXZlKSByZXR1cm47IGVnIGl0cyBhIG5vb3Agd2hlbiBjcnRjIGlzIGlu YWN0aXZlLiBTYW1lIGZvciBiZWdpbi9maW5pc2ggY3J0Y19jb21taXQuCgpIZW5jZSBpdCBjb3Vs ZCBiZSBjaGFuZ2VkIHRvCmlmIChjcnRjLT5zdGF0ZS0+YWN0aXZlKQpkcm1fYXRvbWljX2hlbHBl cl9jb21taXRfcGxhbmVzX29uX2NydGMoY3J0Y19zdGF0ZSk7CgpXaGVuIHBsYW5lc19jaGFuZ2Vk ID0gZmFsc2UsIHRoZXJlIGlzIG5vIHBsYW5lIHN0YXRlIGZvciB0aGUgY3VycmVudCBjcnRjLiBU aGUgb3RoZXIgZnVuY3Rpb24gb2YgYmVnaW5fY3J0Y19jb21taXQgaXMgdXBkYXRpbmcgcGlwZSBj b25maWcgZm9yIGEgZmFzdHNldC4KCklmIG5laXRoZXIgYXJlIHJlcXVpcmVkLCB0aGVyZSdzIG5v IGh3IHN0YXRlIHRvIHVwZGF0ZSwgc28gY29tbWl0X3BsYW5lc19vbl9jcnRjIHdvdWxkIGRvIHZi bGFuayBldmFzaW9uIGZvciBubyByZWFzb24uIEl0IGNhbiBiZSBza2lwcGVkLgoKTWF5YmUgaXQn cyBlYXNpZXIgdG8gdW5kZXJzdGFuZCBpZiBJIHNwbGl0IHRoaXMgdXAgaW4gMiBwYXRjaGVzLiBP bmUgdG8gbWFrZSB0aGUgY3J0Yy0+c3RhdGUtPmFjdGl2ZSBjaGFuZ2VzLCBhbm90aGVyIHRvIGFk ZCB0aGUgcGxhbmVzX2NoYW5nZWQgfHwgdXBkYXRlX3BpcGUgY2hhbmdlcy4KPiAtRGFuaWVsCj4+ IC0tLQo+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgMTYgKysrKysr LS0tLS0tLS0tLQo+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMgIHwgIDMg LS0tCj4+ICAyIGZpbGVzIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgMTMgZGVsZXRpb25zKC0p Cj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPj4gaW5kZXggZjQxY2E1NThi YTNiLi5kYzY5NmVjNWYyMjggMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Rpc3BsYXkuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5 LmMKPj4gQEAgLTEzMTM1LDcgKzEzMTM1LDkgQEAgc3RhdGljIGludCBpbnRlbF9hdG9taWNfY29t bWl0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4+ICAJCWlmICghbW9kZXNldCkKPj4gIAkJCWlu dGVsX3ByZV9wbGFuZV91cGRhdGUoaW50ZWxfY3J0Yyk7Cj4+ICAKPj4gLQkJZHJtX2F0b21pY19o ZWxwZXJfY29tbWl0X3BsYW5lc19vbl9jcnRjKGNydGNfc3RhdGUpOwo+PiArCQlpZiAoY3J0Yy0+ c3RhdGUtPmFjdGl2ZSAmJiAoY3J0Yy0+c3RhdGUtPnBsYW5lc19jaGFuZ2VkIHx8Cj4+ICsJCSAg ICB0b19pbnRlbF9jcnRjX3N0YXRlKGNydGMtPnN0YXRlKS0+dXBkYXRlX3BpcGUpKQo+PiArCQkJ ZHJtX2F0b21pY19oZWxwZXJfY29tbWl0X3BsYW5lc19vbl9jcnRjKGNydGNfc3RhdGUpOwo+PiAg Cj4+ICAJCWlmIChwdXRfZG9tYWlucykKPj4gIAkJCW1vZGVzZXRfcHV0X3Bvd2VyX2RvbWFpbnMo ZGV2X3ByaXYsIHB1dF9kb21haW5zKTsKPj4gQEAgLTEzNDQ1LDkgKzEzNDQ3LDYgQEAgaW50ZWxf Y29tbWl0X3ByaW1hcnlfcGxhbmUoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4+ICAKPj4gIAlj cnRjID0gY3J0YyA/IGNydGMgOiBwbGFuZS0+Y3J0YzsKPj4gIAo+PiAtCWlmICghY3J0Yy0+c3Rh dGUtPmFjdGl2ZSkKPj4gLQkJcmV0dXJuOwo+PiAtCj4+ICAJZGV2X3ByaXYtPmRpc3BsYXkudXBk YXRlX3ByaW1hcnlfcGxhbmUoY3J0YywgZmIsCj4+ICAJCQkJCSAgICAgICBzdGF0ZS0+c3JjLngx ID4+IDE2LAo+PiAgCQkJCQkgICAgICAgc3RhdGUtPnNyYy55MSA+PiAxNik7Cj4+IEBAIC0xMzQ3 Niw4ICsxMzQ3NSw3IEBAIHN0YXRpYyB2b2lkIGludGVsX2JlZ2luX2NydGNfY29tbWl0KHN0cnVj dCBkcm1fY3J0YyAqY3J0YywKPj4gIAkJaW50ZWxfdXBkYXRlX3dhdGVybWFya3MoY3J0Yyk7Cj4+ ICAKPj4gIAkvKiBQZXJmb3JtIHZibGFuayBldmFzaW9uIGFyb3VuZCBjb21taXQgb3BlcmF0aW9u ICovCj4+IC0JaWYgKGNydGMtPnN0YXRlLT5hY3RpdmUpCj4+IC0JCWludGVsX3BpcGVfdXBkYXRl X3N0YXJ0KGludGVsX2NydGMpOwo+PiArCWludGVsX3BpcGVfdXBkYXRlX3N0YXJ0KGludGVsX2Ny dGMpOwo+PiAgCj4+ICAJaWYgKG1vZGVzZXQpCj4+ICAJCXJldHVybjsKPj4gQEAgLTEzNDkzLDgg KzEzNDkxLDcgQEAgc3RhdGljIHZvaWQgaW50ZWxfZmluaXNoX2NydGNfY29tbWl0KHN0cnVjdCBk cm1fY3J0YyAqY3J0YywKPj4gIHsKPj4gIAlzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0YyA9 IHRvX2ludGVsX2NydGMoY3J0Yyk7Cj4+ICAKPj4gLQlpZiAoY3J0Yy0+c3RhdGUtPmFjdGl2ZSkK Pj4gLQkJaW50ZWxfcGlwZV91cGRhdGVfZW5kKGludGVsX2NydGMpOwo+PiArCWludGVsX3BpcGVf dXBkYXRlX2VuZChpbnRlbF9jcnRjKTsKPj4gIH0KPj4gIAo+PiAgLyoqCj4+IEBAIC0xMzY3Nyw4 ICsxMzY3NCw3IEBAIGludGVsX2NvbW1pdF9jdXJzb3JfcGxhbmUoc3RydWN0IGRybV9wbGFuZSAq cGxhbmUsCj4+ICAJaW50ZWxfY3J0Yy0+Y3Vyc29yX2JvID0gb2JqOwo+PiAgCj4+ICB1cGRhdGU6 Cj4+IC0JaWYgKGNydGMtPnN0YXRlLT5hY3RpdmUpCj4+IC0JCWludGVsX2NydGNfdXBkYXRlX2N1 cnNvcihjcnRjLCBzdGF0ZS0+dmlzaWJsZSk7Cj4+ICsJaW50ZWxfY3J0Y191cGRhdGVfY3Vyc29y KGNydGMsIHN0YXRlLT52aXNpYmxlKTsKPj4gIH0KPj4gIAo+PiAgc3RhdGljIHN0cnVjdCBkcm1f cGxhbmUgKmludGVsX2N1cnNvcl9wbGFuZV9jcmVhdGUoc3RydWN0IGRybV9kZXZpY2UgKmRldiwK Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5jIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMKPj4gaW5kZXggOTU1Mzg1OWNhMTUxLi45 YzEzZDgxNTYxMzUgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nw cml0ZS5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5jCj4+IEBA IC05MjcsOSArOTI3LDYgQEAgaW50ZWxfY29tbWl0X3Nwcml0ZV9wbGFuZShzdHJ1Y3QgZHJtX3Bs YW5lICpwbGFuZSwKPj4gIAo+PiAgCWNydGMgPSBjcnRjID8gY3J0YyA6IHBsYW5lLT5jcnRjOwo+ PiAgCj4+IC0JaWYgKCFjcnRjLT5zdGF0ZS0+YWN0aXZlKQo+PiAtCQlyZXR1cm47Cj4+IC0KPj4g IAlpZiAoc3RhdGUtPnZpc2libGUpIHsKPj4gIAkJaW50ZWxfcGxhbmUtPnVwZGF0ZV9wbGFuZShw bGFuZSwgY3J0YywgZmIsCj4+ICAJCQkJCSAgc3RhdGUtPmRzdC54MSwgc3RhdGUtPmRzdC55MSwK Pj4gLS0gCj4+IDIuMS4wCj4+Cj4+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCj4+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPj4gSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwo+PiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vaW50ZWwtZ2Z4CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeAo=