From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Date: Mon, 14 Sep 2015 14:06:17 +0100
Subject: [Buildroot] [PATCH] micropython: new package
In-Reply-To: <1442226102-15878-1-git-send-email-judge.packham@gmail.com>
References: <1442226102-15878-1-git-send-email-judge.packham@gmail.com>
Message-ID: <55F6C649.60700@imgtec.com>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

Dear Chris Packham,

On 09/14/2015 11:21 AM, Chris Packham wrote:
> MicroPython - a lean and efficient Python implementation for
> microcontrollers and constrained systems.

The website says:

"Micro Python is a lean and fast implementation of the Python 3
programming language that is optimised to run on a microcontroller."

So, why don't we use that comment instead? It also specifies the Python
version which is important.

More comments below. Please scroll down.

> Signed-off-by: Chris Packham <judge.packham@gmail.com>
> ---
> 
> Hi Buildroot,
>     
> Thought you might be interested in mircopython a minimal python 3
> implementation. It's designed for micro controllers but is also well suited
> to other general purpose embedded CPUs.
>     
> Cheers,
> Chris
> 
>  package/Config.in                          |  2 ++
>  package/micropython-lib/Config.in          |  7 +++++++
>  package/micropython-lib/micropython-lib.mk | 12 ++++++++++++
>  package/micropython/Config.in              |  8 ++++++++
>  package/micropython/micropython.mk         | 22 ++++++++++++++++++++++
>  5 files changed, 51 insertions(+)
>  create mode 100644 package/micropython-lib/Config.in
>  create mode 100644 package/micropython-lib/micropython-lib.mk
>  create mode 100644 package/micropython/Config.in
>  create mode 100644 package/micropython/micropython.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index fc35f12..986fe16 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -509,6 +509,8 @@ menu "Lua libraries/modules"
>  endmenu
>  endif
>  	source "package/lutok/Config.in"
> +	source "package/micropython/Config.in"
> +	source "package/micropython-lib/Config.in"
>  	source "package/moarvm/Config.in"
>  	source "package/mono/Config.in"
>  if BR2_PACKAGE_MONO
> diff --git a/package/micropython-lib/Config.in b/package/micropython-lib/Config.in
> new file mode 100644
> index 0000000..a7e017b
> --- /dev/null
> +++ b/package/micropython-lib/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_MICROPYTHON_LIB
> +	bool "micropython-lib"
> +	depends on BR2_PACKAGE_MICROPYTHON
> +	help
> +	  Core Python libraries ported to MicroPython.
> +
> +	  http://micropython.org
> diff --git a/package/micropython-lib/micropython-lib.mk b/package/micropython-lib/micropython-lib.mk
> new file mode 100644
> index 0000000..c0e6a2a
> --- /dev/null
> +++ b/package/micropython-lib/micropython-lib.mk
> @@ -0,0 +1,12 @@
> +################################################################################
> +# micropython-lib
> +################################################################################
> +MICROPYTHON_LIB_VERSION = v0.5
> +MICROPYTHON_LIB_SITE = $(call github,micropython,micropython-lib,$(MICROPYTHON_LIB_VERSION))
> +MICROPYTHON_LIB_LICENSE_FILES = LICENSE
> +
> +define MICROPYTHON_LIB_INSTALL_TARGET_CMDS
> +	$(MAKE) -C $(@D) PREFIX=$(TARGET_DIR)/usr/lib/micropython install
> +endef
> +
> +$(eval $(generic-package))
> diff --git a/package/micropython/Config.in b/package/micropython/Config.in
> new file mode 100644
> index 0000000..ca60f01
> --- /dev/null
> +++ b/package/micropython/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_MICROPYTHON
> +	bool "micropython"
> +	select BR2_PACKAGE_LIBFFI
> +	help
> +	  MicroPython - a lean and efficient Python implementation for
> +	  microcontrollers and constrained systems.

Same here, I would use the same exact command you can find in
mycropython's website.

> +
> +	  http://micropython.org
> diff --git a/package/micropython/micropython.mk b/package/micropython/micropython.mk
> new file mode 100644
> index 0000000..9b5e7d2
> --- /dev/null
> +++ b/package/micropython/micropython.mk
> @@ -0,0 +1,22 @@
> +################################################################################
> +# micropython
> +################################################################################
> +MICROPYTHON_VERSION = v1.4.5
> +MICROPYTHON_SITE = $(call github,micropython,micropython,$(MICROPYTHON_VERSION))
> +MICROPYTHON_LICENSE = MIT
> +MICROPYTHON_LICENSE_FILES = LICENSE
> +MICROPYTHON_DEPENDENCIES = libffi
> +
> +ifeq ($(BR2_powerpc),y)
> +MICROPYTHON_CFLAGS = -DMICROPY_GCREGS_SETJMP=1
> +endif

A comment about why this is necessary for powerpc would be good, IMHO.

Regards,

Vincent.

> +
> +define MICROPYTHON_INSTALL_TARGET_CMDS
> +	$(MAKE) -C $(@D)/unix \
> +		CROSS_COMPILE=$(TARGET_CROSS) \
> +		DESTDIR=$(TARGET_DIR) \
> +		CFLAGS_EXTRA=$(MICROPYTHON_CFLAGS) \
> +		install
> +endef
> +
> +$(eval $(generic-package))
>