From: Laurentiu Tudor <b10716@freescale.com>
To: kvm-ppc@vger.kernel.org
Subject: Re: [PATCH] powerpc/e500: move qemu machine spec together with the rest
Date: Mon, 14 Sep 2015 13:17:09 +0000 [thread overview]
Message-ID: <55F6C8D5.8020104@freescale.com> (raw)
In-Reply-To: <55E992AE.3010605@freescale.com>
On 09/10/2015 02:01 AM, Scott Wood wrote:
> On Fri, 2015-09-04 at 15:46 +0300, Laurentiu Tudor wrote:
>> This way we get rid of an entire file with mostly
>> duplicated code plus a Kconfig option that you always
>> had to take care to check it in order for kvm to work.
>>
>> Signed-off-by: Laurentiu Tudor <Laurentiu.Tudor@freescale.com>
>> ---
>> arch/powerpc/platforms/85xx/Kconfig | 15 -----
>> arch/powerpc/platforms/85xx/Makefile | 1 -
>> arch/powerpc/platforms/85xx/corenet_generic.c | 1 +
>> arch/powerpc/platforms/85xx/qemu_e500.c | 85 ------------------------
>
>
> qemu_e500 is not only for corenet chips.
That's too bad. :-(
I remember discussions on dropping the e500v2 support at some point in time?
> We can add it to the defconfig (in fact I've been meaning to do so).
Or maybe just drop de KConfig option and
wrap the file in an #ifdef CONFIG_KVM or something along these lines?
>> -static void __init qemu_e500_setup_arch(void)
>> -{
>> - ppc_md.progress("qemu_e500_setup_arch()", 0);
>> -
>> - fsl_pci_assign_primary();
>> - swiotlb_detect_4g();
>
> Where is fsl_pci_assign_primary() in corenet_generic.c?
This commit claims it's not needed and drops it:
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id}4d595dad30328bc6153e235d90f54c918fc127
> At one point this
> was needed for QEMU's PCI implementation -- have you tested QEMU PCI without
> it?
Well, somehow i've (embarrassingly) messed up my initial tests.
I've retested after seeing your comment and indeed this breaks pci under qemu.
Adding to the confusion, the commit above made me think that the removal was safe.
Why pci qemu doesn't work without the call to fsl_pci_assign_primary() is
an interesting subject.
---
Best Regards, Laurentiu
next prev parent reply other threads:[~2015-09-14 13:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 12:46 [PATCH] powerpc/e500: move qemu machine spec together with the rest Laurentiu Tudor
2015-09-09 23:01 ` Scott Wood
2015-09-14 13:17 ` Laurentiu Tudor [this message]
2015-09-14 14:14 ` Alexander Graf
2015-09-14 15:09 ` Scott Wood
2015-09-14 15:11 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F6C8D5.8020104@freescale.com \
--to=b10716@freescale.com \
--cc=kvm-ppc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.