From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754043AbbINOXz (ORCPT ); Mon, 14 Sep 2015 10:23:55 -0400 Received: from mx01-fr.bfs.de ([193.174.231.67]:34413 "EHLO mx01-fr.bfs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751302AbbINOXy (ORCPT ); Mon, 14 Sep 2015 10:23:54 -0400 Message-ID: <55F6D86B.3000304@bfs.de> Date: Mon, 14 Sep 2015 16:23:39 +0200 From: walter harms Reply-To: wharms@bfs.de User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.1.16) Gecko/20101125 SUSE/3.0.11 Thunderbird/3.0.11 MIME-Version: 1.0 To: Mikulas Patocka CC: device-mapper development , Alasdair Kergon , Mike Snitzer , kernel-janitors@vger.kernel.org, Neil Brown , linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, sergey.senozhatsky@gmail.com Subject: Re: [dm-devel] [PATCH 12/39] dm: drop null test before destroy functions References: <1442146532-9100-1-git-send-email-Julia.Lawall@lip6.fr> <1442146532-9100-13-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 14.09.2015 15:46, schrieb Mikulas Patocka: > > On Sun, 13 Sep 2015, Julia Lawall wrote: > >> > Remove unneeded NULL test. >> > >> > The semantic patch that makes this change is as follows: >> > (http://coccinelle.lip6.fr/) >> > >> > // >> > @@ expression x; @@ >> > -if (x != NULL) >> > \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x); >> > // >> > >> > Signed-off-by: Julia Lawall >> > >> > --- >> > drivers/md/dm-bufio.c | 3 +-- >> > drivers/md/dm-cache-target.c | 3 +-- >> > drivers/md/dm-crypt.c | 6 ++---- >> > drivers/md/dm-io.c | 3 +-- >> > drivers/md/dm-log-userspace-base.c | 3 +-- >> > drivers/md/dm-region-hash.c | 4 +--- >> > drivers/md/dm.c | 13 ++++--------- >> > 7 files changed, 11 insertions(+), 24 deletions(-) >> > >> > diff --git a/drivers/md/dm-bufio.c b/drivers/md/dm-bufio.c >> > index 83cc52e..8ad39b6 100644 >> > --- a/drivers/md/dm-bufio.c >> > +++ b/drivers/md/dm-bufio.c >> > @@ -1864,8 +1864,7 @@ static void __exit dm_bufio_exit(void) >> > for (i = 0; i < ARRAY_SIZE(dm_bufio_caches); i++) { >> > struct kmem_cache *kc = dm_bufio_caches[i]; >> > >> > - if (kc) >> > - kmem_cache_destroy(kc); >> > + kmem_cache_destroy(kc); >> > } maybe you want to remove "kc" also by calling kmem_cache_destroy(dm_bufio_caches[i]); directly ? just a hint, wh From mboxrd@z Thu Jan 1 00:00:00 1970 From: walter harms Date: Mon, 14 Sep 2015 14:23:39 +0000 Subject: Re: [dm-devel] [PATCH 12/39] dm: drop null test before destroy functions Message-Id: <55F6D86B.3000304@bfs.de> List-Id: References: <1442146532-9100-1-git-send-email-Julia.Lawall@lip6.fr> <1442146532-9100-13-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Mikulas Patocka Cc: device-mapper development , Alasdair Kergon , Mike Snitzer , kernel-janitors@vger.kernel.org, Neil Brown , linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, sergey.senozhatsky@gmail.com Am 14.09.2015 15:46, schrieb Mikulas Patocka: > > On Sun, 13 Sep 2015, Julia Lawall wrote: > >> > Remove unneeded NULL test. >> > >> > The semantic patch that makes this change is as follows: >> > (http://coccinelle.lip6.fr/) >> > >> > // >> > @@ expression x; @@ >> > -if (x != NULL) >> > \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x); >> > // >> > >> > Signed-off-by: Julia Lawall >> > >> > --- >> > drivers/md/dm-bufio.c | 3 +-- >> > drivers/md/dm-cache-target.c | 3 +-- >> > drivers/md/dm-crypt.c | 6 ++---- >> > drivers/md/dm-io.c | 3 +-- >> > drivers/md/dm-log-userspace-base.c | 3 +-- >> > drivers/md/dm-region-hash.c | 4 +--- >> > drivers/md/dm.c | 13 ++++--------- >> > 7 files changed, 11 insertions(+), 24 deletions(-) >> > >> > diff --git a/drivers/md/dm-bufio.c b/drivers/md/dm-bufio.c >> > index 83cc52e..8ad39b6 100644 >> > --- a/drivers/md/dm-bufio.c >> > +++ b/drivers/md/dm-bufio.c >> > @@ -1864,8 +1864,7 @@ static void __exit dm_bufio_exit(void) >> > for (i = 0; i < ARRAY_SIZE(dm_bufio_caches); i++) { >> > struct kmem_cache *kc = dm_bufio_caches[i]; >> > >> > - if (kc) >> > - kmem_cache_destroy(kc); >> > + kmem_cache_destroy(kc); >> > } maybe you want to remove "kc" also by calling kmem_cache_destroy(dm_bufio_caches[i]); directly ? just a hint, wh