From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35348) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbWAZ-0003oy-AH for qemu-devel@nongnu.org; Mon, 14 Sep 2015 11:59:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZbWAW-000175-2j for qemu-devel@nongnu.org; Mon, 14 Sep 2015 11:59:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34641) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbWAV-00016t-TU for qemu-devel@nongnu.org; Mon, 14 Sep 2015 11:59:48 -0400 References: <1442240110-26006-1-git-send-email-leon.alrae@imgtec.com> From: Eric Blake Message-ID: <55F6EEF2.3090409@redhat.com> Date: Mon, 14 Sep 2015 09:59:46 -0600 MIME-Version: 1.0 In-Reply-To: <1442240110-26006-1-git-send-email-leon.alrae@imgtec.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MhrP7CIS0UaJeUI2Cbp48rAXQgpu9i2sN" Subject: Re: [Qemu-devel] [PATCH] vfio: change the order of includes to fix build on CentOS 5 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Leon Alrae , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, alex.williamson@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --MhrP7CIS0UaJeUI2Cbp48rAXQgpu9i2sN Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/14/2015 08:15 AM, Leon Alrae wrote: > Include linux/vfio.h after sys/ioctl.h, just like in hw/vfio/common.c a= nd > hw/vfio/platform.c. >=20 > This fixes the regression caused by the change in commit d7646f2: How much longer are we planning on building on CentOS 5? Didn't we already break things with a glib minimum requirement in qemu 2.5, plus the now-pending bump to python 2.6? While I'm not opposed to this patch, I'm wondering if it will make any real difference. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --MhrP7CIS0UaJeUI2Cbp48rAXQgpu9i2sN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV9u7yAAoJEKeha0olJ0Nq7VoH/2yWLsCN8GR+6ahitEJgVfdo UQ4GbWN6/x/HpaSq+Q3b47NrqZ51+qzuEL1s/baISQ5hzBFbgu3Pla/hD0D6dAZa hllEzW8GbJ/ILp3QHay7C+r70zggyu5N8Gq1o63DnLNvauvvkLn/s7iqA4Ksf63P FIk6HVds6c+1h/RJLheL5/6/U0uw4urfdASCG8fxhbtyMhOVxhqcHvpt3ofiVGik 5JgtJ+XcaohwWoa+5P2j4y87Do+BmKsOHVhSHQByyHAKQD9+RtDV8UCqkw44hlTA TD66SSR7nmG/4UgMC0V1dNhiwunFUasLuZnKnZ49IPTbp3JMpI9srptCUASj9bI= =XWif -----END PGP SIGNATURE----- --MhrP7CIS0UaJeUI2Cbp48rAXQgpu9i2sN--