From: "Jan Beulich" <JBeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Malcolm Crossley <malcolm.crossley@citrix.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH for 4.6] x86/mm: make {set, clear}_identity_p2m_mapping() work for HVM guests as well
Date: Mon, 14 Sep 2015 08:42:27 -0600 [thread overview]
Message-ID: <55F6F8F302000078000A29F5@prv-mh.provo.novell.com> (raw)
In-Reply-To: <1442240654-3456-1-git-send-email-andrew.cooper3@citrix.com>
>>> On 14.09.15 at 16:24, <andrew.cooper3@citrix.com> wrote:
> For Intel IGD passthrough, the guest driver programs the device to DMA
> to/from its RMRR.
>
> c/s 619ecf8 "make {set,clear}_identity_p2m_mapping() work for PV guests"
> was incomplete for pre-Broadwell systems which did not support shared
> EPT.
>
> The correct check to use is iommu_use_hap_pt() not
> paging_mode_translate() as IOMMU mappings also need to be created for
> HVM guests with separate EPT and IOMMU tables.
No, at least not without a very good explanation:
> --- a/xen/arch/x86/mm/p2m.c
> +++ b/xen/arch/x86/mm/p2m.c
> @@ -957,7 +957,7 @@ int set_identity_p2m_entry(struct domain *d, unsigned long gfn,
> struct p2m_domain *p2m = p2m_get_hostp2m(d);
> int ret;
>
> - if ( !paging_mode_translate(p2m->domain) )
> + if ( !iommu_use_hap_pt(d) )
Not only have these checks no reason to be in any way IOMMU
dependent (no other function around here does so), but also
both ept_set_entry() and p2m_pt_set_entry() take care to call
iommu_{,un}map_page() as needed (as I had already pointed
out back when we discussed the patch this one tries to complete).
If anything, it would be those low level functions that may need
tweaking (and which have a reason to consider IOMMU flags) if
for some reason they don't actually do the expected calls.
Jan
prev parent reply other threads:[~2015-09-14 14:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 14:24 [PATCH for 4.6] x86/mm: make {set, clear}_identity_p2m_mapping() work for HVM guests as well Andrew Cooper
2015-09-14 14:42 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F6F8F302000078000A29F5@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=malcolm.crossley@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.