From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50844) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZboK0-0007mD-Gr for qemu-devel@nongnu.org; Tue, 15 Sep 2015 07:22:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZboJv-0007IB-6d for qemu-devel@nongnu.org; Tue, 15 Sep 2015 07:22:48 -0400 References: <1442194913-26545-1-git-send-email-david@gibson.dropbear.id.au> <1442194913-26545-2-git-send-email-david@gibson.dropbear.id.au> <55F683CB.6000508@ozlabs.ru> <20150914114503.GP2547@voom.fritz.box> <55F6B989.8010900@redhat.com> <20150915003036.GR2547@voom.fritz.box> From: Paolo Bonzini Message-ID: <55F7FB6C.3010008@redhat.com> Date: Tue, 15 Sep 2015 13:05:16 +0200 MIME-Version: 1.0 In-Reply-To: <20150915003036.GR2547@voom.fritz.box> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFCv2 1/2] spapr: Remove unnecessary owner field from sPAPRDRConnector List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: mdroth@linux.vnet.ibm.com, Alexey Kardashevskiy , agraf@suse.de, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, bharata@linux.vnet.ibm.com -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 15/09/2015 02:30, David Gibson wrote: >>> I think the comment is wrong or at least inaccurate; it only >>> applies to the external QOM interface. The patch is a good >>> idea, even though OBJECT(x)->y traditionally is not used >>> (instead you assign OBJECT(x) to a different Object* >>> variable). > Ok.. so are you prepared to give a Reviewed-by, or do I need to > ask someone else (Andreas?) to approve this as QOMishly correct? I am, but as I said in another message I wonder if accessing the parent field is actually necessary. Paolo -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJV9/toAAoJEL/70l94x66DlgIH/3gVH53/bBLzUc77IfDbGlMZ FIA94/uVb+HJWz29y0yv3V9RO+PpjhO9rQWUM3K+1TyH+Bu0st9HlGcxjhZVXpsH So0IcVgBGFZry+3XyuIZ9TanpDcKo1cXSc5OZ/P7eBP/TviLcKshtfmn9WpgRWm7 DnVBFe1rSId7a8qn8BUeHyHtCLEwWcn8sOJla4w66PiGXVBG1p+mMU+lOXm6mQMD sy3LNMRS2duhDyMncMF6tsTn03CesfiW+2b1U5U/Q3ZIFTLdOLFMTiBK8giTfd2J FoePn1sZkF5SW4fPL8Gye1qbmnkpLUDMODHTUF3AI61Q11CAULFjxOkPK/QGEEI= =lh5f -----END PGP SIGNATURE-----