From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52949) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcE5K-0006VE-94 for qemu-devel@nongnu.org; Wed, 16 Sep 2015 10:53:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZcE5J-0008N1-7p for qemu-devel@nongnu.org; Wed, 16 Sep 2015 10:53:22 -0400 References: <1441878905-5272-1-git-send-email-wency@cn.fujitsu.com> <1441878905-5272-2-git-send-email-wency@cn.fujitsu.com> <87r3m1krdl.fsf@blackfin.pond.sub.org> <55F6EBF5.2090101@redhat.com> <55F776CC.3050601@cn.fujitsu.com> <87fv2g876a.fsf@blackfin.pond.sub.org> <55F7D06D.1080205@cn.fujitsu.com> <87mvwo3phm.fsf@blackfin.pond.sub.org> <55F9054F.1000001@cn.fujitsu.com> <87r3lyzsef.fsf@blackfin.pond.sub.org> <55F92745.6040904@cn.fujitsu.com> <87bnd2y5mn.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <55F98256.8080304@redhat.com> Date: Wed, 16 Sep 2015 08:53:10 -0600 MIME-Version: 1.0 In-Reply-To: <87bnd2y5mn.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Vr37Wlmg267SupXrOjpu245WrSOh6OfMU" Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v3 1/5] support nbd driver in blockdev-add List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , Wen Congyang Cc: Kevin Wolf , zhanghailiang , qemu block , Jiang Yunhong , Dong Eddie , qemu devel , "Dr. David Alan Gilbert" , Gonglei , Stefan Hajnoczi , Yang Hongyang This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Vr37Wlmg267SupXrOjpu245WrSOh6OfMU Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/16/2015 05:18 AM, Markus Armbruster wrote: >>>>>>> Perhaps it could be as simple as >>>>>>> >>>>>>> { 'struct': 'BlockdevOptionsNBD', >>>>>>> 'data': { 'addr: 'SocketAddress', 'export': 'str' } } >>>>>> >>>>>> The problem is that: NBD doesn't use the fd. >>>>> >>>>> Is that fundamental, or just a matter of implementation? >>> >>> Question still open. >=20 > Question still open. Dan's patches didn't address it... > Long term, I'd like to see us get rid of the conversions between > QAPI-generated types and QDict / QemuOpts. >=20 > Short term, you need to co-evolve the QDict-based code such as > nbd_config() with the QAPI interfaces. =2E..but DO affect the short-term, by starting the conversion over to using the QAPI type more fully: https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg04383.html >=20 > Keeping the QAPI interface clean is more important than minimizing the > implementation work, because we're free to mess with the implementation= , > but releasing a QAPI interface makes it ABI, so we better get it right.= Especially once the QAPI interface is actually used by a QMP command (there are places where we are using qapi internally for ease in command line handling, but not exposing the structures through QMP yet). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Vr37Wlmg267SupXrOjpu245WrSOh6OfMU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJV+YJWAAoJEKeha0olJ0NqKbAH/2Y/hrB6wUnzi/KfZO02ydZX saVwbwU5YSWzMoss9qYVRSYRNZ26lQjzc+tkUJ6O5BH/4r8isnoc+Yz8hQU2n7JJ LnSPKEEMsfa/V/8wzQ7ccGdpbDECLxsZGtk1bGiTsx6FlBXpDY/nWUgkr4Z81qHU BDRKLNSVopFCQCpzWELpFs2I02IiJ28VO055UVf6vPXte6QQ5HUv4l3V1XfsP4Ha V8wu6UgYmcjFJMnwZ+yzZM31qI5R7dS+hlooZBMptymZWLei2xKM2XQNobLk2Og2 4A0o0e4cLpPVzpN1s3STCO40fvwuPGt97PPI3zaapJBUHriz4n6eu4dpStRjlAc= =MuMl -----END PGP SIGNATURE----- --Vr37Wlmg267SupXrOjpu245WrSOh6OfMU--