From mboxrd@z Thu Jan 1 00:00:00 1970 From: wei@redhat.com (Wei Huang) Date: Wed, 16 Sep 2015 16:07:08 -0500 Subject: [PATCH v2 00/22] KVM: ARM64: Add guest PMU support In-Reply-To: <1441961715-11688-1-git-send-email-zhaoshenglong@huawei.com> References: <1441961715-11688-1-git-send-email-zhaoshenglong@huawei.com> Message-ID: <55F9D9FC.6010905@redhat.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 09/11/2015 03:54 AM, Shannon Zhao wrote: > From: Shannon Zhao > > This patchset adds guest PMU support for KVM on ARM64. It takes > trap-and-emulate approach. When guest wants to monitor one event, it > will be trapped by KVM and KVM will call perf_event API to create a perf > event and call relevant perf_event APIs to get the count value of event. > > Use perf to test this patchset in guest. When using "perf list", it > shows the list of the hardware events and hardware cache events perf > supports. Then use "perf stat -e EVENT" to monitor some event. For > example, use "perf stat -e cycles" to count cpu cycles and > "perf stat -e cache-misses" to count cache misses. > > Below are the outputs of "perf stat -r 5 sleep 5" when running in host > and guest. > > Host: > Performance counter stats for 'sleep 5' (5 runs): > > 0.551428 task-clock (msec) # 0.000 CPUs utilized ( +- 0.91% ) > 1 context-switches # 0.002 M/sec > 0 cpu-migrations # 0.000 K/sec > 48 page-faults # 0.088 M/sec ( +- 1.05% ) > 1150265 cycles # 2.086 GHz ( +- 0.92% ) > stalled-cycles-frontend > stalled-cycles-backend > 526398 instructions # 0.46 insns per cycle ( +- 0.89% ) > branches > 9485 branch-misses # 17.201 M/sec ( +- 2.35% ) > > 5.000831616 seconds time elapsed ( +- 0.00% ) > > Guest: > Performance counter stats for 'sleep 5' (5 runs): > > 0.730868 task-clock (msec) # 0.000 CPUs utilized ( +- 1.13% ) > 1 context-switches # 0.001 M/sec > 0 cpu-migrations # 0.000 K/sec > 48 page-faults # 0.065 M/sec ( +- 0.42% ) > 1642982 cycles # 2.248 GHz ( +- 1.04% ) > stalled-cycles-frontend > stalled-cycles-backend > 637964 instructions # 0.39 insns per cycle ( +- 0.65% ) > branches > 10377 branch-misses # 14.198 M/sec ( +- 1.09% ) > > 5.001289068 seconds time elapsed ( +- 0.00% ) > > This patchset can be fetched from [1] and the relevant QEMU version for > test can be fetched from [2]. > > Thanks, > Shannon > > [1] https://git.linaro.org/people/shannon.zhao/linux-mainline.git KVM_ARM64_PMU_v2 > [2] https://git.linaro.org/people/shannon.zhao/qemu.git PMU_v2 I am testing this series. The first question is: do you plan to add ACPI support in QEMU? My in-house kernel uses ACPI for device probing. I had to force "acpi=off" when I test this patch series. > > Shannon Zhao (22): > ARM64: Move PMU register related defines to asm/pmu.h > KVM: ARM64: Define PMU data structure for each vcpu > KVM: ARM64: Add offset defines for PMU registers > KVM: ARM64: Add reset and access handlers for PMCR_EL0 register > KVM: ARM64: Add a helper for CP15 registers reset to UNKNOWN > KVM: ARM64: Add reset and access handlers for PMSELR register > KVM: ARM64: Add reset and access handlers for PMCEID0 and PMCEID1 > register > KVM: ARM64: PMU: Add perf event map and introduce perf event creating > function > KVM: ARM64: Add reset and access handlers for PMXEVTYPER register > KVM: ARM64: Add reset and access handlers for PMXEVCNTR register > KVM: ARM64: Add reset and access handlers for PMCCNTR register > KVM: ARM64: Add reset and access handlers for PMCNTENSET and > PMCNTENCLR register > KVM: ARM64: Add reset and access handlers for PMINTENSET and > PMINTENCLR register > KVM: ARM64: Add reset and access handlers for PMOVSSET and PMOVSCLR > register > KVM: ARM64: Add a helper for CP15 registers reset to specified value > KVM: ARM64: Add reset and access handlers for PMUSERENR register > KVM: ARM64: Add reset and access handlers for PMSWINC register > KVM: ARM64: Add access handlers for PMEVCNTRn and PMEVTYPERn register > KVM: ARM64: Add PMU overflow interrupt routing > KVM: ARM64: Reset PMU state when resetting vcpu > KVM: ARM64: Free perf event of PMU when destroying vcpu > KVM: ARM64: Add a new kvm ARM PMU device > > Documentation/virtual/kvm/devices/arm-pmu.txt | 15 + > arch/arm/kvm/arm.c | 4 + > arch/arm64/include/asm/kvm_asm.h | 59 ++- > arch/arm64/include/asm/kvm_host.h | 2 + > arch/arm64/include/asm/pmu.h | 49 +++ > arch/arm64/include/uapi/asm/kvm.h | 3 + > arch/arm64/kernel/perf_event.c | 35 -- > arch/arm64/kvm/Kconfig | 8 + > arch/arm64/kvm/Makefile | 1 + > arch/arm64/kvm/reset.c | 3 + > arch/arm64/kvm/sys_regs.c | 490 +++++++++++++++++++++++-- > arch/arm64/kvm/sys_regs.h | 16 + > include/kvm/arm_pmu.h | 66 ++++ > include/linux/kvm_host.h | 1 + > include/uapi/linux/kvm.h | 2 + > virt/kvm/arm/pmu.c | 500 ++++++++++++++++++++++++++ > virt/kvm/kvm_main.c | 4 + > 17 files changed, 1188 insertions(+), 70 deletions(-) > create mode 100644 Documentation/virtual/kvm/devices/arm-pmu.txt > create mode 100644 include/kvm/arm_pmu.h > create mode 100644 virt/kvm/arm/pmu.c > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Huang Subject: Re: [PATCH v2 00/22] KVM: ARM64: Add guest PMU support Date: Wed, 16 Sep 2015 16:07:08 -0500 Message-ID: <55F9D9FC.6010905@redhat.com> References: <1441961715-11688-1-git-send-email-zhaoshenglong@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1441961715-11688-1-git-send-email-zhaoshenglong@huawei.com> Sender: kvm-owner@vger.kernel.org To: Shannon Zhao , kvmarm@lists.cs.columbia.edu Cc: linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, marc.zyngier@arm.com, christoffer.dall@linaro.org, will.deacon@arm.com, alex.bennee@linaro.org, shannon.zhao@linaro.org, peter.huangpeng@huawei.com List-Id: kvmarm@lists.cs.columbia.edu On 09/11/2015 03:54 AM, Shannon Zhao wrote: > From: Shannon Zhao > > This patchset adds guest PMU support for KVM on ARM64. It takes > trap-and-emulate approach. When guest wants to monitor one event, it > will be trapped by KVM and KVM will call perf_event API to create a perf > event and call relevant perf_event APIs to get the count value of event. > > Use perf to test this patchset in guest. When using "perf list", it > shows the list of the hardware events and hardware cache events perf > supports. Then use "perf stat -e EVENT" to monitor some event. For > example, use "perf stat -e cycles" to count cpu cycles and > "perf stat -e cache-misses" to count cache misses. > > Below are the outputs of "perf stat -r 5 sleep 5" when running in host > and guest. > > Host: > Performance counter stats for 'sleep 5' (5 runs): > > 0.551428 task-clock (msec) # 0.000 CPUs utilized ( +- 0.91% ) > 1 context-switches # 0.002 M/sec > 0 cpu-migrations # 0.000 K/sec > 48 page-faults # 0.088 M/sec ( +- 1.05% ) > 1150265 cycles # 2.086 GHz ( +- 0.92% ) > stalled-cycles-frontend > stalled-cycles-backend > 526398 instructions # 0.46 insns per cycle ( +- 0.89% ) > branches > 9485 branch-misses # 17.201 M/sec ( +- 2.35% ) > > 5.000831616 seconds time elapsed ( +- 0.00% ) > > Guest: > Performance counter stats for 'sleep 5' (5 runs): > > 0.730868 task-clock (msec) # 0.000 CPUs utilized ( +- 1.13% ) > 1 context-switches # 0.001 M/sec > 0 cpu-migrations # 0.000 K/sec > 48 page-faults # 0.065 M/sec ( +- 0.42% ) > 1642982 cycles # 2.248 GHz ( +- 1.04% ) > stalled-cycles-frontend > stalled-cycles-backend > 637964 instructions # 0.39 insns per cycle ( +- 0.65% ) > branches > 10377 branch-misses # 14.198 M/sec ( +- 1.09% ) > > 5.001289068 seconds time elapsed ( +- 0.00% ) > > This patchset can be fetched from [1] and the relevant QEMU version for > test can be fetched from [2]. > > Thanks, > Shannon > > [1] https://git.linaro.org/people/shannon.zhao/linux-mainline.git KVM_ARM64_PMU_v2 > [2] https://git.linaro.org/people/shannon.zhao/qemu.git PMU_v2 I am testing this series. The first question is: do you plan to add ACPI support in QEMU? My in-house kernel uses ACPI for device probing. I had to force "acpi=off" when I test this patch series. > > Shannon Zhao (22): > ARM64: Move PMU register related defines to asm/pmu.h > KVM: ARM64: Define PMU data structure for each vcpu > KVM: ARM64: Add offset defines for PMU registers > KVM: ARM64: Add reset and access handlers for PMCR_EL0 register > KVM: ARM64: Add a helper for CP15 registers reset to UNKNOWN > KVM: ARM64: Add reset and access handlers for PMSELR register > KVM: ARM64: Add reset and access handlers for PMCEID0 and PMCEID1 > register > KVM: ARM64: PMU: Add perf event map and introduce perf event creating > function > KVM: ARM64: Add reset and access handlers for PMXEVTYPER register > KVM: ARM64: Add reset and access handlers for PMXEVCNTR register > KVM: ARM64: Add reset and access handlers for PMCCNTR register > KVM: ARM64: Add reset and access handlers for PMCNTENSET and > PMCNTENCLR register > KVM: ARM64: Add reset and access handlers for PMINTENSET and > PMINTENCLR register > KVM: ARM64: Add reset and access handlers for PMOVSSET and PMOVSCLR > register > KVM: ARM64: Add a helper for CP15 registers reset to specified value > KVM: ARM64: Add reset and access handlers for PMUSERENR register > KVM: ARM64: Add reset and access handlers for PMSWINC register > KVM: ARM64: Add access handlers for PMEVCNTRn and PMEVTYPERn register > KVM: ARM64: Add PMU overflow interrupt routing > KVM: ARM64: Reset PMU state when resetting vcpu > KVM: ARM64: Free perf event of PMU when destroying vcpu > KVM: ARM64: Add a new kvm ARM PMU device > > Documentation/virtual/kvm/devices/arm-pmu.txt | 15 + > arch/arm/kvm/arm.c | 4 + > arch/arm64/include/asm/kvm_asm.h | 59 ++- > arch/arm64/include/asm/kvm_host.h | 2 + > arch/arm64/include/asm/pmu.h | 49 +++ > arch/arm64/include/uapi/asm/kvm.h | 3 + > arch/arm64/kernel/perf_event.c | 35 -- > arch/arm64/kvm/Kconfig | 8 + > arch/arm64/kvm/Makefile | 1 + > arch/arm64/kvm/reset.c | 3 + > arch/arm64/kvm/sys_regs.c | 490 +++++++++++++++++++++++-- > arch/arm64/kvm/sys_regs.h | 16 + > include/kvm/arm_pmu.h | 66 ++++ > include/linux/kvm_host.h | 1 + > include/uapi/linux/kvm.h | 2 + > virt/kvm/arm/pmu.c | 500 ++++++++++++++++++++++++++ > virt/kvm/kvm_main.c | 4 + > 17 files changed, 1188 insertions(+), 70 deletions(-) > create mode 100644 Documentation/virtual/kvm/devices/arm-pmu.txt > create mode 100644 include/kvm/arm_pmu.h > create mode 100644 virt/kvm/arm/pmu.c >