From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Cong Wang <cwang@twopensource.com>
Cc: Akshat Kakkar <akshat.1984@gmail.com>,
netdev <netdev@vger.kernel.org>,
Cong Wang <xiyou.wangcong@gmail.com>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [fw filter]: Broken! fw mark based tc class selection not working
Date: Thu, 17 Sep 2015 08:16:31 -0400 [thread overview]
Message-ID: <55FAAF1F.6000206@mojatatu.com> (raw)
In-Reply-To: <CAHA+R7NCn0OsLUdVZbvJ_B8tJGVJ9_Pys_FARPM2Z-xdS4-_Uw@mail.gmail.com>
On 09/14/15 18:04, Cong Wang wrote:
>
> That is exactly the original code. But it is not readable at all,
> at least I still missed it when I touched the tp->init() part. :(
> Having a boolean doesn't harm anything.
The default should really be no head alloced (given that is the
main use case).
The other part you can make more readable.
cheers,
jamal
prev parent reply other threads:[~2015-09-17 12:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 16:34 [fw filter]: Broken! fw mark based tc class selection not working Akshat Kakkar
2015-09-11 20:32 ` Cong Wang
2015-09-11 22:24 ` Akshat Kakkar
2015-09-12 0:00 ` Cong Wang
2015-09-14 12:28 ` Jamal Hadi Salim
2015-09-14 22:04 ` Cong Wang
2015-09-17 12:16 ` Jamal Hadi Salim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FAAF1F.6000206@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=akshat.1984@gmail.com \
--cc=cwang@twopensource.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.