From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Keir Fraser <keir@xen.org>, Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] xen/keyhandler: Rework keyhandler infrastructure
Date: Tue, 22 Sep 2015 12:10:35 +0100 [thread overview]
Message-ID: <5601372B.6080404@citrix.com> (raw)
In-Reply-To: <56014B2602000078000A4492@prv-mh.provo.novell.com>
On 22/09/15 11:35, Jan Beulich wrote:
>
>> --- a/xen/arch/x86/hvm/vmx/vmcs.c
>> +++ b/xen/arch/x86/hvm/vmx/vmcs.c
>> @@ -1858,15 +1858,9 @@ static void vmcs_dump(unsigned char ch)
>> printk("**************************************\n");
>> }
>>
>> -static struct keyhandler vmcs_dump_keyhandler = {
>> - .diagnostic = 1,
>> - .u.fn = vmcs_dump,
>> - .desc = "dump Intel's VMCS"
>> -};
>> -
>> void __init setup_vmcs_dump(void)
>> {
>> - register_keyhandler('v', &vmcs_dump_keyhandler);
>> + register_keyhandler('v', vmcs_dump, "dump Intel's VMCS", 1);
>> }
> Mind switching this from "Intel" to VMX as you go, considering that
> it's not just Intel using that structure?
I can certainly see about correcting some of the text. I suppose this
is a good time to make it all consistent.
>
>> +
>> + key_table[key] = k;
> I don't really see the value of the intermediate variable k here.
Nor me - I thing it might have been a way of how the patch developed.
>
>> @@ -1901,15 +1895,9 @@ static void dump_heap(unsigned char key)
>> }
>> }
>>
>> -static struct keyhandler dump_heap_keyhandler = {
>> - .diagnostic = 1,
>> - .u.fn = dump_heap,
>> - .desc = "dump heap info"
>> -};
>> -
>> static __init int register_heap_trigger(void)
>> {
>> - register_keyhandler('H', &dump_heap_keyhandler);
>> + register_keyhandler('H', dump_heap, "dump heap info", 1);
> Considering the other one in this file is "memory info", just
> "heap info" perhaps?
I will audit all the text in v2.
~Andrew
prev parent reply other threads:[~2015-09-22 11:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 13:49 [PATCH] xen/keyhandler: Rework keyhandler infrastructure Andrew Cooper
2015-09-22 10:35 ` Jan Beulich
2015-09-22 11:10 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5601372B.6080404@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.