From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Vladimir_'=cf=86-coder/phcoder'_Serbinenko?= Subject: Re: [PATCH v3 3/4] * util/grub.d/20_linux_xen.in: Add support of the XEN boot on aarch64 Date: Thu, 29 Oct 2015 16:25:38 +0100 Message-ID: <56323A72.3000905@gmail.com> References: <=fu.wei@linaro.org> <1437628583-23667-1-git-send-email-fu.wei@linaro.org> <1437628583-23667-4-git-send-email-fu.wei@linaro.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3379651579872740133==" Return-path: In-Reply-To: <1437628583-23667-4-git-send-email-fu.wei@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: fu.wei@linaro.org, grub-devel@gnu.org, arvidjaar@gmail.com Cc: xen-devel@lists.xensource.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, jcm@redhat.com, leif.lindholm@linaro.org, ryan.harkin@linaro.org, linaro-uefi@lists.linaro.org List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============3379651579872740133== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ijgqTQ8oVnfHe6HkwvF0uhpo4axrELrXQ" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ijgqTQ8oVnfHe6HkwvF0uhpo4axrELrXQ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable > +if [ "x$machine" !=3D xaarch64 ]; then > + multiboot_cmd=3D"multiboot" > + module_linux_cmd=3D"module" > + module_initrd_cmd=3D"module --nounzip" > +else > + multiboot_cmd=3D"xen_hypervisor" > + module_linux_cmd=3D"xen_linux" > + module_initrd_cmd=3D"xen_initrd" > +fi > + Please do not hardcode an assumption that grub-mkconfig is executed on the same machine as GRUB is booted. I know that we have instances of such assumption in some cases but we'd like to eliminate them. Alternativ= es: - Check arch on boot time - Check that new xen commands are supported (define a new feature) Please add xen_* aliases on x86 as well --ijgqTQ8oVnfHe6HkwvF0uhpo4axrELrXQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iF4EAREKAAYFAlYyOnIACgkQmBXlbbo5nOu4wgD/drM87iFnLsaX14sr05ZrT6JA 4V5j7Q2AbDWlSwxNszcBAKNlgG4k7a4fw+hPGAHoapS87rjrRdoJJM9ZJYWdoQmK =U10v -----END PGP SIGNATURE----- --ijgqTQ8oVnfHe6HkwvF0uhpo4axrELrXQ-- --===============3379651579872740133== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============3379651579872740133==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ZrpSe-0001Ur-9w for mharc-grub-devel@gnu.org; Thu, 29 Oct 2015 11:49:56 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50688) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZrpSZ-0001NG-7K for grub-devel@gnu.org; Thu, 29 Oct 2015 11:49:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZrpSY-0005kI-Eh for grub-devel@gnu.org; Thu, 29 Oct 2015 11:49:51 -0400 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:32920) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZrpSY-0005kB-1m for grub-devel@gnu.org; Thu, 29 Oct 2015 11:49:50 -0400 Received: by wmff134 with SMTP id f134so2373461wmf.0 for ; Thu, 29 Oct 2015 08:49:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type; bh=k14qTdbSVrbeM+Ijfq5Ze8WK0KvH6AGz7dE7oqnPfXU=; b=FFlZyOvagdgcPEUxdnwrFYb52ScIuT5oxDM+/RONNPDhLkMgHtjNs3/bFBsjSV6KDN ihKbKmGV3qAhF3tnlt8rUN43WqsliMRw8vqKhCB+h4b8MY6O7aowdw+X4Uy4AfEn3WfF YODAAIszp1HzkBRQoBxNAm0U8KPe/faJgrvRMn/wp2tDw7Ak5O8DVhjzhs/GMQ6FK5Om 2enV3GASUgyJGNIEQbA7QAC5nNiGIbCsYqjF74MzZHZwoCX640wTBbH320Pkg9fdWxag k60U8F5cGhOoZlcUsKNKUa5A5lRtNmD1Gk584d5nN+MM8MBUAKF8vyIQEaewK8PDxiRq 0S4Q== X-Received: by 10.28.55.146 with SMTP id e140mr6245198wma.1.1446132348093; Thu, 29 Oct 2015 08:25:48 -0700 (PDT) Received: from ?IPv6:2620:0:105f:fd00:863a:4bff:fe50:abc4? ([2620:0:105f:fd00:863a:4bff:fe50:abc4]) by smtp.gmail.com with ESMTPSA id lb2sm2323956wjc.15.2015.10.29.08.25.46 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Oct 2015 08:25:46 -0700 (PDT) Subject: Re: [PATCH v3 3/4] * util/grub.d/20_linux_xen.in: Add support of the XEN boot on aarch64 To: fu.wei@linaro.org, grub-devel@gnu.org, arvidjaar@gmail.com References: <=fu.wei@linaro.org> <1437628583-23667-1-git-send-email-fu.wei@linaro.org> <1437628583-23667-4-git-send-email-fu.wei@linaro.org> From: =?UTF-8?Q?Vladimir_'=cf=86-coder/phcoder'_Serbinenko?= Message-ID: <56323A72.3000905@gmail.com> Date: Thu, 29 Oct 2015 16:25:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.3.0 MIME-Version: 1.0 In-Reply-To: <1437628583-23667-4-git-send-email-fu.wei@linaro.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ijgqTQ8oVnfHe6HkwvF0uhpo4axrELrXQ" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c09::244 Cc: xen-devel@lists.xensource.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, jcm@redhat.com, leif.lindholm@linaro.org, ryan.harkin@linaro.org, linaro-uefi@lists.linaro.org X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Oct 2015 15:49:52 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ijgqTQ8oVnfHe6HkwvF0uhpo4axrELrXQ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable > +if [ "x$machine" !=3D xaarch64 ]; then > + multiboot_cmd=3D"multiboot" > + module_linux_cmd=3D"module" > + module_initrd_cmd=3D"module --nounzip" > +else > + multiboot_cmd=3D"xen_hypervisor" > + module_linux_cmd=3D"xen_linux" > + module_initrd_cmd=3D"xen_initrd" > +fi > + Please do not hardcode an assumption that grub-mkconfig is executed on the same machine as GRUB is booted. I know that we have instances of such assumption in some cases but we'd like to eliminate them. Alternativ= es: - Check arch on boot time - Check that new xen commands are supported (define a new feature) Please add xen_* aliases on x86 as well --ijgqTQ8oVnfHe6HkwvF0uhpo4axrELrXQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iF4EAREKAAYFAlYyOnIACgkQmBXlbbo5nOu4wgD/drM87iFnLsaX14sr05ZrT6JA 4V5j7Q2AbDWlSwxNszcBAKNlgG4k7a4fw+hPGAHoapS87rjrRdoJJM9ZJYWdoQmK =U10v -----END PGP SIGNATURE----- --ijgqTQ8oVnfHe6HkwvF0uhpo4axrELrXQ--