From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrei Borzenkov Subject: Re: [PATCH v3 3/4] * util/grub.d/20_linux_xen.in: Add support of the XEN boot on aarch64 Date: Thu, 29 Oct 2015 22:53:33 +0300 Message-ID: <5632793D.3070907@gmail.com> References: <=fu.wei@linaro.org> <1437628583-23667-1-git-send-email-fu.wei@linaro.org> <1437628583-23667-4-git-send-email-fu.wei@linaro.org> <56323A72.3000905@gmail.com> Reply-To: The development of GNU GRUB Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <56323A72.3000905@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: grub-devel-bounces+gcbgd-grub-devel=m.gmane.org@gnu.org Sender: grub-devel-bounces+gcbgd-grub-devel=m.gmane.org@gnu.org To: =?UTF-8?Q?Vladimir_'=cf=86-coder/phcoder'_Serbinenko?= , fu.wei@linaro.org, grub-devel@gnu.org Cc: xen-devel@lists.xensource.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, jcm@redhat.com, leif.lindholm@linaro.org, ryan.harkin@linaro.org, linaro-uefi@lists.linaro.org List-Id: xen-devel@lists.xenproject.org MjkuMTAuMjAxNSAxODoyNSwgVmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28g 0L/QuNGI0LXRgjoKPj4gK2lmIFsgIngkbWFjaGluZSIgIT0geGFhcmNoNjQgXTsgdGhlbgo+PiAr CW11bHRpYm9vdF9jbWQ9Im11bHRpYm9vdCIKPj4gKwltb2R1bGVfbGludXhfY21kPSJtb2R1bGUi Cj4+ICsJbW9kdWxlX2luaXRyZF9jbWQ9Im1vZHVsZSAtLW5vdW56aXAiCj4+ICtlbHNlCj4+ICsJ bXVsdGlib290X2NtZD0ieGVuX2h5cGVydmlzb3IiCj4+ICsJbW9kdWxlX2xpbnV4X2NtZD0ieGVu X2xpbnV4Igo+PiArCW1vZHVsZV9pbml0cmRfY21kPSJ4ZW5faW5pdHJkIgo+PiArZmkKPj4gKwo+ IFBsZWFzZSBkbyBub3QgaGFyZGNvZGUgYW4gYXNzdW1wdGlvbiB0aGF0IGdydWItbWtjb25maWcg aXMgZXhlY3V0ZWQgb24KPiB0aGUgc2FtZSBtYWNoaW5lIGFzIEdSVUIgaXMgYm9vdGVkLiBJIGtu b3cgdGhhdCB3ZSBoYXZlIGluc3RhbmNlcyBvZgo+IHN1Y2ggYXNzdW1wdGlvbiBpbiBzb21lIGNh c2VzIGJ1dCB3ZSdkIGxpa2UgdG8gZWxpbWluYXRlIHRoZW0uIEFsdGVybmF0aXZlczoKPiAtIENo ZWNrIGFyY2ggb24gYm9vdCB0aW1lCgpUaGlzIG1ha2VzIGl0IGV2ZW4gbW9yZSBkaWZmaWN1bHQg Zm9yIG9zLXByb2JlciB0byBwYXJzZSBncnViLmNmZy4gV2UgCm5lZWQgc29tZSBhbHRlcm5hdGl2 ZSBiZWZvcmUgZ29pbmcgdGhpcyByb3V0ZS4KCj4gLSBDaGVjayB0aGF0IG5ldyB4ZW4gY29tbWFu ZHMgYXJlIHN1cHBvcnRlZCAoZGVmaW5lIGEgbmV3IGZlYXR1cmUpCj4gUGxlYXNlIGFkZCB4ZW5f KiBhbGlhc2VzIG9uIHg4NiBhcyB3ZWxsCj4KPgoKWWVzLCB0aGF0J3MgYmV0dGVyLgoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KR3J1Yi1kZXZlbCBtYWls aW5nIGxpc3QKR3J1Yi1kZXZlbEBnbnUub3JnCmh0dHBzOi8vbGlzdHMuZ251Lm9yZy9tYWlsbWFu L2xpc3RpbmZvL2dydWItZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ZrtGW-0002el-Qh for mharc-grub-devel@gnu.org; Thu, 29 Oct 2015 15:53:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56805) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZrtGV-0002e4-1k for grub-devel@gnu.org; Thu, 29 Oct 2015 15:53:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZrtGR-00055M-RW for grub-devel@gnu.org; Thu, 29 Oct 2015 15:53:38 -0400 Received: from mail-lb0-x22d.google.com ([2a00:1450:4010:c04::22d]:36372) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZrtGR-00055F-Jn for grub-devel@gnu.org; Thu, 29 Oct 2015 15:53:35 -0400 Received: by lbjm5 with SMTP id m5so36460731lbj.3 for ; Thu, 29 Oct 2015 12:53:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=O2AITzEL+VM8Gw/eQxw8OwZUz5QVJgdD3D1NCRhH5qc=; b=Hn5Cq1E0Yt1Z+aCLD06VxtM/LCLDZvz/KbQJEnH3KhNVhH4MVU2HqArhwYvzb22kMp 8gvE2ExrTWMNRegwgQJlwQncdn4l03s3EX8psXCX4ZTyGROMqtELIR+RTkzuCb7x9034 dKYJNRXUJ/naeKWXo5+9FePj8hGlraM3JFmsIYXEh484L+lbgYiMrTyzl+ukJgQBgzVG P6B4RT3OLickBQU+y2nzxhxpOJNHJ+UF3DuoZfXdEJRrLYNg350sdCeZwHncQil3ekXl cDhYHA1HRq5/pMbISQwJ45dbCcfVn5RqomwJmtyGnjdzFmUhgB6ACfiE46sjF2tReKmi P+RA== X-Received: by 10.112.13.226 with SMTP id k2mr1955114lbc.89.1446148414912; Thu, 29 Oct 2015 12:53:34 -0700 (PDT) Received: from [192.168.1.41] (ppp91-76-25-247.pppoe.mtu-net.ru. [91.76.25.247]) by smtp.gmail.com with ESMTPSA id k186sm606867lfg.8.2015.10.29.12.53.33 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Oct 2015 12:53:34 -0700 (PDT) Subject: Re: [PATCH v3 3/4] * util/grub.d/20_linux_xen.in: Add support of the XEN boot on aarch64 To: =?UTF-8?Q?Vladimir_'=cf=86-coder/phcoder'_Serbinenko?= , fu.wei@linaro.org, grub-devel@gnu.org References: <=fu.wei@linaro.org> <1437628583-23667-1-git-send-email-fu.wei@linaro.org> <1437628583-23667-4-git-send-email-fu.wei@linaro.org> <56323A72.3000905@gmail.com> From: Andrei Borzenkov Message-ID: <5632793D.3070907@gmail.com> Date: Thu, 29 Oct 2015 22:53:33 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <56323A72.3000905@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::22d Cc: xen-devel@lists.xensource.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com, jcm@redhat.com, leif.lindholm@linaro.org, ryan.harkin@linaro.org, linaro-uefi@lists.linaro.org X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Oct 2015 19:53:39 -0000 29.10.2015 18:25, Vladimir 'φ-coder/phcoder' Serbinenko пишет: >> +if [ "x$machine" != xaarch64 ]; then >> + multiboot_cmd="multiboot" >> + module_linux_cmd="module" >> + module_initrd_cmd="module --nounzip" >> +else >> + multiboot_cmd="xen_hypervisor" >> + module_linux_cmd="xen_linux" >> + module_initrd_cmd="xen_initrd" >> +fi >> + > Please do not hardcode an assumption that grub-mkconfig is executed on > the same machine as GRUB is booted. I know that we have instances of > such assumption in some cases but we'd like to eliminate them. Alternatives: > - Check arch on boot time This makes it even more difficult for os-prober to parse grub.cfg. We need some alternative before going this route. > - Check that new xen commands are supported (define a new feature) > Please add xen_* aliases on x86 as well > > Yes, that's better.