From: Richard Henderson <richard.henderson@linaro.org>
To: Alexandra Diupina <adiupina@astralinux.ru>,
Alistair Francis <alistair@alistair23.me>
Cc: "Konrad, Frederic" <Frederic.Konrad@amd.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org,
sdl.qemu@linuxtesting.org
Subject: Re: [PATCH v3] fix endianness bug
Date: Thu, 25 Apr 2024 08:24:53 -0700 [thread overview]
Message-ID: <56479506-9e30-4003-9153-db6ef19ecea0@linaro.org> (raw)
In-Reply-To: <20240425134115.32057-1-adiupina@astralinux.ru>
On 4/25/24 06:41, Alexandra Diupina wrote:
> +static MemTxResult xlnx_dpdma_read_descriptor(XlnxDPDMAState *s,
> + uint64_t desc_addr, DPDMADescriptor *desc)
> +{
> + if (dma_memory_read(&address_space_memory, desc_addr, &desc,
> + sizeof(DPDMADescriptor), MEMTXATTRS_UNSPECIFIED))
> + return MEMTX_ERROR;
> +
Missing { } for docs/devel/style.rst.
> +static void xlnx_dpdma_write_descriptor(uint64_t desc_addr,
> + DPDMADescriptor *desc)
> +{
> + /* Convert from host endianness into LE. */
> + desc->control = cpu_to_le32(desc->control);
> + desc->descriptor_id = cpu_to_le32(desc->descriptor_id);
> + desc->xfer_size = cpu_to_le32(desc->xfer_size);
> + desc->line_size_stride = cpu_to_le32(desc->line_size_stride);
> + desc->timestamp_lsb = cpu_to_le32(desc->timestamp_lsb);
> + desc->timestamp_msb = cpu_to_le32(desc->timestamp_msb);
> + desc->address_extension = cpu_to_le32(desc->address_extension);
> + desc->next_descriptor = cpu_to_le32(desc->next_descriptor);
> + desc->source_address = cpu_to_le32(desc->source_address);
> + desc->address_extension_23 = cpu_to_le32(desc->address_extension_23);
> + desc->address_extension_45 = cpu_to_le32(desc->address_extension_45);
> + desc->source_address2 = cpu_to_le32(desc->source_address2);
> + desc->source_address3 = cpu_to_le32(desc->source_address3);
> + desc->source_address4 = cpu_to_le32(desc->source_address4);
> + desc->source_address5 = cpu_to_le32(desc->source_address5);
> + desc->crc = cpu_to_le32(desc->crc);
This is incorrect, rewriting in place, because after the call,
> if (xlnx_dpdma_desc_completion_interrupt(&desc)) {
the memory block is still live, and the swap here has corrupted it.
> +
> + dma_memory_write(&address_space_memory, desc_addr, &desc,
This is incorrect because desc is now a pointer so &desc is DPDMADescriptor **.
Do not reply to an existing thread to post a new patch.
r~
next prev parent reply other threads:[~2024-04-25 15:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 8:13 [PATCH RFC] prevent overflow in xlnx_dpdma_desc_get_source_address() Alexandra Diupina
2024-04-12 10:06 ` Peter Maydell
2024-04-16 17:56 ` Alexandra Diupina
2024-04-16 18:30 ` Edgar E. Iglesias
2024-04-17 10:05 ` Konrad, Frederic
2024-04-23 10:23 ` Alexandra Diupina
2024-04-23 10:51 ` Peter Maydell
2024-04-24 12:53 ` [PATCH v2 RFC] fix host-endianness bug and prevent overflow Alexandra Diupina
2024-04-24 16:04 ` Peter Maydell
2024-04-24 18:13 ` [PATCH] fix host-endianness bug Alexandra Diupina
2024-04-25 9:26 ` Peter Maydell
2024-04-25 10:07 ` [PATCH v2] " Alexandra Diupina
2024-04-25 10:42 ` Philippe Mathieu-Daudé
2024-04-25 13:41 ` [PATCH v3] fix endianness bug Alexandra Diupina
2024-04-25 15:24 ` Richard Henderson [this message]
2024-04-24 18:13 ` [PATCH] fix bit fields extraction and prevent overflow Alexandra Diupina
2024-04-25 19:25 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56479506-9e30-4003-9153-db6ef19ecea0@linaro.org \
--to=richard.henderson@linaro.org \
--cc=Frederic.Konrad@amd.com \
--cc=adiupina@astralinux.ru \
--cc=alistair@alistair23.me \
--cc=edgar.iglesias@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sdl.qemu@linuxtesting.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.