From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752328AbbKYQCs (ORCPT ); Wed, 25 Nov 2015 11:02:48 -0500 Received: from mga11.intel.com ([192.55.52.93]:65126 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751065AbbKYQCp (ORCPT ); Wed, 25 Nov 2015 11:02:45 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,343,1444719600"; d="scan'208";a="606990627" Subject: Re: [RFC PATCH V2 3/3] Ixgbevf: Add migration support for ixgbevf driver To: "Michael S. Tsirkin" References: <1448372298-28386-1-git-send-email-tianyu.lan@intel.com> <1448372298-28386-4-git-send-email-tianyu.lan@intel.com> <20151124230551-mutt-send-email-mst@redhat.com> <56554994.1090305@intel.com> <20151125142437-mutt-send-email-mst@redhat.com> Cc: a.motakis@virtualopensystems.com, alex.williamson@redhat.com, b.reynal@virtualopensystems.com, bhelgaas@google.com, carolyn.wyborny@intel.com, donald.c.skidmore@intel.com, eddie.dong@intel.com, nrupal.jani@intel.com, agraf@suse.de, kvm@vger.kernel.org, pbonzini@redhat.com, qemu-devel@nongnu.org, emil.s.tantilov@intel.com, gerlitz.or@gmail.com, mark.d.rustad@intel.com, eric.auger@linaro.org, intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com, jesse.brandeburg@intel.com, john.ronciak@intel.com, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, matthew.vick@intel.com, mitch.a.williams@intel.com, netdev@vger.kernel.org, shannon.nelson@intel.com, weiyang@linux.vnet.ibm.com, zajec5@gmail.com From: "Lan, Tianyu" Message-ID: <5655DB99.3040007@intel.com> Date: Thu, 26 Nov 2015 00:02:33 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151125142437-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/25/2015 8:28 PM, Michael S. Tsirkin wrote: > Frankly, I don't really see what this short term hack buys us, > and if it goes in, we'll have to maintain it forever. > The framework of how to notify VF about migration status won't be changed regardless of stopping VF or not before doing migration. We hope to reach agreement on this first. Tracking dirty memory still need to more discussions and we will continue working on it. Stop VF may help to work around the issue and make tracking easier. > Also, assuming you just want to do ifdown/ifup for some reason, it's > easy enough to do using a guest agent, in a completely generic way. > Just ifdown/ifup is not enough for migration. It needs to restore some PCI settings before doing ifup on the target machine From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48288) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1cWv-0005hn-AS for qemu-devel@nongnu.org; Wed, 25 Nov 2015 11:02:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1cWs-0001g7-3D for qemu-devel@nongnu.org; Wed, 25 Nov 2015 11:02:49 -0500 Received: from mga11.intel.com ([192.55.52.93]:57099) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1cWr-0001fb-TG for qemu-devel@nongnu.org; Wed, 25 Nov 2015 11:02:46 -0500 References: <1448372298-28386-1-git-send-email-tianyu.lan@intel.com> <1448372298-28386-4-git-send-email-tianyu.lan@intel.com> <20151124230551-mutt-send-email-mst@redhat.com> <56554994.1090305@intel.com> <20151125142437-mutt-send-email-mst@redhat.com> From: "Lan, Tianyu" Message-ID: <5655DB99.3040007@intel.com> Date: Thu, 26 Nov 2015 00:02:33 +0800 MIME-Version: 1.0 In-Reply-To: <20151125142437-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH V2 3/3] Ixgbevf: Add migration support for ixgbevf driver List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: weiyang@linux.vnet.ibm.com, emil.s.tantilov@intel.com, kvm@vger.kernel.org, qemu-devel@nongnu.org, jesse.brandeburg@intel.com, mark.d.rustad@intel.com, carolyn.wyborny@intel.com, eric.auger@linaro.org, donald.c.skidmore@intel.com, zajec5@gmail.com, agraf@suse.de, matthew.vick@intel.com, intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com, gerlitz.or@gmail.com, mitch.a.williams@intel.com, nrupal.jani@intel.com, bhelgaas@google.com, a.motakis@virtualopensystems.com, b.reynal@virtualopensystems.com, linux-api@vger.kernel.org, shannon.nelson@intel.com, eddie.dong@intel.com, alex.williamson@redhat.com, linux-kernel@vger.kernel.org, john.ronciak@intel.com, netdev@vger.kernel.org, pbonzini@redhat.com On 11/25/2015 8:28 PM, Michael S. Tsirkin wrote: > Frankly, I don't really see what this short term hack buys us, > and if it goes in, we'll have to maintain it forever. > The framework of how to notify VF about migration status won't be changed regardless of stopping VF or not before doing migration. We hope to reach agreement on this first. Tracking dirty memory still need to more discussions and we will continue working on it. Stop VF may help to work around the issue and make tracking easier. > Also, assuming you just want to do ifdown/ifup for some reason, it's > easy enough to do using a guest agent, in a completely generic way. > Just ifdown/ifup is not enough for migration. It needs to restore some PCI settings before doing ifup on the target machine From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Lan, Tianyu" Subject: Re: [RFC PATCH V2 3/3] Ixgbevf: Add migration support for ixgbevf driver Date: Thu, 26 Nov 2015 00:02:33 +0800 Message-ID: <5655DB99.3040007@intel.com> References: <1448372298-28386-1-git-send-email-tianyu.lan@intel.com> <1448372298-28386-4-git-send-email-tianyu.lan@intel.com> <20151124230551-mutt-send-email-mst@redhat.com> <56554994.1090305@intel.com> <20151125142437-mutt-send-email-mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: a.motakis-lrHrjnjw1UfHK3s98zE1ajGjJy/sRE9J@public.gmane.org, alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, b.reynal-lrHrjnjw1UfHK3s98zE1ajGjJy/sRE9J@public.gmane.org, bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, carolyn.wyborny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, donald.c.skidmore-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, eddie.dong-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, nrupal.jani-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, agraf-l3A5Bk7waGM@public.gmane.org, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org, emil.s.tantilov-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, gerlitz.or-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, mark.d.rustad-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, eric.auger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, intel-wired-lan-qjLDD68F18P21nG7glBr7A@public.gmane.org, jeffrey.t.kirsher-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, jesse.brandeburg-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, john.ronciak-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, matthew.vick-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, mitch.a.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, shannon.nelson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, weiyang-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org To: "Michael S. Tsirkin" Return-path: In-Reply-To: <20151125142437-mutt-send-email-mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On 11/25/2015 8:28 PM, Michael S. Tsirkin wrote: > Frankly, I don't really see what this short term hack buys us, > and if it goes in, we'll have to maintain it forever. > The framework of how to notify VF about migration status won't be changed regardless of stopping VF or not before doing migration. We hope to reach agreement on this first. Tracking dirty memory still need to more discussions and we will continue working on it. Stop VF may help to work around the issue and make tracking easier. > Also, assuming you just want to do ifdown/ifup for some reason, it's > easy enough to do using a guest agent, in a completely generic way. > Just ifdown/ifup is not enough for migration. It needs to restore some PCI settings before doing ifup on the target machine From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lan, Tianyu Date: Thu, 26 Nov 2015 00:02:33 +0800 Subject: [Intel-wired-lan] [RFC PATCH V2 3/3] Ixgbevf: Add migration support for ixgbevf driver In-Reply-To: <20151125142437-mutt-send-email-mst@redhat.com> References: <1448372298-28386-1-git-send-email-tianyu.lan@intel.com> <1448372298-28386-4-git-send-email-tianyu.lan@intel.com> <20151124230551-mutt-send-email-mst@redhat.com> <56554994.1090305@intel.com> <20151125142437-mutt-send-email-mst@redhat.com> Message-ID: <5655DB99.3040007@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On 11/25/2015 8:28 PM, Michael S. Tsirkin wrote: > Frankly, I don't really see what this short term hack buys us, > and if it goes in, we'll have to maintain it forever. > The framework of how to notify VF about migration status won't be changed regardless of stopping VF or not before doing migration. We hope to reach agreement on this first. Tracking dirty memory still need to more discussions and we will continue working on it. Stop VF may help to work around the issue and make tracking easier. > Also, assuming you just want to do ifdown/ifup for some reason, it's > easy enough to do using a guest agent, in a completely generic way. > Just ifdown/ifup is not enough for migration. It needs to restore some PCI settings before doing ifup on the target machine