From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754616AbbLIKcG (ORCPT ); Wed, 9 Dec 2015 05:32:06 -0500 Received: from szxga03-in.huawei.com ([119.145.14.66]:27216 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754172AbbLIKcA (ORCPT ); Wed, 9 Dec 2015 05:32:00 -0500 Subject: Re: [PATCH] ACPI: Add phylib support code for mdio To: Al Stone , Graeme Gregory References: <1449107683-69717-1-git-send-email-yankejian@huawei.com> <20151203104724.GB11655@xora-haswell.xora.org.uk> <566735CF.30000@redhat.com> CC: , , , , , , , , , From: "Yankejian (Hackim Yim)" Message-ID: <566802F0.2020103@huawei.com> Date: Wed, 9 Dec 2015 18:31:12 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <566735CF.30000@redhat.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.57.126.191] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020206.566802FD.0150,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 34b095b1fe780fe661077ddb1fbb7776 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/12/9 3:55, Al Stone wrote: > On 12/03/2015 03:47 AM, Graeme Gregory wrote: >> On Thu, Dec 03, 2015 at 09:54:43AM +0800, yankejian wrote: >>> Add support for getting the PHY devices on an MDIO bus by ACPI. >>> Currently many of the ethernet drivers are open coding a solution >>> for reading data out of ACPI to find the correct PHY device. >>> This patch implements a set of common routines are similar to of_mdio.c >>> >> The general conclusion for the ACPI on ARM64 discussion so far has been that >> things like PHYs should be setup by the firmware before the kernel takes >> control. >> >> I am unsure that this doing it the same way as DT with a different >> description language is the way to go. >> >> Graeme > I have to agree with Graeme: if this is supposed to be an arm64 server using > ACPI, please make sure the PHYs/clocks/regulators are set up properly before > passing control to the kernel. That's the consensus so far on how this is to > be done. > > This also looks to be using _DSD in ACPI, which is another topic that's still > under discussion. What does the ASL look like for these PHYs, as used in this > patch? > Hi Al The sample of the ASL for these PHYs is below: Device (PHY0) { Name (_DSD, Package () { ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), Package () { Package () {"phy-addr", 0}, Package () {"ethernet-phy", "ethernet-phy-ieee802.3-c22"}, } }) } Best Regards, yankejian From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Yankejian (Hackim Yim)" Subject: Re: [PATCH] ACPI: Add phylib support code for mdio Date: Wed, 9 Dec 2015 18:31:12 +0800 Message-ID: <566802F0.2020103@huawei.com> References: <1449107683-69717-1-git-send-email-yankejian@huawei.com> <20151203104724.GB11655@xora-haswell.xora.org.uk> <566735CF.30000@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <566735CF.30000@redhat.com> Sender: linux-kernel-owner@vger.kernel.org To: Al Stone , Graeme Gregory Cc: rjw@rjwysocki.net, lenb@kernel.org, davem@davemloft.net, liguozhu@huawei.com, yisen.zhuang@huawei.com, huangdaode@hisilicon.com, lipeng321@huawei.com, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linuxarm@huawei.com List-Id: linux-acpi@vger.kernel.org On 2015/12/9 3:55, Al Stone wrote: > On 12/03/2015 03:47 AM, Graeme Gregory wrote: >> On Thu, Dec 03, 2015 at 09:54:43AM +0800, yankejian wrote: >>> Add support for getting the PHY devices on an MDIO bus by ACPI. >>> Currently many of the ethernet drivers are open coding a solution >>> for reading data out of ACPI to find the correct PHY device. >>> This patch implements a set of common routines are similar to of_mdio.c >>> >> The general conclusion for the ACPI on ARM64 discussion so far has been that >> things like PHYs should be setup by the firmware before the kernel takes >> control. >> >> I am unsure that this doing it the same way as DT with a different >> description language is the way to go. >> >> Graeme > I have to agree with Graeme: if this is supposed to be an arm64 server using > ACPI, please make sure the PHYs/clocks/regulators are set up properly before > passing control to the kernel. That's the consensus so far on how this is to > be done. > > This also looks to be using _DSD in ACPI, which is another topic that's still > under discussion. What does the ASL look like for these PHYs, as used in this > patch? > Hi Al The sample of the ASL for these PHYs is below: Device (PHY0) { Name (_DSD, Package () { ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), Package () { Package () {"phy-addr", 0}, Package () {"ethernet-phy", "ethernet-phy-ieee802.3-c22"}, } }) } Best Regards, yankejian