From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Dooks Subject: Re: [PATCH] gpio: pca953x: make inclusion of unconditional Date: Wed, 9 Dec 2015 10:53:36 +0000 Message-ID: <56680830.8010607@codethink.co.uk> References: <1449655574-6550-1-git-send-email-linus.walleij@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from ducie-dc1.codethink.co.uk ([185.25.241.215]:37274 "EHLO ducie-dc1.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752281AbbLIKxn (ORCPT ); Wed, 9 Dec 2015 05:53:43 -0500 In-Reply-To: <1449655574-6550-1-git-send-email-linus.walleij@linaro.org> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Linus Walleij , linux-gpio@vger.kernel.org, Alexandre Courbot On 09/12/15 10:06, Linus Walleij wrote: > After adding the DT matching in > commit 6f29c9afbe636fc0e35c82a11eaf45c3b85eb07a > "gpio: pca935x: fix of-only probed devices" > compilation fails like this: >=20 > CC [M] drivers/gpio/gpio-pca953x.o > gpio-pca953x.c: In function =E2=80=98pca953x_probe=E2=80=99: > gpio-pca953x.c:693:11: error: implicit declaration of > function =E2=80=98of_match_device=E2=80=99 [-Werror=3Dimplicit-functi= on-declaration] > match =3D of_match_device(pca953x_dt_ids, &client->dev); Thanks, given the driver makes no other attempt to remove OF lists if there is no OF present then this may as well be unconditionally included. --=20 Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html