From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753662AbbLISQs (ORCPT ); Wed, 9 Dec 2015 13:16:48 -0500 Received: from foss.arm.com ([217.140.101.70]:51236 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753621AbbLISQq (ORCPT ); Wed, 9 Dec 2015 13:16:46 -0500 Message-ID: <56687008.3020703@arm.com> Date: Wed, 09 Dec 2015 18:16:40 +0000 From: Marc Zyngier Organization: ARM Ltd User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Suravee Suthikulanit CC: tglx@linutronix.de, jason@lakedaemon.net, rjw@rjwysocki.net, Lorenzo Pieralisi , Will Deacon , Catalin Marinas , hanjun.guo@linaro.org, tomasz.nowicki@linaro.org, graeme.gregory@linaro.org, dhdang@apm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v5 5/5] gicv2m: acpi: Introducing GICv2m ACPI support References: <1449625686-5594-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1449625686-5594-6-git-send-email-Suravee.Suthikulpanit@amd.com> <20151209103806.41488405@why.wild-wind.fr.eu.org> <56686C9F.6060804@amd.com> In-Reply-To: <56686C9F.6060804@amd.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/12/15 18:02, Suravee Suthikulanit wrote: > Hi Marc, > > On 12/9/2015 4:38 AM, Marc Zyngier wrote: >> On Tue, 8 Dec 2015 17:48:06 -0800 >> Suravee Suthikulpanit wrote: >> >>> This patch introduces gicv2m_acpi_init(), which uses information >>> in MADT GIC MSI frames structure to initialize GICv2m driver. >>> >>> Signed-off-by: Suravee Suthikulpanit >>> Signed-off-by: Hanjun Guo >>> --- >>> drivers/irqchip/irq-gic-v2m.c | 95 +++++++++++++++++++++++++++++++++++++++++ >>> drivers/irqchip/irq-gic.c | 3 ++ >>> include/linux/irqchip/arm-gic.h | 4 ++ >>> 3 files changed, 102 insertions(+) >>> >>> diff --git a/drivers/irqchip/irq-gic-v2m.c b/drivers/irqchip/irq-gic-v2m.c >>> [...] >>> @@ -359,6 +368,8 @@ static int __init gicv2m_init_one(struct fwnode_handle *fwnode, >>> >>> if (to_of_node(fwnode)) >>> name = to_of_node(fwnode)->name; >>> + else >>> + name = irq_domain_get_irqchip_fwnode_name(fwnode); >> >> Don't bother with that, the name associated with the domain is >> absolutely meaningless. You are already printing the frame address, >> which is enough to identify it, should someone need to debug this. >> >> Drop the name from the previous patch as well, and that will make one >> less difference to care about. Patch #3 can die as well. >> > > Ok. I'll just leave them blank (i.e. const char *name ="") No, just remove name altogether. Nobody reads that anyway, and if they want to find out, there is the address that's clear enough. Thanks, M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 From: marc.zyngier@arm.com (Marc Zyngier) Date: Wed, 09 Dec 2015 18:16:40 +0000 Subject: [PATCH v5 5/5] gicv2m: acpi: Introducing GICv2m ACPI support In-Reply-To: <56686C9F.6060804@amd.com> References: <1449625686-5594-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1449625686-5594-6-git-send-email-Suravee.Suthikulpanit@amd.com> <20151209103806.41488405@why.wild-wind.fr.eu.org> <56686C9F.6060804@amd.com> Message-ID: <56687008.3020703@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 09/12/15 18:02, Suravee Suthikulanit wrote: > Hi Marc, > > On 12/9/2015 4:38 AM, Marc Zyngier wrote: >> On Tue, 8 Dec 2015 17:48:06 -0800 >> Suravee Suthikulpanit wrote: >> >>> This patch introduces gicv2m_acpi_init(), which uses information >>> in MADT GIC MSI frames structure to initialize GICv2m driver. >>> >>> Signed-off-by: Suravee Suthikulpanit >>> Signed-off-by: Hanjun Guo >>> --- >>> drivers/irqchip/irq-gic-v2m.c | 95 +++++++++++++++++++++++++++++++++++++++++ >>> drivers/irqchip/irq-gic.c | 3 ++ >>> include/linux/irqchip/arm-gic.h | 4 ++ >>> 3 files changed, 102 insertions(+) >>> >>> diff --git a/drivers/irqchip/irq-gic-v2m.c b/drivers/irqchip/irq-gic-v2m.c >>> [...] >>> @@ -359,6 +368,8 @@ static int __init gicv2m_init_one(struct fwnode_handle *fwnode, >>> >>> if (to_of_node(fwnode)) >>> name = to_of_node(fwnode)->name; >>> + else >>> + name = irq_domain_get_irqchip_fwnode_name(fwnode); >> >> Don't bother with that, the name associated with the domain is >> absolutely meaningless. You are already printing the frame address, >> which is enough to identify it, should someone need to debug this. >> >> Drop the name from the previous patch as well, and that will make one >> less difference to care about. Patch #3 can die as well. >> > > Ok. I'll just leave them blank (i.e. const char *name ="") No, just remove name altogether. Nobody reads that anyway, and if they want to find out, there is the address that's clear enough. Thanks, M. -- Jazz is not dead. It just smells funny...