From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753396AbbLISvm (ORCPT ); Wed, 9 Dec 2015 13:51:42 -0500 Received: from mail-by2on0086.outbound.protection.outlook.com ([207.46.100.86]:45296 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753280AbbLISvk (ORCPT ); Wed, 9 Dec 2015 13:51:40 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Suravee.Suthikulpanit@amd.com; Subject: Re: [PATCH v5 5/5] gicv2m: acpi: Introducing GICv2m ACPI support To: Marc Zyngier References: <1449625686-5594-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1449625686-5594-6-git-send-email-Suravee.Suthikulpanit@amd.com> <20151209103806.41488405@why.wild-wind.fr.eu.org> <56686C9F.6060804@amd.com> <56687008.3020703@arm.com> CC: , , , Lorenzo Pieralisi , Will Deacon , Catalin Marinas , , , , , , , From: Suravee Suthikulanit Message-ID: <56687833.6040706@amd.com> Date: Wed, 9 Dec 2015 12:51:31 -0600 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <56687008.3020703@arm.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SN2PR10CA0033.namprd10.prod.outlook.com (25.160.12.171) To BY1PR12MB0440.namprd12.prod.outlook.com (25.162.147.141) X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0440;2:CAzUVJZQfF3g319Rgywkf+5sPmGBrR6EpucxfInod6yMCi17wV7VSShLzNeS9KF2r7Pvn+zzIZaNfDToVXlT3KOseWZxy5WO/o7Xo0QTQhAERN3906HyG14Gfo5xHT2KR0dJAGmAaVzRPdh/PrVl9A==;3:XkmZ6HM8ipjoxjruZVlZBbQfeqJyBUh0Mk6F1F+vd3Misyt0E5Waxz9YcLiJcrdaZKMHI6uhEjz2Pg/xDfDplQLkKgqXRGcDzbc5zB/5nvkwPsrNipNH1dyv2rBoziKi;25:Sn8Nc1V9eLLQSxUI5Crh2rSsqQ2/mwJRtGkoWlyCfsLCoDervrshL9XGOU0CYCVb+L7nQyVeEf4x7ibH9y6PHN3206ups42SL/7NjCa2jL41YZQkQZb6nlaxxpyN8edRN+W+4pFR4zldl21CjtsQ2sfTznewGqEcrizom9ufLTugaXbq3MnsLO+M2ar0k1j3iVKfSF/3xW/+b3SVbAbAI8Bv8hBvfw+U4OAwSvHM32uM/EAkb5xSkdyp+DPA8ZAVWH4e8/hnw2Hxe1XLH5wODA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR12MB0440; X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0440;20:OA/FYza7S84oyRgSW9ApBF0SjjlkIr8OfakBi7nXCucf0l+XmCaxGBYaRPfcejNXoH40bBdAmE/x/2C2j8iNbOmj29Bm0BdssmbuDoqunYalVwuNF2m7TCuhtir5VAYbdBzHAz3yjfEflPkpFmUjDDvQVB4sCAkEIqpk2AQfzUjDRTk+AyPEvc0o1hRM/DaKBmf0TbFN5Xl0cOfDBqb+OxCRwRKVAOK+XTPCo70VsGDaMRbg+IZfk5ara5Iwzr6dk+xyjz+fQCmzmRfE5Qbfu0C89x25CNZ7Uz+5c1lSXJIRBc3eaOy8hmzkYjsU7Bii1IrTUTBqjJTOOSubDbnv8MAdkUKkRG/c50BOazKcqVX5l3FxWUsl5nuhxT0I0/EeDcF+3FYFaCqGjhaXSgnvaaIwjFJ+r1jSr3EETEe7dtIYZDu8vSZ6irCq40vBMUiBXOrTr/VmbupxwAbUZMX/fNGPRXuNP+8Vj9qwGRGvJl96l9AqigN7hAkbLHaxrvZz;4:9KHz2ilZZWiUzcjKcWM56E6bLvV16IDMQ2j9Ydw9Y7uGHprTdnAvQ2sxnMDlDbkrNLaXpzkXL5XaA1A9CYfhEo4WSkkIa2Gek/vIsS/vOo5PN2WX7vhp/SSgkMjVmAFGQuQZZflSoRDbWLUdnb4AnMKXlJuoVFyylz8lpFTUzf3JMUECoOorsuPVtJuWKe66QKP8idNWh38tN8BiBqwdfRm2O6RNlyecYRkKM1nueBOCX2hsTweWOkwg5jlg89CJ6tWVB43M3xEdYeWtQTTQqfNJLKLcrSk5fpV07SQpUHHDuK3jEYoOwdAVrrAWa19PEjmDb8vIpzuBbL2FMtmZtjV3jXHx88eRiYmeGsN5WTLI1BNP5xk2W3KOup9DVZEC X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(8121501046)(5005006)(3002001)(10201501046);SRVR:BY1PR12MB0440;BCL:0;PCL:0;RULEID:;SRVR:BY1PR12MB0440; X-Forefront-PRVS: 0785459C39 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(979002)(6049001)(6009001)(377454003)(199003)(52314003)(164054003)(24454002)(479174004)(189002)(122386002)(2950100001)(87976001)(230700001)(36756003)(189998001)(50466002)(81156007)(6116002)(86362001)(76176999)(586003)(40100003)(110136002)(5001960100002)(3846002)(99136001)(83506001)(77096005)(47776003)(42186005)(4001350100001)(92566002)(65956001)(87266999)(1096002)(93886004)(59896002)(65816999)(5008740100001)(54356999)(50986999)(5004730100002)(117636001)(64126003)(23746002)(65806001)(106356001)(105586002)(97736004)(66066001)(101416001)(62816006)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR12MB0440;H:[10.236.18.83];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BY1PR12MB0440;23:XDmrVyZxfRIZc3Qf1mXp5Nz4LLXJVBzwcegjO?= =?Windows-1252?Q?YEy7NeYy04ozaT5AGL/Qd8hUz77pYlvnSyzRrYtJM/jrdzMvjWrKsr4S?= =?Windows-1252?Q?KVftT7LL2KtBiJe8PfgmbIZ6A8bxTo2A9zcAliqPgrIV+g7/Uw0ZjLy3?= =?Windows-1252?Q?IVlpOIAywJ0P/3P4viNkIZCecklzEq4BZAQvm9UISrQDv24pVOMuT3Di?= =?Windows-1252?Q?G4VnJRucr7mXn8HpMrkm7AfnLmE+U4PucscuISAV9fk+Wk4rpYaSxdVr?= =?Windows-1252?Q?bwUiVOZbFoPkpxpI23gvqr2X+Nx1qWDNmJBHPhw/2jRbgLj0XlgqQDBC?= =?Windows-1252?Q?jUv80oAOIsfdLrRWgBhtvQ/kic8In9UL06pr6ZOsgPQDPdx+I8H5cHBN?= =?Windows-1252?Q?+8L+jH+V4PMuMpXfCykJ4Vy42nSl0TLEmwn6MebUmhyMM0VwKqUhJY4z?= =?Windows-1252?Q?vDh3sKiSMrgHTNMEvIJUhwev3k9sHByfUe+JednsFhSUCY6BSunolyXd?= =?Windows-1252?Q?JTNon40GM7uUeIuPwQq1st8QB/nDzU6HbdwQ7OVHs1tk+zvNLz1b/vlF?= =?Windows-1252?Q?WB83e6sGkfIXnbJ4kvL6mGH6DEsefBT3Vyzx38N/2hL4aSG55OE3/I4C?= =?Windows-1252?Q?q+IOVX86w2qPYmDGAQ6vuUkgN+/E92ulm66QI7x4SHCZcix3y2sd9yVE?= =?Windows-1252?Q?MW/Tu2jWHYcnO5cAXr68BnMxBs0NzX7BHbEIIf2CcJufunQwVvPHaZwY?= =?Windows-1252?Q?B6e0WJB31dPDTAIUws6lAvxjClclWsF6QtsGrmROL0YbKCNyusTxn2FC?= =?Windows-1252?Q?NI6sMfQco5JmoXp/cXbetEUkq9/JpOcXO306Zp1iQ2IpmoVvYSfbBDPv?= =?Windows-1252?Q?GVqgnrCQ3cX3Z5pm6xHamgcLDNj3V3fBRpTb4pvd7rkLkxoXIZW+RH2T?= =?Windows-1252?Q?kWYE2P855uFNkjjqAtcCFCgvIrAL5VLAT0DdaHgWzP2PBx2E7rMF+eVq?= =?Windows-1252?Q?we8/q8e1Mnp0nFXnuRrujf2EBOCvVYitcUdMO9Ecd0+dyOfzyjOYKalG?= =?Windows-1252?Q?4ERSq31KJozj0yz53OMVc1eyWus62wfYPzGBPqNgOss78hMwaBpwn6AZ?= =?Windows-1252?Q?s530Txe0sQnALLI9UAj6/rM85I5Qc3jMW7HUxv2PoQ+pnwPvuaXVU1iN?= =?Windows-1252?Q?zrw5UtxYcNdQEgzAZ3WXkdDuB9QUocRdZcpFnYE0InLgtROQ9PDGkTX4?= =?Windows-1252?Q?h5GEpbU7rOaSVECj3rgo677+tGMjK/7xuJrofcPP0Vy3PLeqAkqTIS4t?= =?Windows-1252?Q?AO+jbn7Zb+CoD09x49jBe+MKe0AKcl7L1f/V8eglbM6mV+rv2HGHM+sg?= =?Windows-1252?Q?8ix3dLkTpPw5WU3puPSrrMYSZ8gZLKnODEX0huNvs6ybH4j1kbA5e9Lq?= =?Windows-1252?Q?6tYMr3nIDni4PI0W+BSaYYwGjH/F3aFNZWE7ZuDOXTcXgdu/T1oZPABO?= =?Windows-1252?Q?/EW+uOzV74NBSu7jeCqB5tr588op9FrrxxXbsXfcP6lyboUtw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0440;5:4rxH3fE6RVWJsCylKW+o1KSh7ZdVKQ1ugJcsOXTC43YxP1yPm1Fo9jcQ2PRYwEG4aJSPPoqUm0nJmqb90/g2VehF2TdjkkHEP+pLj8WO8StbNzfJXOokuKKMvbGdFqoQtZrA9nro+hDfu4gxgJxY0w==;24:Aihcfl7K0Zbb03sv1sD1YHmk1awXczEmCHYD+shoEXvSCWNKNxd/pZ72q9CFJuZSOuGm4C8+nWXOVcr/Bf3w8sNqv0fntX5pwL/R1pM9gOw=;20:mTGacC6LmSzWe4DKAKdUagultEzadz/SnAvLJCc+c7rVwPs2egUqc+jPlLq2WvDXOGSg8+Qmr0KtK6IMFdgko6+M0OgsO+cnX792BkOBepZbFIyL6C2sUsVieiDAlNMh0tUmTXF3Nn6gtr8v8ceyVb5xTT+xfyD/Xi+uyyQ1tiuLpHYY4i2WIlbSap2XJVDpzzF0rGvAqkSHCBW291GKgNa6JDGpl70mjYE6upU+u+oYElBSd0OPcspHzCqzvIGd SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2015 18:51:36.4498 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR12MB0440 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/9/2015 12:16 PM, Marc Zyngier wrote: >>>> diff --git a/drivers/irqchip/irq-gic-v2m.c b/drivers/irqchip/irq-gic-v2m.c >>>> >>>[...] >>>> >>>@@ -359,6 +368,8 @@ static int __init gicv2m_init_one(struct fwnode_handle *fwnode, >>>> >>> >>>> >>> if (to_of_node(fwnode)) >>>> >>> name = to_of_node(fwnode)->name; >>>> >>>+ else >>>> >>>+ name = irq_domain_get_irqchip_fwnode_name(fwnode); >>> >> >>> >>Don't bother with that, the name associated with the domain is >>> >>absolutely meaningless. You are already printing the frame address, >>> >>which is enough to identify it, should someone need to debug this. >>> >> >>> >>Drop the name from the previous patch as well, and that will make one >>> >>less difference to care about. Patch #3 can die as well. >>> >> >> > >> >Ok. I'll just leave them blank (i.e. const char *name ="") > No, just remove name altogether. Nobody reads that anyway, and if they > want to find out, there is the address that's clear enough. > > Thanks, > > M. Ok. Suravee From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suravee Suthikulanit Subject: Re: [PATCH v5 5/5] gicv2m: acpi: Introducing GICv2m ACPI support Date: Wed, 9 Dec 2015 12:51:31 -0600 Message-ID: <56687833.6040706@amd.com> References: <1449625686-5594-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1449625686-5594-6-git-send-email-Suravee.Suthikulpanit@amd.com> <20151209103806.41488405@why.wild-wind.fr.eu.org> <56686C9F.6060804@amd.com> <56687008.3020703@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-by2on0086.outbound.protection.outlook.com ([207.46.100.86]:45296 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753280AbbLISvk (ORCPT ); Wed, 9 Dec 2015 13:51:40 -0500 In-Reply-To: <56687008.3020703@arm.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Marc Zyngier Cc: tglx@linutronix.de, jason@lakedaemon.net, rjw@rjwysocki.net, Lorenzo Pieralisi , Will Deacon , Catalin Marinas , hanjun.guo@linaro.org, tomasz.nowicki@linaro.org, graeme.gregory@linaro.org, dhdang@apm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org On 12/9/2015 12:16 PM, Marc Zyngier wrote: >>>> diff --git a/drivers/irqchip/irq-gic-v2m.c b/drivers/irqchip/irq-gic-v2m.c >>>> >>>[...] >>>> >>>@@ -359,6 +368,8 @@ static int __init gicv2m_init_one(struct fwnode_handle *fwnode, >>>> >>> >>>> >>> if (to_of_node(fwnode)) >>>> >>> name = to_of_node(fwnode)->name; >>>> >>>+ else >>>> >>>+ name = irq_domain_get_irqchip_fwnode_name(fwnode); >>> >> >>> >>Don't bother with that, the name associated with the domain is >>> >>absolutely meaningless. You are already printing the frame address, >>> >>which is enough to identify it, should someone need to debug this. >>> >> >>> >>Drop the name from the previous patch as well, and that will make one >>> >>less difference to care about. Patch #3 can die as well. >>> >> >> > >> >Ok. I'll just leave them blank (i.e. const char *name ="") > No, just remove name altogether. Nobody reads that anyway, and if they > want to find out, there is the address that's clear enough. > > Thanks, > > M. Ok. Suravee From mboxrd@z Thu Jan 1 00:00:00 1970 From: suravee.suthikulpanit@amd.com (Suravee Suthikulanit) Date: Wed, 9 Dec 2015 12:51:31 -0600 Subject: [PATCH v5 5/5] gicv2m: acpi: Introducing GICv2m ACPI support In-Reply-To: <56687008.3020703@arm.com> References: <1449625686-5594-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1449625686-5594-6-git-send-email-Suravee.Suthikulpanit@amd.com> <20151209103806.41488405@why.wild-wind.fr.eu.org> <56686C9F.6060804@amd.com> <56687008.3020703@arm.com> Message-ID: <56687833.6040706@amd.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 12/9/2015 12:16 PM, Marc Zyngier wrote: >>>> diff --git a/drivers/irqchip/irq-gic-v2m.c b/drivers/irqchip/irq-gic-v2m.c >>>> >>>[...] >>>> >>>@@ -359,6 +368,8 @@ static int __init gicv2m_init_one(struct fwnode_handle *fwnode, >>>> >>> >>>> >>> if (to_of_node(fwnode)) >>>> >>> name = to_of_node(fwnode)->name; >>>> >>>+ else >>>> >>>+ name = irq_domain_get_irqchip_fwnode_name(fwnode); >>> >> >>> >>Don't bother with that, the name associated with the domain is >>> >>absolutely meaningless. You are already printing the frame address, >>> >>which is enough to identify it, should someone need to debug this. >>> >> >>> >>Drop the name from the previous patch as well, and that will make one >>> >>less difference to care about. Patch #3 can die as well. >>> >> >> > >> >Ok. I'll just leave them blank (i.e. const char *name ="") > No, just remove name altogether. Nobody reads that anyway, and if they > want to find out, there is the address that's clear enough. > > Thanks, > > M. Ok. Suravee