From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965182AbcFMJkZ (ORCPT ); Mon, 13 Jun 2016 05:40:25 -0400 Received: from foss.arm.com ([217.140.101.70]:50072 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964895AbcFMJkY (ORCPT ); Mon, 13 Jun 2016 05:40:24 -0400 Subject: Re: [PATCH v5 4/5] arm64: add support for ACPI Low Power Idle(LPI) To: "Sajjan, Vikas C" References: <1462981062-24909-1-git-send-email-sudeep.holla@arm.com> <1462981062-24909-5-git-send-email-sudeep.holla@arm.com> Cc: "linux-acpi@vger.kernel.org" , "Rafael J. Wysocki" , Sudeep Holla , "linux-kernel@vger.kernel.org" , "Lakshminarasimha, Sunil Vishwanathpur" , Prashanth Prakash , Ashwin Chaugule , Al Stone , Lorenzo Pieralisi , Mark Rutland , "linux-arm-kernel@lists.infradead.org" From: Sudeep Holla Organization: ARM Message-ID: <575E7F84.2000106@arm.com> Date: Mon, 13 Jun 2016 10:40:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/06/16 05:47, Sajjan, Vikas C wrote: > Hi Sudeep, > [...] > --- a/drivers/firmware/psci.c > +++ b/drivers/firmware/psci.c > @@ -13,6 +13,7 @@ > > #define pr_fmt(fmt) "psci: " fmt > > +#include > #include > #include > #include > @@ -310,11 +311,66 @@ static int psci_dt_cpu_init_idle(struct device_node *cpu_node, int cpu) > return ret; > } > > +#ifdef CONFIG_ACPI > +#include > + > +static int __maybe_unused psci_acpi_cpu_init_idle(unsigned int cpu) { > + int i, count; > + u32 *psci_states; > + struct acpi_processor *pr; > + struct acpi_lpi_state *lpi; > + > + pr = per_cpu(processors, cpu); > + if (unlikely(!pr || !pr->flags.has_lpi)) > > Any particular reason for _not_ considering CST flag here. > Or you are planning to add CST support in some other patch set. > Are you referring the old C-state objects ? We don't support them on ARM64. Only LPIs are support. The ARM FFH is not defined for CST, only for LPIs. -- Regards, Sudeep From mboxrd@z Thu Jan 1 00:00:00 1970 From: sudeep.holla@arm.com (Sudeep Holla) Date: Mon, 13 Jun 2016 10:40:20 +0100 Subject: [PATCH v5 4/5] arm64: add support for ACPI Low Power Idle(LPI) In-Reply-To: References: <1462981062-24909-1-git-send-email-sudeep.holla@arm.com> <1462981062-24909-5-git-send-email-sudeep.holla@arm.com> Message-ID: <575E7F84.2000106@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 13/06/16 05:47, Sajjan, Vikas C wrote: > Hi Sudeep, > [...] > --- a/drivers/firmware/psci.c > +++ b/drivers/firmware/psci.c > @@ -13,6 +13,7 @@ > > #define pr_fmt(fmt) "psci: " fmt > > +#include > #include > #include > #include > @@ -310,11 +311,66 @@ static int psci_dt_cpu_init_idle(struct device_node *cpu_node, int cpu) > return ret; > } > > +#ifdef CONFIG_ACPI > +#include > + > +static int __maybe_unused psci_acpi_cpu_init_idle(unsigned int cpu) { > + int i, count; > + u32 *psci_states; > + struct acpi_processor *pr; > + struct acpi_lpi_state *lpi; > + > + pr = per_cpu(processors, cpu); > + if (unlikely(!pr || !pr->flags.has_lpi)) > > Any particular reason for _not_ considering CST flag here. > Or you are planning to add CST support in some other patch set. > Are you referring the old C-state objects ? We don't support them on ARM64. Only LPIs are support. The ARM FFH is not defined for CST, only for LPIs. -- Regards, Sudeep