From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 7F55FE00CEC; Wed, 2 Sep 2015 07:46:39 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, * medium trust * [147.11.1.11 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mail.windriver.com (mail.windriver.com [147.11.1.11]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 3A62FE00A93 for ; Wed, 2 Sep 2015 07:46:35 -0700 (PDT) Received: from ALA-HCB.corp.ad.wrs.com (ala-hcb.corp.ad.wrs.com [147.11.189.41]) by mail.windriver.com (8.15.2/8.15.1) with ESMTPS id t82EkZwc010537 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL) for ; Wed, 2 Sep 2015 07:46:35 -0700 (PDT) Received: from ALA-MBA.corp.ad.wrs.com ([169.254.3.94]) by ALA-HCB.corp.ad.wrs.com ([147.11.189.41]) with mapi id 14.03.0235.001; Wed, 2 Sep 2015 07:46:35 -0700 From: "Reyna, David" To: "BARROS PENA, BELEN" Thread-Topic: [Toaster] [review-request][PATCH] 8126 Messages are missing when "IMAGE_FSTYPES" field is not properly edited Thread-Index: AdDlUtvqImKPGQA8TfCGx6xOKtB8kwADTD+AAAt515A= Date: Wed, 2 Sep 2015 14:46:34 +0000 Message-ID: <5E53D14CE4667A45B9A06760DE5D13D082655F65@ALA-MBA.corp.ad.wrs.com> References: <5E53D14CE4667A45B9A06760DE5D13D082655701@ALA-MBA.corp.ad.wrs.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [147.11.117.104] MIME-Version: 1.0 Cc: "toaster@yoctoproject.org" Subject: Re: [review-request][PATCH] 8126 Messages are missing when "IMAGE_FSTYPES" field is not properly edited X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Sep 2015 14:46:39 -0000 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hi Bel=E9n, Thank you for the observation. I have updated "dreyna/project_fstypes_8126" to address that issue, and the= code now always pre-initializes the warning message element so that the pr= evious value is not dangling. - David > -----Original Message----- > From: Barros Pena, Belen [mailto:belen.barros.pena@intel.com] > Sent: Wednesday, September 02, 2015 2:16 AM > To: Reyna, David > Cc: toaster@yoctoproject.org > Subject: Re: [Toaster] [review-request][PATCH] 8126 Messages are missing > when "IMAGE_FSTYPES" field is not properly edited >=20 >=20 >=20 > On 02/09/2015 08:44, "Reyna, David" wrote: >=20 > >Hi Bel=E9n, > > > >Please find the patch for 8126 here: > > > > dreyna/project_fstypes_8126 >=20 > Hi David, >=20 > This is looking fairly good. I've only run across one problem. This is ho= w > to reproduce: >=20 > 1. Click the 'change' icon for IMAGE_FSTYPES >=20 > 2. Deselect all values: the 'save' button becomes disabled and the messag= e > asking you to select at least one image type appears. This is the expecte= d > behaviour >=20 > 3. Now, click the 'cancel' link. The IMAGE_FSTYPES value stays the way it > was before you clicked the 'change' icon. This is once more the correct > behaviour >=20 > 4. Now click the 'change' icon again. There are image types selected, but > the message 'You must select at least one image type' still shows, and th= e > 'Save' button is disabled. This is not the correct behaviour. As long as > there is at least one checkbox ticked you should see no message and the > 'save' button should be enabled. If you make a change (untick a box), the > validation kicks in and things return to the correct state. Sounds like w= e > need to check the selected values whenever the 'change' icon is clicked >=20 > Thanks! >=20 > Bel=E9n >=20 > > > >Note: for the message 'label' the I insert and then show when there are > >no matches, it is guaranteed not to pollute the database because it can > >never be in the checked state. > > > >- David > > >=20