From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 41B9AE00C2F; Wed, 23 Sep 2015 02:02:52 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, * medium trust * [147.11.1.11 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mail.windriver.com (mail.windriver.com [147.11.1.11]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 4B54BE00A3B for ; Wed, 23 Sep 2015 02:02:47 -0700 (PDT) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail.windriver.com (8.15.2/8.15.1) with ESMTPS id t8N92knx016839 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL) for ; Wed, 23 Sep 2015 02:02:46 -0700 (PDT) Received: from ALA-MBB.corp.ad.wrs.com ([169.254.1.69]) by ALA-HCA.corp.ad.wrs.com ([147.11.189.40]) with mapi id 14.03.0235.001; Wed, 23 Sep 2015 02:02:45 -0700 From: "Reyna, David" To: "WOOD, MICHAEL" Thread-Topic: [Toaster] [review-request][PATCH] 8126 Messages are missing when "IMAGE_FSTYPES" field is not properly edited Thread-Index: AQHQ7vhidJzju3etc0SkL+lMXKyPBZ5J3d6Q Date: Wed, 23 Sep 2015 09:02:44 +0000 Message-ID: <5E53D14CE4667A45B9A06760DE5D13D091B70791@ALA-MBB.corp.ad.wrs.com> References: <5E53D14CE4667A45B9A06760DE5D13D082655701@ALA-MBA.corp.ad.wrs.com> <5E53D14CE4667A45B9A06760DE5D13D082655F65@ALA-MBA.corp.ad.wrs.com> <55F6D760.70602@intel.com> In-Reply-To: <55F6D760.70602@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [147.11.116.98] MIME-Version: 1.0 Cc: "toaster@yoctoproject.org" Subject: Re: [review-request][PATCH] 8126 Messages are missing when "IMAGE_FSTYPES" field is not properly edited X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Sep 2015 09:02:52 -0000 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hi Michael, I have made the requested changes and updated "dreyna/project_fstypes_8126"= , except for this one: > + // Add the 'no search matches' line last > + html +=3D '\n'; >=20 > MW - Rather than appending this to the list just add the text to the #fst= ypes-error-message=20 > and set it it initially to style=3D"display:none" and then toggle it with= .hide .show Bel=E9n's design had this message appear within the selection list when the= re were no search matches instead of in the optional error message below it= . That is why I did this implementation. I do toggle it with .hide .show. - David > -----Original Message----- > From: toaster-bounces@yoctoproject.org [mailto:toaster- > bounces@yoctoproject.org] On Behalf Of Michael Wood > Sent: Monday, September 14, 2015 7:19 AM > To: toaster@yoctoproject.org > Subject: Re: [Toaster] [review-request][PATCH] 8126 Messages are > missing when "IMAGE_FSTYPES" field is not properly edited >=20 > On 02/09/15 16:58, Barros Pena, Belen wrote: > > > > On 02/09/2015 15:46, "Reyna, David" > wrote: > > > >> Hi Bel=E9n, > >> > >> Thank you for the observation. > >> > >> I have updated "dreyna/project_fstypes_8126" to address that issue, > and > >> the code now always pre-initializes the warning message element so > that > >> the previous value is not dangling. > > yep: this seems to behave as expected now. Thanks! > > > > I've also realised that the base branch seems a bit old. Could you > rebase > > and resubmit? > > > > Cheers > > > > Bel=E9n > > > >> - David > >> > >> > >>> -----Original Message----- > >>> From: Barros Pena, Belen [mailto:belen.barros.pena@intel.com] > >>> Sent: Wednesday, September 02, 2015 2:16 AM > >>> To: Reyna, David > >>> Cc: toaster@yoctoproject.org > >>> Subject: Re: [Toaster] [review-request][PATCH] 8126 Messages are > missing > >>> when "IMAGE_FSTYPES" field is not properly edited > >>> > >>> > >>> > >>> On 02/09/2015 08:44, "Reyna, David" > wrote: > >>> > >>>> Hi Bel=E9n, > >>>> > >>>> Please find the patch for 8126 here: > >>>> > >>>> dreyna/project_fstypes_8126 > >>> Hi David, > >>> > >>> This is looking fairly good. I've only run across one problem. > This is > >>> how > >>> to reproduce: > >>> > >>> 1. Click the 'change' icon for IMAGE_FSTYPES > >>> > >>> 2. Deselect all values: the 'save' button becomes disabled and the > >>> message > >>> asking you to select at least one image type appears. This is the > >>> expected > >>> behaviour > >>> > >>> 3. Now, click the 'cancel' link. The IMAGE_FSTYPES value stays the > way > >>> it > >>> was before you clicked the 'change' icon. This is once more the > correct > >>> behaviour > >>> > >>> 4. Now click the 'change' icon again. There are image types > selected, > >>> but > >>> the message 'You must select at least one image type' still shows, > and > >>> the > >>> 'Save' button is disabled. This is not the correct behaviour. As > long as > >>> there is at least one checkbox ticked you should see no message > and the > >>> 'save' button should be enabled. If you make a change (untick a > box), > >>> the > >>> validation kicks in and things return to the correct state. Sounds > like > >>> we > >>> need to check the selected values whenever the 'change' icon is > clicked > >>> > >>> Thanks! > >>> > >>> Bel=E9n > >>> > >>>> Note: for the message 'label' the I insert and then show when > there are > >>>> no matches, it is guaranteed not to pollute the database because > it can > >>>> never be in the checked state. > >>>> > >>>> - David > >>>> >=20 > Some review comments below: >=20 > From bac104e20efc46d4746af58aebb0f920c37edfc3 Mon Sep 17 00:00:00 > 2001 > From: David Reyna > Date: Wed, 2 Sep 2015 15:34:14 -0700 > Subject: bitbake: toaster: display warnings for bad "IMAGE_FSTYPES" > values >=20 > Display warning message for IMAGE_FSTYPES when no value is selected or > when the filter does not have any matches >=20 > [YOCTO #8126] >=20 > Signed-off-by: David Reyna >=20 > diff --git a/bitbake/lib/toaster/toastergui/templates/projectconf.html > b/bitbake/lib/toaster/toastergui/templates/projectconf.html > index 4c5a188..b477b4e 100644 > --- a/bitbake/lib/toaster/toastergui/templates/projectconf.html > +++ b/bitbake/lib/toaster/toastergui/templates/projectconf.html > @@ -43,6 +43,7 @@ > placeholder=3D"Search image types" class=3D"span4"> >
>
> + message"> > > > > @@ -312,9 +313,11 @@ > }); > if ( 0 =3D=3D any_checked ) { >=20 > $("#apply-change- > image_fstypes").attr("disabled","disabled"); > + $('#fstypes-error-message').html("You must select at > least one image type"); >=20 > MW - Given that this error message doesn't change from this text, > rather than adding and removing the text add the text to the DOM in > the #fstypes-error-message element and .hide .show this makes it > easier to update the error message in the html and keeps a slightly > cleaner separation between the UI description and the logic of the > javascript. >=20 > } > else { > $("#apply-change- > image_fstypes").removeAttr("disabled"); > + $('#fstypes-error-message').html(""); > } > } >=20 > @@ -546,10 +549,14 @@ > // Add the un-checked boxes second > for (var i =3D 0, length =3D fstypes_list.length; i < > length; i++) { > if (0 > fstypes.indexOf(" > "+fstypes_list[i].value+" ")) { > - html +=3D '\n' > ; > + html +=3D '\n' > ; > } > } > + // Add the 'no search matches' line last > + html +=3D '\n'; >=20 >=20 > MW - Rather than appending this to the list just add the text to the > #fstypes-error-message and set it it initially to style=3D"display:none" > and then toggle it with .hide .show >=20 > + // Display the list > document.getElementById("all- > image_fstypes").innerHTML =3D html; > + $('#no-match-fstypes').hide(); >=20 > // Watch elements to disable Save when none are > checked > $(".fs-checkbox-fstypes").each(function(){ > @@ -558,8 +565,9 @@ > }); > }); >=20 > - // clear the previous filter values > + // clear the previous filter values and warning > messages > $("input#filter-image_fstypes").val(""); > + $('#fstypes-error-message').html(""); > }); >=20 > $('#cancel-change-image_fstypes').click(function(){ > @@ -569,17 +577,24 @@ > }); >=20 > $('#filter-image_fstypes').on('input', function(){ > - var valThis =3D $(this).val().toLowerCase(); > + var valThis =3D $(this).val().toLowerCase(); > + var match_count=3D0; >=20 >=20 > MW - camelCase please >=20 >=20 > $('#all-image_fstypes label').each(function(){ > var text =3D $(this).text().toLowerCase(); > var match =3D text.indexOf(valThis); > if (match >=3D 0) { > $(this).show(); > + match_count +=3D 1; > } > else { > $(this).hide(); > } > }); > + if (0 =3D=3D match_count) { >=20 >=20 > MW - This should be if (matchCount =3D=3D=3D 0) > triple equals for full equality and variable on the left >=20 >=20 >=20 > + $('#no-match-fstypes').show(); > + } else { > + $('#no-match-fstypes').hide(); > + } > }); >=20 > $('#apply-change-image_fstypes').click(function(){ > -- > cgit v0.10.2 >=20 >=20 >=20 >=20 >=20 >=20 >=20 > -- > _______________________________________________ > toaster mailing list > toaster@yoctoproject.org > https://lists.yoctoproject.org/listinfo/toaster