From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DECE0C2B9F4 for ; Thu, 17 Jun 2021 15:29:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C0581611BE for ; Thu, 17 Jun 2021 15:29:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232301AbhFQPb3 (ORCPT ); Thu, 17 Jun 2021 11:31:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:49273 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231855AbhFQPb2 (ORCPT ); Thu, 17 Jun 2021 11:31:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623943760; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pJAYrboxNY4R4lDYsyxGAHwG1E3b8kp8BFkfADBjg3E=; b=D64Fv/b+luWfIGTjMAtzpsXERz8LnKDbLDnnyiWBAjL6sQc5VFtDkSqlZ4/XYxQ6PEb4LH 6WC0IDs/bxK0FDY2X6L+y0ixEX3QAxMjlPM9HFOKI2rNF3VPSZPpYCPP0R+tsG0xXyoEQ3 CtFRYfuZ1YO/E4rNewQYAWdaF11zj2I= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-337-s05RImu3PoqvIT4ZOklQDA-1; Thu, 17 Jun 2021 11:29:16 -0400 X-MC-Unique: s05RImu3PoqvIT4ZOklQDA-1 Received: by mail-ej1-f71.google.com with SMTP id jy19-20020a1709077633b02903eb7acdb38cso2401042ejc.14 for ; Thu, 17 Jun 2021 08:29:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pJAYrboxNY4R4lDYsyxGAHwG1E3b8kp8BFkfADBjg3E=; b=N6kYoKJmvTqD1Xst2k74rCqN/xHR+VotEsMJkpOkx0GJkmsOtdthMsDmvJ5dVKFp26 hleVcsHImsFZ/juuUvi4hy8ooh5Z9R/piEuv2HnEmO8hHeBucsWBWaDTgfNB6xL0W6Yk CH+yRdy7bQeOOWX3Kfdi5Ew++MmTzY5al1euoa6Oroi7tXt92F42NIhEu1GvS0gODC/C PgVUgj7oFyNhgi4feEG9rGU22+EzcShYrYQMgd1YylzGL1ImJk3r+VF9sT264XK8+h6W NFHo7BYRJstoLbKoQhpMWQgYyxVksEtmE9na+Jg5sr6HDzZpqLR7AbmsbuPv5yXqovXY Bphg== X-Gm-Message-State: AOAM531rZgGYgfh5DAKLKWGZbeZTuPvs2HltRGp8Efb1IR7Dp1RFGTta 89+Q1FxsRsN4GCeqpwQzH3J2oeqUXz7jlMnxAawvMnjb0a1RRZN4P9orF90N75LU40YJmi1mFz+ g3/RbzEkMDpSmaMk7QMGZpA== X-Received: by 2002:a17:906:3c44:: with SMTP id i4mr5844965ejg.135.1623943755563; Thu, 17 Jun 2021 08:29:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwguprspLdKxfz1gQFsWZ9pANB4xL5Og2GYXcQQiXXJdl05NURoTWq9llwpGLS30bGiJxoGJQ== X-Received: by 2002:a17:906:3c44:: with SMTP id i4mr5844929ejg.135.1623943755347; Thu, 17 Jun 2021 08:29:15 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id z19sm4485528edc.90.2021.06.17.08.29.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Jun 2021 08:29:14 -0700 (PDT) Subject: Re: [PATCH v10 2/5] KVM: stats: Add fd-based API to read binary stats data To: Jing Zhang , Greg KH Cc: KVM , KVMARM , LinuxMIPS , KVMPPC , LinuxS390 , Linuxkselftest , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , Will Deacon , Huacai Chen , Aleksandar Markovic , Thomas Bogendoerfer , Paul Mackerras , Christian Borntraeger , Janosch Frank , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Peter Shier , Oliver Upton , David Rientjes , Emanuele Giuseppe Esposito , David Matlack , Ricardo Koller , Krish Sadhukhan , Fuad Tabba References: <20210617044146.2667540-1-jingzhangos@google.com> <20210617044146.2667540-3-jingzhangos@google.com> From: Paolo Bonzini Message-ID: <5ae75b1b-4cba-d06f-625b-35b42f11ac03@redhat.com> Date: Thu, 17 Jun 2021 17:29:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On 17/06/21 16:56, Jing Zhang wrote: > Actually, it is really not easy to separate this change into two patches even by > following Paolo's suggestion. And it would be a surprise to userspace to see > only VM stats, no VCPU stats. That does not matter. Having two or three patches is useful because it makes review easier; they will never appear separately in a release. Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AE05C2B9F4 for ; Thu, 17 Jun 2021 15:29:25 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id D48A96120A for ; Thu, 17 Jun 2021 15:29:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D48A96120A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 53EF64A1A5; Thu, 17 Jun 2021 11:29:24 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@redhat.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vxRcP9jBf7Kr; Thu, 17 Jun 2021 11:29:23 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 6618F4A4A0; Thu, 17 Jun 2021 11:29:23 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 9FF664A1A5 for ; Thu, 17 Jun 2021 11:29:22 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id W91G4UbmRwa3 for ; Thu, 17 Jun 2021 11:29:20 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mm01.cs.columbia.edu (Postfix) with ESMTP id C51EA40825 for ; Thu, 17 Jun 2021 11:29:20 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623943760; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pJAYrboxNY4R4lDYsyxGAHwG1E3b8kp8BFkfADBjg3E=; b=D64Fv/b+luWfIGTjMAtzpsXERz8LnKDbLDnnyiWBAjL6sQc5VFtDkSqlZ4/XYxQ6PEb4LH 6WC0IDs/bxK0FDY2X6L+y0ixEX3QAxMjlPM9HFOKI2rNF3VPSZPpYCPP0R+tsG0xXyoEQ3 CtFRYfuZ1YO/E4rNewQYAWdaF11zj2I= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-130-A0o1Vx14Onq77xuNRvy6Ww-1; Thu, 17 Jun 2021 11:29:16 -0400 X-MC-Unique: A0o1Vx14Onq77xuNRvy6Ww-1 Received: by mail-ed1-f71.google.com with SMTP id p24-20020aa7c8980000b0290393c37fdcb8so1789969eds.6 for ; Thu, 17 Jun 2021 08:29:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pJAYrboxNY4R4lDYsyxGAHwG1E3b8kp8BFkfADBjg3E=; b=YskgnlQW8rkxbBAm1bjD/+az/gqY7SmwaPVkgxcf7Ctsmgbhk0p/k+/inFi4c0LSn/ l0vhxIqYgruNMvYpikT/eBwXNVIA68LnwyJ3cCrJtMBVrF1kA2WVrmO34kvUPcTf6T/R vHie+FPxdlTcNWv7/zk0ZSLuatwLdY3b1vJHPtYSlqx45MWkVye3s6oFWYokEraF5XDo wgG0ENIb7dCVGXrQdrqWZszmFPMWOHnao+FkRqrsIHmzUnlGI4zSx/zrZZ0HXJzDrO8c WehfnAixx/qKC4jFh0GaPc10Wo6AQWX9/ouFs7uTqKQZttC5ytRy8Jvk5wrDe0E219GJ 8l3g== X-Gm-Message-State: AOAM532UD7qLyZkDyEN36KqaBy6sMFXB+8uPXFTiyWyOQzuVIQ8LpwmG 3AqgbORb86yiZ95fEgZX+X2aztzKgjHgVUPiIKjD9fNWSXphrYu04qK0mYxtnkppreXjpkHwkIA ZBORw7Yxkte12UxZfW/lve2ls X-Received: by 2002:a17:906:3c44:: with SMTP id i4mr5844984ejg.135.1623943755604; Thu, 17 Jun 2021 08:29:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwguprspLdKxfz1gQFsWZ9pANB4xL5Og2GYXcQQiXXJdl05NURoTWq9llwpGLS30bGiJxoGJQ== X-Received: by 2002:a17:906:3c44:: with SMTP id i4mr5844929ejg.135.1623943755347; Thu, 17 Jun 2021 08:29:15 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id z19sm4485528edc.90.2021.06.17.08.29.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Jun 2021 08:29:14 -0700 (PDT) Subject: Re: [PATCH v10 2/5] KVM: stats: Add fd-based API to read binary stats data To: Jing Zhang , Greg KH References: <20210617044146.2667540-1-jingzhangos@google.com> <20210617044146.2667540-3-jingzhangos@google.com> From: Paolo Bonzini Message-ID: <5ae75b1b-4cba-d06f-625b-35b42f11ac03@redhat.com> Date: Thu, 17 Jun 2021 17:29:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Cc: KVM , David Hildenbrand , Paul Mackerras , Linuxkselftest , Claudio Imbrenda , Will Deacon , KVMARM , Emanuele Giuseppe Esposito , LinuxS390 , Janosch Frank , Marc Zyngier , Huacai Chen , Christian Borntraeger , Aleksandar Markovic , David Rientjes , KVMPPC , Krish Sadhukhan , David Matlack , Jim Mattson , Thomas Bogendoerfer , Sean Christopherson , Cornelia Huck , Peter Shier , LinuxMIPS , Vitaly Kuznetsov X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On 17/06/21 16:56, Jing Zhang wrote: > Actually, it is really not easy to separate this change into two patches even by > following Paolo's suggestion. And it would be a surprise to userspace to see > only VM stats, no VCPU stats. That does not matter. Having two or three patches is useful because it makes review easier; they will never appear separately in a release. Paolo _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Date: Thu, 17 Jun 2021 15:29:12 +0000 Subject: Re: [PATCH v10 2/5] KVM: stats: Add fd-based API to read binary stats data Message-Id: <5ae75b1b-4cba-d06f-625b-35b42f11ac03@redhat.com> List-Id: References: <20210617044146.2667540-1-jingzhangos@google.com> <20210617044146.2667540-3-jingzhangos@google.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jing Zhang , Greg KH Cc: KVM , KVMARM , LinuxMIPS , KVMPPC , LinuxS390 , Linuxkselftest , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , Will Deacon , Huacai Chen , Aleksandar Markovic , Thomas Bogendoerfer , Paul Mackerras , Christian Borntraeger , Janosch Frank , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Peter Shier , Oliver Upton , David Rientjes , Emanuele Giuseppe Esposito , David Matlack , Ricardo Koller , Krish Sadhukhan , Fuad Tabba On 17/06/21 16:56, Jing Zhang wrote: > Actually, it is really not easy to separate this change into two patches even by > following Paolo's suggestion. And it would be a surprise to userspace to see > only VM stats, no VCPU stats. That does not matter. Having two or three patches is useful because it makes review easier; they will never appear separately in a release. Paolo