* [PATCH] tests: add missing genh dependency
@ 2020-09-11 13:42 Paolo Bonzini
2020-09-11 13:57 ` Claudio Fontana
2020-09-11 14:28 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Paolo Bonzini @ 2020-09-11 13:42 UTC (permalink / raw
To: qemu-devel; +Cc: Claudio Fontana
Fix high-parallelism builds by forcing all generated headers
to be created before tests are compiled.
Reported-by: Claudio Fontana <cfontana@suse.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
tests/meson.build | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/meson.build b/tests/meson.build
index 3683512dca..e2b915ea8f 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -56,7 +56,7 @@ test_qapi_files = custom_target('Test QAPI files',
# perhaps change qapi_gen to replace / with _, like Meson itself does?
subdir('include')
-libtestqapi = static_library('testqapi', sources: [test_qapi_files, test_qapi_outputs_extra])
+libtestqapi = static_library('testqapi', sources: [test_qapi_files, genh, test_qapi_outputs_extra])
testqapi = declare_dependency(link_with: libtestqapi)
testblock = declare_dependency(dependencies: [block], sources: 'iothread.c')
@@ -223,7 +223,7 @@ foreach test_name, extra: tests
src += test_ss.all_sources()
deps += test_ss.all_dependencies()
endif
- exe = executable(test_name, src, dependencies: deps)
+ exe = executable(test_name, src, genh, dependencies: deps)
test(test_name, exe,
depends: test_deps.get(test_name, []),
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tests: add missing genh dependency
2020-09-11 13:42 [PATCH] tests: add missing genh dependency Paolo Bonzini
@ 2020-09-11 13:57 ` Claudio Fontana
2020-09-11 14:28 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Claudio Fontana @ 2020-09-11 13:57 UTC (permalink / raw
To: Paolo Bonzini, qemu-devel
On 9/11/20 3:42 PM, Paolo Bonzini wrote:
> Fix high-parallelism builds by forcing all generated headers
> to be created before tests are compiled.
>
> Reported-by: Claudio Fontana <cfontana@suse.de>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> tests/meson.build | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/meson.build b/tests/meson.build
> index 3683512dca..e2b915ea8f 100644
> --- a/tests/meson.build
> +++ b/tests/meson.build
> @@ -56,7 +56,7 @@ test_qapi_files = custom_target('Test QAPI files',
> # perhaps change qapi_gen to replace / with _, like Meson itself does?
> subdir('include')
>
> -libtestqapi = static_library('testqapi', sources: [test_qapi_files, test_qapi_outputs_extra])
> +libtestqapi = static_library('testqapi', sources: [test_qapi_files, genh, test_qapi_outputs_extra])
> testqapi = declare_dependency(link_with: libtestqapi)
>
> testblock = declare_dependency(dependencies: [block], sources: 'iothread.c')
> @@ -223,7 +223,7 @@ foreach test_name, extra: tests
> src += test_ss.all_sources()
> deps += test_ss.all_dependencies()
> endif
> - exe = executable(test_name, src, dependencies: deps)
> + exe = executable(test_name, src, genh, dependencies: deps)
>
> test(test_name, exe,
> depends: test_deps.get(test_name, []),
>
Tested with 160 processors,
make -j120
Tested-by: Claudio Fontana <cfontana@suse.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tests: add missing genh dependency
2020-09-11 13:42 [PATCH] tests: add missing genh dependency Paolo Bonzini
2020-09-11 13:57 ` Claudio Fontana
@ 2020-09-11 14:28 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-09-11 14:28 UTC (permalink / raw
To: Paolo Bonzini, qemu-devel; +Cc: Claudio Fontana
On 9/11/20 3:42 PM, Paolo Bonzini wrote:
> Fix high-parallelism builds by forcing all generated headers
> to be created before tests are compiled.
FYI I had this problem too (simply building with -j8)
simply adding a new qapi/file.json.
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> Reported-by: Claudio Fontana <cfontana@suse.de>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> tests/meson.build | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/meson.build b/tests/meson.build
> index 3683512dca..e2b915ea8f 100644
> --- a/tests/meson.build
> +++ b/tests/meson.build
> @@ -56,7 +56,7 @@ test_qapi_files = custom_target('Test QAPI files',
> # perhaps change qapi_gen to replace / with _, like Meson itself does?
> subdir('include')
>
> -libtestqapi = static_library('testqapi', sources: [test_qapi_files, test_qapi_outputs_extra])
> +libtestqapi = static_library('testqapi', sources: [test_qapi_files, genh, test_qapi_outputs_extra])
> testqapi = declare_dependency(link_with: libtestqapi)
>
> testblock = declare_dependency(dependencies: [block], sources: 'iothread.c')
> @@ -223,7 +223,7 @@ foreach test_name, extra: tests
> src += test_ss.all_sources()
> deps += test_ss.all_dependencies()
> endif
> - exe = executable(test_name, src, dependencies: deps)
> + exe = executable(test_name, src, genh, dependencies: deps)
>
> test(test_name, exe,
> depends: test_deps.get(test_name, []),
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-11 14:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-11 13:42 [PATCH] tests: add missing genh dependency Paolo Bonzini
2020-09-11 13:57 ` Claudio Fontana
2020-09-11 14:28 ` Philippe Mathieu-Daudé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.