From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A3CAC4338F for ; Wed, 28 Jul 2021 23:45:59 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 434A6604DB for ; Wed, 28 Jul 2021 23:45:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 434A6604DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 913FE82D82; Thu, 29 Jul 2021 01:45:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="FKHuBN8J"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id EFB8482D9C; Thu, 29 Jul 2021 01:45:54 +0200 (CEST) Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D6F3782CDA for ; Thu, 29 Jul 2021 01:45:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1627515950; bh=J0JKmppDUtKVhVsubZRMSVJ4TZQG2+wQkB0VKI47r+w=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=FKHuBN8JoGGynFioRFE92+HQZyEvfyWYXPaxcj8DcXqlvhQ8BcwfQZHyCyVwgApR0 gWxQFL7YJDqSpSk/jEMnIjoYrJ2FlE/3FUPnSh+2jy58sEQuPHrbguWPEvYLaRMGTA M9Nsw4YahL3FO0qifdJRoJfMaidZl+sZCOO7TYw4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.123.35] ([88.152.144.157]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MC30P-1mKfTP07fZ-00CQiE; Thu, 29 Jul 2021 01:45:50 +0200 Subject: Re: [PATCH v2 7/9] Make EFI_LOADER depend on DM and OF_CONTROL To: Simon Glass Cc: U-Boot Mailing List , Ilias Apalodimas , =?UTF-8?Q?Pali_Roh=c3=a1r?= , Mark Kettenis , Tom Rini References: <20210702183620.1542680-1-sjg@chromium.org> <20210702183620.1542680-4-sjg@chromium.org> <20210726220735.GA8013@bill-the-cat> From: Heinrich Schuchardt Message-ID: <5dba1547-37cc-14f0-1514-1dc337b0d25e@gmx.de> Date: Thu, 29 Jul 2021 01:45:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210726220735.GA8013@bill-the-cat> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:IgySyBVFNSywUhHFWWKTnBDRY7R6XqgkAANzLnLcdAQpEZ25B2S 2+nIy+s60L3kuX7+kJlrBcqmF16gw9J1dk44kTV3oWCsD/8X9KOP7fzuRHiLoa4fttuc1tW CoDEzQYq2Vk0Tea5vo8v+TeEfpsPDhdGAg4LqrQ1EOKU7LiB6TXHCGqyjmlhj8pRbEWOiZe p8Ruq+dPfhd47UsXMczGQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:LEW8W5g1zd8=:7/U1LhAQG7WU4hKgPDE0WC 9aiuBJKbCBYCfMBY7nhKz/373M7+hYDXp7qXNbqXE7PZtnTS2qDe+4X1SRvq33VJFWOCS3BAC 6VzhiqO2mjwxS7WM0r4WzbcCSpMa+zG/qsdomuxkt4kPjGJBNZtDpr3SASXKwhzQMr7Bt88NY v2zl95tMkhT3IfOuQ13/1mNfbRzCikJ2Ak+3fGoTKQfB0rVj7taYt8w/V+kN4naZnVmZAR7Wl A+GAgeX04oyKUws0bZeic9O4sES3oOdRp2hcqtzII2p4mveE4U7w5pNwhWnavJbhLK1z3dTwz CQ43GljF9nGM97tW2Xy3EFv34F/W90+dTtKvbFYmQhUCCPg2cQnG/bGOscBOEPMWIjsZUQeTu Y3gmlvenf6++FIPJb1BkQC2WCVqVQgB+c/PtHdveJElGqk2WFLKm+a/AL/Gx7aZXvGSSb+ktv 3MjrmCJq93a5UTtuazrVCg3+Aq6ucuMN1EvliIkLZ/1IWiaEdr5RR244bz8ZubUQ7fyxnOB9C AI3GXaPieqj1j1QoMMTJgb7lmdMzcJHAFu8VoI+PNStnQURYq8q8sRxYZnNFX8uEvxCio5Smf AaAnOkY3QiJ/EQYlPb4E7WfjU6nqSFNSCFH+saOG6gu53Ng15yIX+BNwPKJhAq+LuK/FPQYRl TFKFEsZVTooaAjl7Ed2YZ++fYLWJKX5PD5AiriMYVKdXP1zf2UDql1Z9oDpbwzMtNm7WTUQiA 2oUNkt743Ygcp7UbvBOUIcshGglLcQVWs/Th3J7ZKTysXfm6wqRIFXbYgdpPCqV1Yw4vM3PL8 3EuTAsWtDHj2GDihvIt2svvkcpTaE/DOqzsG8cNBr9uXG1uTLguFe6C3gVGOzAC1qucv0uZ28 pGfIj+wI9Qwr9vS8YQyYf8mO9Gv/kXnIr3gOmi/VH2tv0CFLICZHMKMOUJ6WWqFaP2A0h1TbZ nkYiWvBIqEO6cbV0IZHQyMyvIaKzMGMRSqUeO6bMx6rIfaAwEa1BqiNmh1OmdNI0YPF8Ni7s/ RIiD+RfJK9XBTc5NwdUYwv6A0jQLbHiW0tGgH8vyVIMbiZo7/CXH1lKPbyfUQDmY5UE9mS1+C 5GTuwylvmbPPFntDTXx7n8RJXLiiQR8uCsP X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 7/27/21 12:07 AM, Tom Rini wrote: > On Fri, Jul 02, 2021 at 12:36:18PM -0600, Simon Glass wrote: > >> This feature should never have been made available when driver model >> or devicetree are disabled. Add these as conditions, so that we don't >> create even more barriers to migration. >> >> Add a note about the substantial size increment associated with this >> option. >> >> Signed-off-by: Simon Glass >> --- >> >> Changes in v2: >> - Split out new patch to make EFI_LOADER depend on DM and OF_CONTROL >> - Note the approximate size of this feature in the help >> >> lib/efi_loader/Kconfig | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig >> index 6242caceb7f..466abfed300 100644 >> --- a/lib/efi_loader/Kconfig >> +++ b/lib/efi_loader/Kconfig >> @@ -1,6 +1,6 @@ >> config EFI_LOADER >> bool "Support running UEFI applications" >> - depends on OF_LIBFDT && ( \ >> + depends on OF_LIBFDT && DM && OF_CONTROL && ( \ Didn't Tom eliminate all boards without CONFIG_DM? Shouldn't we get rid of this symbol? Are there boards using DM and not OF_CONTROL or OF_CONTROL and not DM? Why are these separate symbols? Isn't this symbol to be eliminated, too? lib/efi_loader/efi_disk.c is the only place where we maintain duplicate code for DM and non-DM. A dependency on CONFIG_BLK (which itself depends on CONFIG_DM) would make more sense to me. But only in a patch eliminating the non-BLK code. >> ARM && (SYS_CPU =3D arm1136 || \ >> SYS_CPU =3D arm1176 || \ >> SYS_CPU =3D armv7 || \ >> @@ -25,6 +25,8 @@ config EFI_LOADER >> will expose the UEFI API to a loaded application, enabling it to >> reuse U-Boot's device drivers. >> >> + For ARM 32-bit, this adds about 90KB to the size of U-Boot. >> + There is no unit ISO prefix K. Do you mean KiB? 90 KiB may be the value today. Will you update it regularly? Otherwise don't put a number here. I can't see that the effect on size is truly architecture specific. Why do you refer to 32bit ARM? Such a comment would better fit into a documentation chapter on downsizing U-Boot. Best regards Heinrich >> if EFI_LOADER >> >> config CMD_BOOTEFI_BOOTMGR > > Note that we have platforms today with EFI_LOADER without OF_CONTROL, so > this isn't strictly the right requirements. What do you think here > Heinrich? > >