From: Mat Martineau <mathew.j.martineau@linux.intel.com>
To: Davide Caratti <dcaratti@redhat.com>
Cc: mptcp@lists.linux.dev,
Matthieu Baerts <matthieu.baerts@tessares.net>,
mptcp@lists.01.org
Subject: Re: [PATCH net-next] mptcp: drop all sub-options except ADD_ADDR when the echo bit is set
Date: Fri, 26 Mar 2021 11:39:17 -0700 (PDT) [thread overview]
Message-ID: <5e58a6a0-7470-7498-4f45-a61641c3691@linux.intel.com> (raw)
In-Reply-To: <aeb4b7f3044e2f869ae026f950eb70c4398dad63.1616761454.git.dcaratti@redhat.com>
On Fri, 26 Mar 2021, Davide Caratti wrote:
> Current Linux carries echo-ed ADD_ADDR over pure TCP ACKs, so there is no
> need to add a DSS element that would fit only ADD_ADDR with IPv4 address.
> Drop the DSS from echo-ed ADD_ADDR, regardless of the IP version.
>
> Signed-off-by: Davide Caratti <dcaratti@redhat.com>
> ---
> net/mptcp/options.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Thanks Davide, looks good to me. This didn't land in patchwork without the
mptcp@lists.01.org cc, but we should have mptcp@lists.linux.dev routed in
to patchwork by Monday (Australia time).
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
>
> diff --git a/net/mptcp/options.c b/net/mptcp/options.c
> index c7eb61d0564c..d51c3ad54d9a 100644
> --- a/net/mptcp/options.c
> +++ b/net/mptcp/options.c
> @@ -624,7 +624,8 @@ static bool mptcp_established_options_add_addr(struct sock *sk, struct sk_buff *
> int len;
>
> if ((mptcp_pm_should_add_signal_ipv6(msk) ||
> - mptcp_pm_should_add_signal_port(msk)) &&
> + mptcp_pm_should_add_signal_port(msk) ||
> + mptcp_pm_should_add_signal_echo(msk)) &&
> skb && skb_is_tcp_pure_ack(skb)) {
> pr_debug("drop other suboptions");
> opts->suboptions = 0;
> --
> 2.30.2
--
Mat Martineau
Intel
next prev parent reply other threads:[~2021-03-26 18:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 12:28 [PATCH net-next] mptcp: drop all sub-options except ADD_ADDR when the echo bit is set Davide Caratti
2021-03-26 13:57 ` Davide Caratti
2021-03-26 18:39 ` Mat Martineau [this message]
2021-03-30 13:43 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e58a6a0-7470-7498-4f45-a61641c3691@linux.intel.com \
--to=mathew.j.martineau@linux.intel.com \
--cc=dcaratti@redhat.com \
--cc=matthieu.baerts@tessares.net \
--cc=mptcp@lists.01.org \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.