From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9E0CC48BDF for ; Tue, 15 Jun 2021 12:42:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B34C961461 for ; Tue, 15 Jun 2021 12:42:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230272AbhFOMoF (ORCPT ); Tue, 15 Jun 2021 08:44:05 -0400 Received: from foss.arm.com ([217.140.110.172]:34450 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230175AbhFOMoD (ORCPT ); Tue, 15 Jun 2021 08:44:03 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6EBC51063; Tue, 15 Jun 2021 05:41:59 -0700 (PDT) Received: from [10.57.9.136] (unknown [10.57.9.136]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5FDAC3F719; Tue, 15 Jun 2021 05:41:58 -0700 (PDT) Subject: Re: [PATCH v3 3/6] iommu: Improve iommu_iotlb_gather helpers To: Yong Wu , Nadav Amit Cc: linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Jiajun Cao , Will Deacon References: <20210607182541.119756-1-namit@vmware.com> <20210607182541.119756-4-namit@vmware.com> <1623760166.24285.1.camel@mhfsdcap03> From: Robin Murphy Message-ID: <5f176808-20ab-1d51-fcae-eb2307117f5b@arm.com> Date: Tue, 15 Jun 2021 13:41:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <1623760166.24285.1.camel@mhfsdcap03> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-06-15 13:29, Yong Wu wrote: > On Mon, 2021-06-07 at 11:25 -0700, Nadav Amit wrote: >> From: Robin Murphy >> >> The Mediatek driver is not the only one which might want a basic >> address-based gathering behaviour, so although it's arguably simple >> enough to open-code, let's factor it out for the sake of cleanliness. >> Let's also take this opportunity to document the intent of these >> helpers for clarity. >> >> Cc: Joerg Roedel >> Cc: Will Deacon >> Cc: Jiajun Cao >> Cc: Robin Murphy >> Cc: Lu Baolu >> Cc: iommu@lists.linux-foundation.org >> Cc: linux-kernel@vger.kernel.org >> Signed-off-by: Robin Murphy >> >> --- >> >> Changes from Robin's version: >> * Added iommu_iotlb_gather_add_range() stub !CONFIG_IOMMU_API >> * Use iommu_iotlb_gather_add_range() in iommu_iotlb_gather_add_page() >> --- >> drivers/iommu/mtk_iommu.c | 5 +---- >> include/linux/iommu.h | 43 ++++++++++++++++++++++++++++++++++----- >> 2 files changed, 39 insertions(+), 9 deletions(-) >> >> diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c >> index e06b8a0e2b56..0af4a91ac7da 100644 >> --- a/drivers/iommu/mtk_iommu.c >> +++ b/drivers/iommu/mtk_iommu.c >> @@ -523,10 +523,7 @@ static size_t mtk_iommu_unmap(struct iommu_domain *domain, >> struct mtk_iommu_domain *dom = to_mtk_domain(domain); >> unsigned long end = iova + size - 1; > > Please also help delete this "end". Yes, that was part of my original patch - not sure what happened here :/ Robin. >> >> - if (gather->start > iova) >> - gather->start = iova; >> - if (gather->end < end) >> - gather->end = end; >> + iommu_iotlb_gather_add_range(gather, iova, size); >> return dom->iop->unmap(dom->iop, iova, size, gather); >> } > > [snip] > > > _______________________________________________ > iommu mailing list > iommu@lists.linux-foundation.org > https://lists.linuxfoundation.org/mailman/listinfo/iommu > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BE9EC48BE8 for ; Tue, 15 Jun 2021 12:42:04 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2062961464 for ; Tue, 15 Jun 2021 12:42:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2062961464 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id CFD9783B7D; Tue, 15 Jun 2021 12:42:03 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id y14mqi3R0yCH; Tue, 15 Jun 2021 12:42:03 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id A37B383B6D; Tue, 15 Jun 2021 12:42:02 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 86B75C000D; Tue, 15 Jun 2021 12:42:02 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 707E0C000B for ; Tue, 15 Jun 2021 12:42:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 519E06080C for ; Tue, 15 Jun 2021 12:42:01 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TVO2MskXqE8i for ; Tue, 15 Jun 2021 12:42:00 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp3.osuosl.org (Postfix) with ESMTP id 3BDCB6058A for ; Tue, 15 Jun 2021 12:42:00 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6EBC51063; Tue, 15 Jun 2021 05:41:59 -0700 (PDT) Received: from [10.57.9.136] (unknown [10.57.9.136]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5FDAC3F719; Tue, 15 Jun 2021 05:41:58 -0700 (PDT) Subject: Re: [PATCH v3 3/6] iommu: Improve iommu_iotlb_gather helpers To: Yong Wu , Nadav Amit References: <20210607182541.119756-1-namit@vmware.com> <20210607182541.119756-4-namit@vmware.com> <1623760166.24285.1.camel@mhfsdcap03> From: Robin Murphy Message-ID: <5f176808-20ab-1d51-fcae-eb2307117f5b@arm.com> Date: Tue, 15 Jun 2021 13:41:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <1623760166.24285.1.camel@mhfsdcap03> Content-Language: en-GB Cc: iommu@lists.linux-foundation.org, Will Deacon , linux-kernel@vger.kernel.org, Jiajun Cao X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On 2021-06-15 13:29, Yong Wu wrote: > On Mon, 2021-06-07 at 11:25 -0700, Nadav Amit wrote: >> From: Robin Murphy >> >> The Mediatek driver is not the only one which might want a basic >> address-based gathering behaviour, so although it's arguably simple >> enough to open-code, let's factor it out for the sake of cleanliness. >> Let's also take this opportunity to document the intent of these >> helpers for clarity. >> >> Cc: Joerg Roedel >> Cc: Will Deacon >> Cc: Jiajun Cao >> Cc: Robin Murphy >> Cc: Lu Baolu >> Cc: iommu@lists.linux-foundation.org >> Cc: linux-kernel@vger.kernel.org >> Signed-off-by: Robin Murphy >> >> --- >> >> Changes from Robin's version: >> * Added iommu_iotlb_gather_add_range() stub !CONFIG_IOMMU_API >> * Use iommu_iotlb_gather_add_range() in iommu_iotlb_gather_add_page() >> --- >> drivers/iommu/mtk_iommu.c | 5 +---- >> include/linux/iommu.h | 43 ++++++++++++++++++++++++++++++++++----- >> 2 files changed, 39 insertions(+), 9 deletions(-) >> >> diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c >> index e06b8a0e2b56..0af4a91ac7da 100644 >> --- a/drivers/iommu/mtk_iommu.c >> +++ b/drivers/iommu/mtk_iommu.c >> @@ -523,10 +523,7 @@ static size_t mtk_iommu_unmap(struct iommu_domain *domain, >> struct mtk_iommu_domain *dom = to_mtk_domain(domain); >> unsigned long end = iova + size - 1; > > Please also help delete this "end". Yes, that was part of my original patch - not sure what happened here :/ Robin. >> >> - if (gather->start > iova) >> - gather->start = iova; >> - if (gather->end < end) >> - gather->end = end; >> + iommu_iotlb_gather_add_range(gather, iova, size); >> return dom->iop->unmap(dom->iop, iova, size, gather); >> } > > [snip] > > > _______________________________________________ > iommu mailing list > iommu@lists.linux-foundation.org > https://lists.linuxfoundation.org/mailman/listinfo/iommu > _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu