From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964949AbbLHLOQ (ORCPT ); Tue, 8 Dec 2015 06:14:16 -0500 Received: from gimli.pxnet.com ([89.1.7.7]:59701 "EHLO mail.pxnet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933376AbbLHLOO (ORCPT ); Tue, 8 Dec 2015 06:14:14 -0500 Message-Id: <61b60d7eff05eddf305460f3dae2b80221f08aad.1449570042.git.tilman@imap.cc> In-Reply-To: References: From: Tilman Schmidt Subject: [PATCH 3/3] ser_gigaset: remove unnecessary kfree() calls from release method To: Paul Bolle , netdev@vger.kernel.org Cc: Peter Hurley , Sasha Levin , , David Miller , Karsten Keil , isdn4linux@listserv.isdn4linux.de, , Date: Tue, 8 Dec 2015 12:00:33 +0100 (CET) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (mail.pxnet.com [IPv6:2001:4dd0:f004:7::7]); Tue, 08 Dec 2015 12:00:46 +0100 (CET) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org device->platform_data and platform_device->resource are never used and remain NULL through their entire life. Drops the kfree() calls for them from the device release method. Signed-off-by: Tilman Schmidt Reported-by: Paul Bolle --- drivers/isdn/gigaset/ser-gigaset.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/isdn/gigaset/ser-gigaset.c b/drivers/isdn/gigaset/ser-gigaset.c index 2693cb2..b7e0329 100644 --- a/drivers/isdn/gigaset/ser-gigaset.c +++ b/drivers/isdn/gigaset/ser-gigaset.c @@ -375,13 +375,8 @@ static void gigaset_freecshw(struct cardstate *cs) static void gigaset_device_release(struct device *dev) { - struct platform_device *pdev = to_platform_device(dev); struct cardstate *cs = dev_get_drvdata(dev); - /* adapted from platform_device_release() in drivers/base/platform.c */ - kfree(dev->platform_data); - kfree(pdev->resource); - if (!cs) return; dev_set_drvdata(dev, NULL); -- 1.9.2.459.g68773ac