From: Arnout Vandecappelle via buildroot <buildroot@buildroot.org>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>,
buildroot@buildroot.org
Cc: Romain Naour <romain.naour@gmail.com>,
Julien Corjon <corjon.j@ecagroup.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Fabrice Fontaine <fontaine.fabrice@gmail.com>
Subject: Re: [Buildroot] [PATCH] toolchain: remove gcc bug 90620
Date: Sun, 28 Apr 2024 19:18:10 +0200 [thread overview]
Message-ID: <6446e4c0-3501-4875-8a89-4db3fb369911@mind.be> (raw)
In-Reply-To: <20240413074923.1082313-1-giulio.benetti@benettiengineering.com>
On 13/04/2024 09:49, Giulio Benetti wrote:
> While building packages affected by gcc bug 90620 with Microblaze
> and gcc versions 11, 12, 13 built with Buildroot and external Bootlin
> toolchains without -O0 work-around it turns out that the bug has been
> fixed. So let's remove gcc bug 90620.
But a custom external toolchain that uses GCC <10 would still be affected, no?
So you can't actually remove it? You can just remove the
|| BR2_TOOLCHAIN_GCC_AT_LEAST_11 part.
Regards,
Arnout
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> package/haproxy/haproxy.mk | 8 +-------
> package/qt5/qt5base/qt5base.mk | 5 -----
> package/qt5/qt5xmlpatterns/qt5xmlpatterns.mk | 4 ----
> toolchain/Config.in | 9 ---------
> 4 files changed, 1 insertion(+), 25 deletions(-)
>
> diff --git a/package/haproxy/haproxy.mk b/package/haproxy/haproxy.mk
> index 61a9ebebe4..697dbdf4bf 100644
> --- a/package/haproxy/haproxy.mk
> +++ b/package/haproxy/haproxy.mk
> @@ -74,15 +74,9 @@ endif
>
> HAPROXY_MAKE_OPTS += ADDLIB="$(HAPROXY_LIBS)"
>
> -HAPROXY_CFLAGS = $(TARGET_CFLAGS)
> -
> -ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_90620),y)
> -HAPROXY_CFLAGS += -O0
> -endif
> -
> define HAPROXY_BUILD_CMDS
> $(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \
> - $(HAPROXY_MAKE_OPTS) DEFINE="$(HAPROXY_CFLAGS)" -C $(@D)
> + $(HAPROXY_MAKE_OPTS) DEFINE="$(TARGET_CFLAGS)" -C $(@D)
> endef
>
> define HAPROXY_INSTALL_TARGET_CMDS
> diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk
> index e173639cca..d6445be9b2 100644
> --- a/package/qt5/qt5base/qt5base.mk
> +++ b/package/qt5/qt5base/qt5base.mk
> @@ -50,11 +50,6 @@ QT5BASE_CONFIGURE_OPTS += -no-optimize-debug
> QT5BASE_CFLAGS = $(TARGET_CFLAGS)
> QT5BASE_CXXFLAGS = $(TARGET_CXXFLAGS)
>
> -ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_90620),y)
> -QT5BASE_CFLAGS += -O0
> -QT5BASE_CXXFLAGS += -O0
> -endif
> -
> ifeq ($(BR2_X86_CPU_HAS_SSE2),)
> QT5BASE_CONFIGURE_OPTS += -no-sse2
> else ifeq ($(BR2_X86_CPU_HAS_SSE3),)
> diff --git a/package/qt5/qt5xmlpatterns/qt5xmlpatterns.mk b/package/qt5/qt5xmlpatterns/qt5xmlpatterns.mk
> index 2126d3c915..f99baa1be7 100644
> --- a/package/qt5/qt5xmlpatterns/qt5xmlpatterns.mk
> +++ b/package/qt5/qt5xmlpatterns/qt5xmlpatterns.mk
> @@ -20,8 +20,4 @@ ifeq ($(BR2_PACKAGE_QT5BASE_EXAMPLES),y)
> QT5XMLPATTERNS_LICENSE += , BSD-3-Clause (examples)
> endif
>
> -ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_90620),y)
> -QT5XMLPATTERNS_CONF_OPTS += "QMAKE_CXXFLAGS+=-O0"
> -endif
> -
> $(eval $(qmake-package))
> diff --git a/toolchain/Config.in b/toolchain/Config.in
> index 944e573f82..de5ef7a08f 100644
> --- a/toolchain/Config.in
> +++ b/toolchain/Config.in
> @@ -170,15 +170,6 @@ config BR2_TOOLCHAIN_HAS_GCC_BUG_85862
> default y if BR2_microblaze
> depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7
>
> -# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90620
> -# ICE: in do_output_reload, at reload1.c:7978 on microblaze.
> -# This bug no longer exists in gcc 10.x but reappeared in gcc 11.x
> -config BR2_TOOLCHAIN_HAS_GCC_BUG_90620
> - bool
> - default y if BR2_microblaze
> - depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_10 \
> - || BR2_TOOLCHAIN_GCC_AT_LEAST_11
> -
> # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93847
> # ICE: compiler error: Segmentation fault on Nios II. This bug
> # no longer exists in gcc 9.x.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-04-28 17:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-13 7:49 [Buildroot] [PATCH] toolchain: remove gcc bug 90620 Giulio Benetti
2024-04-28 17:18 ` Arnout Vandecappelle via buildroot [this message]
2024-04-28 18:35 ` Giulio Benetti
2024-05-09 15:48 ` Thomas Petazzoni via buildroot
2024-05-09 20:19 ` Arnout Vandecappelle via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6446e4c0-3501-4875-8a89-4db3fb369911@mind.be \
--to=buildroot@buildroot.org \
--cc=arnout@mind.be \
--cc=corjon.j@ecagroup.com \
--cc=fontaine.fabrice@gmail.com \
--cc=giulio.benetti@benettiengineering.com \
--cc=romain.naour@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.