From: Ira Weiny <ira.weiny@intel.com>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Ira Weiny <ira.weiny@intel.com>
Cc: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>,
Dan Williams <dan.j.williams@intel.com>,
Shiju Jose <shiju.jose@huawei.com>,
Yazen Ghannam <yazen.ghannam@amd.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Dave Jiang <dave.jiang@intel.com>,
Alison Schofield <alison.schofield@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Ard Biesheuvel <ardb@kernel.org>, <linux-efi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>
Subject: Re: [PATCH RFC v4 5/6] firmware/efi: Process CXL Component Events
Date: Wed, 13 Dec 2023 14:28:03 -0800 [thread overview]
Message-ID: <657a2ff3bcc0b_25c9c7294ab@iweiny-mobl.notmuch> (raw)
In-Reply-To: <20231213171351.00004579@Huawei.com>
Jonathan Cameron wrote:
> On Wed, 29 Nov 2023 06:28:01 -0800
> Ira Weiny <ira.weiny@intel.com> wrote:
>
[snip]
> > > __packed attribute just for cper_cxl_event_rec still fails to properly
> > > align structure elements. Looks like, __packed attribute is needed for
> > > all structs (cper_cxl_event_devid and cper_cxl_event_sn) inside
> > > cper_cxl_event_rec.
> > >
> > > Seems easier to use global pragma instead.. I could test and obtain the
> > > output as expected using pragma..
> >
> > I did not know that was acceptable in the kernel but I see you used it in
> > cper_cxl.h before...
> >
> > Ok I'll do that and spin again.
> >
> > Thanks so much for testing this! I was out last week and still don't have
> > a test environment.
>
> Easy to hack into QEMU :) Hmm. I have a CCIX patch set from years ago
> somewhere that does similar. Would be easy to repurposed. Looks like
> I never published them (just told people to ask if they wanted them :( ).
>
> Anyhow, if useful I can dig them out.
If you have a branch with them with a somewhat latest qemu that could work
too.
Ira
next prev parent reply other threads:[~2023-12-13 22:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 22:07 [PATCH RFC v4 0/6] efi/cxl-cper: Report CPER CXL component events through trace events Ira Weiny
2023-11-09 22:07 ` [PATCH RFC v4 1/6] cxl/trace: Pass uuid explicitly to event traces Ira Weiny
2023-11-09 22:07 ` [PATCH RFC v4 2/6] cxl/events: Promote CXL event structures to a core header Ira Weiny
2023-11-09 22:07 ` [PATCH RFC v4 3/6] cxl/events: Separate UUID from event structures Ira Weiny
2023-11-09 22:07 ` [PATCH RFC v4 4/6] cxl/events: Create a CXL event union Ira Weiny
2023-11-09 22:07 ` [PATCH RFC v4 5/6] firmware/efi: Process CXL Component Events Ira Weiny
2023-11-28 20:32 ` Smita Koralahalli
2023-11-29 14:28 ` Ira Weiny
2023-12-13 17:13 ` Jonathan Cameron
2023-12-13 22:28 ` Ira Weiny [this message]
2023-12-19 17:12 ` Jonathan Cameron
2023-12-20 23:48 ` Ira Weiny
2024-01-03 17:50 ` Jonathan Cameron
2024-01-03 20:40 ` Ira Weiny
2023-11-09 22:07 ` [PATCH RFC v4 6/6] cxl/memdev: Register for and process CPER events Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=657a2ff3bcc0b_25c9c7294ab@iweiny-mobl.notmuch \
--to=ira.weiny@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=Smita.KoralahalliChannabasappa@amd.com \
--cc=alison.schofield@intel.com \
--cc=ardb@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shiju.jose@huawei.com \
--cc=vishal.l.verma@intel.com \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.