From: Mat Martineau <mathew.j.martineau@linux.intel.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: matthieu.baerts@tessares.net, davem@davemloft.net,
kuba@kernel.org, netdev@vger.kernel.org, mptcp@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mptcp: Remove redundant assignment to remaining
Date: Tue, 15 Jun 2021 16:52:25 -0700 (PDT) [thread overview]
Message-ID: <66162447-1f70-a6b9-f18a-179a54f8e97@linux.intel.com> (raw)
In-Reply-To: <1623754538-85616-1-git-send-email-jiapeng.chong@linux.alibaba.com>
On Tue, 15 Jun 2021, Jiapeng Chong wrote:
> Variable remaining is assigned, but this value is never read as it is
> not used later on, hence it is a redundant assignment and can be
> removed.
>
> Clean up the following clang-analyzer warning:
>
> net/mptcp/options.c:779:3: warning: Value stored to 'remaining' is never
> read [clang-analyzer-deadcode.DeadStores].
>
> net/mptcp/options.c:547:3: warning: Value stored to 'remaining' is never
> read [clang-analyzer-deadcode.DeadStores].
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> net/mptcp/options.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/net/mptcp/options.c b/net/mptcp/options.c
> index 9b263f2..f99272f 100644
> --- a/net/mptcp/options.c
> +++ b/net/mptcp/options.c
> @@ -544,7 +544,6 @@ static bool mptcp_established_options_dss(struct sock *sk, struct sk_buff *skb,
>
> map_size = TCPOLEN_MPTCP_DSS_BASE + TCPOLEN_MPTCP_DSS_MAP64;
>
> - remaining -= map_size;
Hi Jiapeng, thank you for your MPTCP patch!
This change in mptcp_established_options_dss() removes the only reference
to 'remaining' in that function, so the variable should also be removed
from the function parameters. It also appears to be unused in
mptcp_established_options_mp().
I'd like to handle this patch through the MPTCP tree so we can manage
conflicts with other in-progress patches. This patch does apply to
net-next cleanly but not our subsystem branch. You can find our git repo
at https://github.com/multipath-tcp/mptcp_net-next, and develop patches
using the 'export' branch. If you email a v2 patch to
mptcp@lists.linux.dev (no need to cc other lists), Matthieu and I can make
sure it is integrated in the MPTCP repository and handle sending it to
netdev along with other patches from the MPTCP community.
> dss_size = map_size;
> if (mpext)
> opts->ext_copy = *mpext;
> @@ -776,7 +775,6 @@ bool mptcp_established_options(struct sock *sk, struct sk_buff *skb,
>
> if (mptcp_established_options_mp_prio(sk, &opt_size, remaining, opts)) {
> *size += opt_size;
> - remaining -= opt_size;
> ret = true;
> }
>
> --
> 1.8.3.1
Best regards,
--
Mat Martineau
Intel
prev parent reply other threads:[~2021-06-15 23:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 10:55 [PATCH] mptcp: Remove redundant assignment to remaining Jiapeng Chong
2021-06-15 23:52 ` Mat Martineau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66162447-1f70-a6b9-f18a-179a54f8e97@linux.intel.com \
--to=mathew.j.martineau@linux.intel.com \
--cc=davem@davemloft.net \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthieu.baerts@tessares.net \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.