* [PATCH] net: sun8i-emac: Allow all RGMII PHY modes
@ 2020-11-16 9:46 Andre Przywara
2020-11-30 17:23 ` Heinrich Schuchardt
0 siblings, 1 reply; 4+ messages in thread
From: Andre Przywara @ 2020-11-16 9:46 UTC (permalink / raw
To: u-boot
So far all GBit users of the sun8i-emac driver were using the "rgmii"
PHY mode, even though this turns out to be mostly wrong. It just worked
because the PHY driver doesn't do the proper setup (yet).
In fact for most boards the "rgmii-id" or "rgmii-txid" PHY modes are the
correct ones.
To allow the DTs to describe the phy-mode correctly, and to stay
compatible with Linux, at least allow those other RGMII modes in the
driver.
This avoids breakage if mainline DTs will be synced with U-Boot.
An almost identical patch (f1239d8aa84d) was merged into the Linux driver
and has been backported to stable kernels.
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
drivers/net/sun8i_emac.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/sun8i_emac.c b/drivers/net/sun8i_emac.c
index 4524604126c..5db33f5c135 100644
--- a/drivers/net/sun8i_emac.c
+++ b/drivers/net/sun8i_emac.c
@@ -353,6 +353,9 @@ static int sun8i_emac_set_syscon(struct sun8i_eth_pdata *pdata,
/* default */
break;
case PHY_INTERFACE_MODE_RGMII:
+ case PHY_INTERFACE_MODE_RGMII_ID:
+ case PHY_INTERFACE_MODE_RGMII_RXID:
+ case PHY_INTERFACE_MODE_RGMII_TXID:
reg |= SC_EPIT | SC_ETCS_INT_GMII;
break;
case PHY_INTERFACE_MODE_RMII:
--
2.17.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] net: sun8i-emac: Allow all RGMII PHY modes
2020-11-16 9:46 [PATCH] net: sun8i-emac: Allow all RGMII PHY modes Andre Przywara
@ 2020-11-30 17:23 ` Heinrich Schuchardt
2021-01-13 22:42 ` André Przywara
0 siblings, 1 reply; 4+ messages in thread
From: Heinrich Schuchardt @ 2020-11-30 17:23 UTC (permalink / raw
To: u-boot
On 11/16/20 10:46 AM, Andre Przywara wrote:
> So far all GBit users of the sun8i-emac driver were using the "rgmii"
> PHY mode, even though this turns out to be mostly wrong. It just worked
> because the PHY driver doesn't do the proper setup (yet).
> In fact for most boards the "rgmii-id" or "rgmii-txid" PHY modes are the
> correct ones.
>
> To allow the DTs to describe the phy-mode correctly, and to stay
> compatible with Linux, at least allow those other RGMII modes in the
> driver.
>
> This avoids breakage if mainline DTs will be synced with U-Boot.
>
> An almost identical patch (f1239d8aa84d) was merged into the Linux driver
> and has been backported to stable kernels.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Hello Joe,
could we get this into v2021.01, please?
Acked-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] net: sun8i-emac: Allow all RGMII PHY modes
2020-11-30 17:23 ` Heinrich Schuchardt
@ 2021-01-13 22:42 ` André Przywara
2021-01-14 18:21 ` Joe Hershberger
0 siblings, 1 reply; 4+ messages in thread
From: André Przywara @ 2021-01-13 22:42 UTC (permalink / raw
To: u-boot
On 30/11/2020 17:23, Heinrich Schuchardt wrote:
Hi Joe,
> On 11/16/20 10:46 AM, Andre Przywara wrote:
>> So far all GBit users of the sun8i-emac driver were using the "rgmii"
>> PHY mode, even though this turns out to be mostly wrong. It just worked
>> because the PHY driver doesn't do the proper setup (yet).
>> In fact for most boards the "rgmii-id" or "rgmii-txid" PHY modes are the
>> correct ones.
>>
>> To allow the DTs to describe the phy-mode correctly, and to stay
>> compatible with Linux, at least allow those other RGMII modes in the
>> driver.
>>
>> This avoids breakage if mainline DTs will be synced with U-Boot.
>>
>> An almost identical patch (f1239d8aa84d) was merged into the Linux driver
>> and has been backported to stable kernels.
>>
>> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Are you going to take this through your tree?
Or are you OK with me merging this through u-boot-sunxi?
We depend on this for a DT update, which relies on those new PHY modes.
Cheers,
Andre
>
> Hello Joe,
>
> could we get this into v2021.01, please?
>
> Acked-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] net: sun8i-emac: Allow all RGMII PHY modes
2021-01-13 22:42 ` André Przywara
@ 2021-01-14 18:21 ` Joe Hershberger
0 siblings, 0 replies; 4+ messages in thread
From: Joe Hershberger @ 2021-01-14 18:21 UTC (permalink / raw
To: u-boot
On Wed, Jan 13, 2021 at 4:43 PM Andr? Przywara <andre.przywara@arm.com> wrote:
>
> On 30/11/2020 17:23, Heinrich Schuchardt wrote:
>
> Hi Joe,
>
> > On 11/16/20 10:46 AM, Andre Przywara wrote:
> >> So far all GBit users of the sun8i-emac driver were using the "rgmii"
> >> PHY mode, even though this turns out to be mostly wrong. It just worked
> >> because the PHY driver doesn't do the proper setup (yet).
> >> In fact for most boards the "rgmii-id" or "rgmii-txid" PHY modes are the
> >> correct ones.
> >>
> >> To allow the DTs to describe the phy-mode correctly, and to stay
> >> compatible with Linux, at least allow those other RGMII modes in the
> >> driver.
> >>
> >> This avoids breakage if mainline DTs will be synced with U-Boot.
> >>
> >> An almost identical patch (f1239d8aa84d) was merged into the Linux driver
> >> and has been backported to stable kernels.
> >>
> >> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
>
> Are you going to take this through your tree?
> Or are you OK with me merging this through u-boot-sunxi?
> We depend on this for a DT update, which relies on those new PHY modes.
Feel free to take it through your tree.
Cheers,
-Joe
> Cheers,
> Andre
>
> >
> > Hello Joe,
> >
> > could we get this into v2021.01, please?
> >
> > Acked-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-14 18:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-16 9:46 [PATCH] net: sun8i-emac: Allow all RGMII PHY modes Andre Przywara
2020-11-30 17:23 ` Heinrich Schuchardt
2021-01-13 22:42 ` André Przywara
2021-01-14 18:21 ` Joe Hershberger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.