From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Yinbo Zhu <zhuyinbo@loongson.cn>, Mark Brown <broonie@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Jianmin Lv <lvjianmin@loongson.cn>,
wanghongliang@loongson.cn, Liu Peibao <liupeibao@loongson.cn>,
loongson-kernel@lists.loongnix.cn
Subject: Re: [PATCH v12 1/2] spi: add loongson spi bindings
Date: Thu, 8 Jun 2023 09:45:40 +0200 [thread overview]
Message-ID: <6ebed84c-2b42-c981-7b3f-e71cc88e4c2c@linaro.org> (raw)
In-Reply-To: <20230608072819.25930-2-zhuyinbo@loongson.cn>
On 08/06/2023 09:28, Yinbo Zhu wrote:
> Add the Loongson platform spi binding with DT schema format using
> json-schema.
Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.
The prefix for SPI should be: "spi: dt-bindings: ". In the same time
last "bindings" are redundant.
>
> Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../bindings/spi/loongson,ls2k-spi.yaml | 41 +++++++++++++++++++
> MAINTAINERS | 6 +++
> 2 files changed, 47 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
>
> diff --git a/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml b/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
> new file mode 100644
> index 000000000000..423ee851edd5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
Filename based on compatible.
> @@ -0,0 +1,41 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/spi/loongson,ls2k-spi.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Loongson SPI controller
> +
> +maintainers:
> + - Yinbo Zhu <zhuyinbo@loongson.cn>
> +
> +allOf:
> + - $ref: /schemas/spi/spi-controller.yaml#
> +
> +properties:
> + compatible:
> + enum:
> + - loongson,ls2k1000-spi
No compatibles for other devices? Didn't we have big discussion about this?
https://elixir.bootlin.com/linux/v6.1-rc1/source/Documentation/devicetree/bindings/writing-bindings.rst#L42
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-06-08 7:45 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 7:28 [PATCH v12 0/2] spi: loongson: add bus driver for the loongson spi Yinbo Zhu
2023-06-08 7:28 ` [PATCH v12 1/2] spi: add loongson spi bindings Yinbo Zhu
2023-06-08 7:45 ` Krzysztof Kozlowski [this message]
2023-06-08 8:39 ` zhuyinbo
2023-06-08 8:53 ` Krzysztof Kozlowski
2023-06-08 10:00 ` zhuyinbo
2023-06-08 10:02 ` Krzysztof Kozlowski
2023-06-08 11:42 ` zhuyinbo
2023-06-08 11:45 ` Krzysztof Kozlowski
2023-06-08 12:10 ` zhuyinbo
2023-06-08 13:26 ` Krzysztof Kozlowski
2023-06-09 3:13 ` zhuyinbo
2023-06-09 16:45 ` Krzysztof Kozlowski
2023-06-12 7:13 ` zhuyinbo
2023-06-12 7:17 ` Krzysztof Kozlowski
2023-06-12 7:40 ` zhuyinbo
2023-06-12 8:16 ` Krzysztof Kozlowski
2023-06-12 11:29 ` zhuyinbo
2023-06-12 18:03 ` Krzysztof Kozlowski
2023-06-13 2:04 ` zhuyinbo
2023-06-08 7:28 ` [PATCH v12 2/2] spi: loongson: add bus driver for the loongson spi controller Yinbo Zhu
2023-06-08 10:15 ` Andy Shevchenko
2023-06-08 10:18 ` Andy Shevchenko
2023-06-09 7:13 ` zhuyinbo
2023-06-08 10:29 ` Mark Brown
2023-06-08 11:45 ` zhuyinbo
2023-06-08 11:53 ` Mark Brown
2023-06-09 3:17 ` zhuyinbo
2023-06-09 7:10 ` zhuyinbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ebed84c-2b42-c981-7b3f-e71cc88e4c2c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=liupeibao@loongson.cn \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=lvjianmin@loongson.cn \
--cc=robh+dt@kernel.org \
--cc=wanghongliang@loongson.cn \
--cc=zhuyinbo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.