From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v15 1/4] ethdev: add apis to support access device info Date: Wed, 15 Jul 2015 08:16:06 +0200 Message-ID: <7196644.zbOgvuZnbg@xps13> References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com> <1436840331-13112-1-git-send-email-liang-min.wang@intel.com> <1436840331-13112-2-git-send-email-liang-min.wang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Liang-Min Larry Wang Return-path: Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by dpdk.org (Postfix) with ESMTP id 37900376D for ; Wed, 15 Jul 2015 08:19:05 +0200 (CEST) Received: by widjy10 with SMTP id jy10so118514415wid.1 for ; Tue, 14 Jul 2015 23:19:04 -0700 (PDT) In-Reply-To: <1436840331-13112-2-git-send-email-liang-min.wang@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-07-13 22:18, Liang-Min Larry Wang: > --- a/lib/librte_ether/Makefile > +++ b/lib/librte_ether/Makefile > @@ -51,6 +51,7 @@ SRCS-y += rte_ethdev.c > SYMLINK-y-include += rte_ether.h > SYMLINK-y-include += rte_ethdev.h > SYMLINK-y-include += rte_eth_ctrl.h > +SYMLINK-y-include += rte_eth_dev_info.h This file is not related to ethernet so it could be named rte_dev_info.h > +struct rte_dev_reg_info { > + void *buf; /**< Buffer for register */ Maybe data would be more accurate. > + uint32_t offset; /**< Offset for 1st register to fetch */ Please precise offset from which point? Why offset is needed? > + uint32_t leng; /**< Number of registers to fetch */ 2 more characters for free: length > +struct rte_dev_eeprom_info { > + void *buf; /**< Buffer for eeprom */ > + uint32_t offset; /**< Offset for 1st eeprom location to access */ > + uint32_t leng; /**< Length of eeprom region to access */ Same as above for these 3 fields. > + uint32_t magic; /**< Device ID */ What means magic? Is it always a device id? > --- a/lib/librte_ether/rte_ether_version.map > +++ b/lib/librte_ether/rte_ether_version.map > @@ -114,5 +114,11 @@ DPDK_2.1 { > rte_eth_timesync_enable; > rte_eth_timesync_read_rx_timestamp; > rte_eth_timesync_read_tx_timestamp; > + rte_eth_dev_default_mac_addr_set; > + rte_eth_dev_reg_length; > + rte_eth_dev_reg_info; > + rte_eth_dev_eeprom_length; > + rte_eth_dev_get_eeprom; > + rte_eth_dev_set_eeprom; It is not in alphabetical order.